Change the shown model when the viewer changes.
todo: close model if all gcodes are closed D13177
patrickelectric | |
tcanabrava | |
laysrodrigues |
Change the shown model when the viewer changes.
todo: close model if all gcodes are closed D13177
No Linters Available |
No Unit Test Coverage |
src/widgets/3dview/viewer3d.cpp | ||
---|---|---|
38 | don't initialize a string to empty using "", this actually creates a string of size 0 having the '\0' char. | |
40–41 | this looks like a debug code that was forgot. | |
61 | hm? why would you do this? | |
73 | use qCDebug | |
74 | stray space. | |
src/widgets/gcodeeditorwidget.cpp | ||
100–102 | the order of the emits matter? |
src/mainwindow.cpp | ||
---|---|---|
80 | This should have been removed durring previous merge | |
src/widgets/3dview/viewer3d.cpp | ||
38 | I will remove this and use its default. | |
61 | This is part of D12719 | |
73 | This area needs code still. Here we should be clearing the view. The Debug and space will go when finished. |
An update is coming soon....
src/widgets/3dview/viewer3d.cpp | ||
---|---|---|
73 | It seams that Its not always cleaned. For example if you load 3 files sometimes you will not see the 3rd one drawn but it will show its url correctly.(this issue is not created from this patch) Ideally we viewer3d would have a clear() method so we can clear the contents of the view before we draw and anytime we do not have a model loaded. |