| rizzitello | |
| tcanabrava | |
| patrickelectric |
| Atelier |
Signed-off-by: Lays Rodrigues <lays.rodrigues@kde.org>
Change layout and add method to hide thermo
doesn't have a heated bed.
QGridLayout
Signed-off-by: Lays Rodrigues <lays.rodrigues@kde.org>
Hide BedThermo - AtCoreInstance
On AtCoreInstance, get the variable from profile and
hide the widget if necessary.
Signed-off-by: Lays Rodrigues <lays.rodrigues@kde.org>
| No Linters Available |
| No Unit Test Coverage |
Looks good but please wire it so that if your connected to a profile and you change it you see the change without needing to connect / disconnect.
We read the profile before connection. We don't have any event that monitor changes on the profile to make updates on the ui. I think that its safer if the use disconnects and connects again to reload the profile, so we can have a little more security on that.
| src/widgets/bedextruderwidget.cpp | ||
|---|---|---|
| 127 | I don't see how's that is better than my ternary. | |
it allows us to toggle the visibility of the bed thermo . This way I don't have to change it after merging D13317
| src/widgets/bedextruderwidget.cpp | ||
|---|---|---|
| 127 | please follow Qt Convention | |
| src/widgets/bedextruderwidget.h | ||
|---|---|---|
| 42 | no need to set the value | |
| src/widgets/bedextruderwidget.h | ||
|---|---|---|
| 42 | why a hide should pass a bool? | |
| src/widgets/bedextruderwidget.h | ||
|---|---|---|
| 42 | that was because the first purpose was to only hide the thermo. I didnt though on update the method name. | |