> std::for_each(beginKey, rangeEnd, [&list,&propMap](const KFileMetaData::Property::Property& s) { list.append(propMap[s]); });

the []operator always returns the most recently inserted value for the same key according to docs. You must iterate over the values directly.

Qt 5.10. is required since KF 5.55: https://kde.org/announcements/kde-frameworks-5.55.0.php.

That said, I think the issue is in this line

In D20739#653376, @rjvbb wrote:

Hi,

I'm updating some of my packaging for a set-up that should meet the minimum requirements that were current when this commit was made (Qt 5.9 and KF5 5.60.0; baloo-widgets 19.08.3 requires Qt 5.8 and KF5 5.58.0). Evidently this change wasn't checked against those requirements; the constKeyValue* iterators were introduced in Qt 5.10 (this lack of testing is also apparent in filemetadatadatedisplaytest.cpp:57!)

I've tried to roll a Qt 5.9 implementation of the new algorithm, but apparently failed:

Can I ask some feedback (from @astippich maybe)?

I'm updating some of my packaging for a set-up that should meet the minimum requirements that were current when this commit was made (Qt 5.9 and KF5 5.60.0; baloo-widgets 19.08.3 requires Qt 5.8 and KF5 5.58.0). Evidently this change wasn't checked against those requirements; the constKeyValue* iterators were introduced in Qt 5.10 (this lack of testing is also apparent in filemetadatadatedisplaytest.cpp:57!)

In D28980#652256, @bruns wrote:

In D28980#652102, @mgallien wrote:

To be clear, I am fine with this change going in.

I would still like to work on a proper solution to allow an application to monitor moved files or similar stuff without having to add file system watchers itself (duplicate from Baloo owns watchers).

Do you have an idea ?

Elisa would need to register something like a "persistent query". This is something also dolphin needs - there definitely already is some notification between dolphin/baloo, but that is not working properly.

This could be something like "Audio files in ~/Music/", "Audio files in ~/Audio books/", etc., and you get a signal whenever the query would return a different result.

In D28980#652102, @mgallien wrote:

To be clear, I am fine with this change going in.

I would still like to work on a proper solution to allow an application to monitor moved files or similar stuff without having to add file system watchers itself (duplicate from Baloo owns watchers).

Do you have an idea ?

In D28980#652087, @mgallien wrote:

The unusual method to get notified is about avoiding signaling moved files if nobody is watching. Baloo will only callback if applications have registered themselves.

To be clear, I am fine with this change going in.

The unusual method to get notified is about avoiding signaling moved files if nobody is watching. Baloo will only callback if applications have registered themselves.

Sorry for the lack of time to do a proper review.

Okay, since there seems to be no interest at all as even a short reply is not given, I am done here

In D28956#651795, @apol wrote:

You're using QDeadlineTimer weird. Why don't you use QDeadlineTimer::remainingTime() and ::setDeadline?

You're using QDeadlineTimer weird. Why don't you use QDeadlineTimer::remainingTime() and ::setDeadline?

See D28940

Thanks for the notice.

add missing tests

whitespace

Thanks, makes sense to me!

extend summary

Can you explain the conceptual reasoning behind this change?

Extend commit message, reduce idle timeout

add line break before closing brace in lambda, use 2 minutes

In D28862#649411, @broulik wrote:

It used to be 2 minutes, now it's 1?

It used to be 2 minutes, now it's 1?

Bump KF5_MIN_VERSION

Thanks