IdleStateMonitor is just a wrapper around KIdleTime, which can be
implemented in a few lines inline.
Details
Details
- Reviewers
ngraham - Group Reviewers
Baloo - Commits
- R293:bd502bf0af46: [Extractor] Remove IdleStateMonitor wrapper class
Diff Detail
Diff Detail
- Repository
- R293 Baloo
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
It used to be 0 minutes ... 1 minute is completely sufficient.
| src/file/extractor/app.cpp | ||
|---|---|---|
| 59 | Because its used recurrently in a slot in a later patch | |
| src/file/extractor/app.cpp | ||
|---|---|---|
| 63 | Side note - both the Frameworks and the reference Qt coding style say nothing about lambdas. If you read the connect(...); as a single statement, it should stay as is. If you read the lambda as a function, the closing brace should go on a separate line. | |