The patch looks OK but I'm a bit worried about trying to lock the cache at the same time we're potentially trying to delete a KSharedDataCache so I'm going to recompile and do some stress and sanity tests first.

Jul 20 2018, 9:28 PM · Frameworks

Jul 15 2018

mpyne committed R249:543b8ae67c57: libintl: Determine if _nl_msg_cat_cntr exists before use (authored by awilcox).

libintl: Determine if _nl_msg_cat_cntr exists before use

Jul 15 2018, 6:13 PM

mpyne accepted D12233: Avoid manipulation of lists with quadratic complexity.

I don't use Baloo directly but I've taken a look from a code sanity perspective and agree with @dhaumann that the change is a proper port of the existing logic.

Jul 15 2018, 5:51 PM · Baloo, Frameworks

Jul 9 2018

mpyne committed R365:15642ae064fc: mojo: Be consistent with phase names so U/I works right. (authored by mpyne).

mojo: Be consistent with phase names so U/I works right.

Jul 9 2018, 3:05 AM

mpyne committed R365:77b8c2d9b9a2: mojo: Fix the U/I showing update/build status in random order. (authored by mpyne).

mojo: Fix the U/I showing update/build status in random order.

Jul 9 2018, 3:05 AM

mpyne committed R365:1d92318697a3: mojo: Add some detail and color to build_done and build_progress (authored by mpyne).

mojo: Add some detail and color to build_done and build_progress

Jul 9 2018, 3:05 AM

mpyne committed R365:a49ecb14d519: mojo: Clean up some of the duplicate spam to the U/I. (authored by mpyne).

mojo: Clean up some of the duplicate spam to the U/I.

Jul 9 2018, 3:05 AM

mpyne committed R365:362ef0f7fdb9: mojo: Reorganize event notification code for new clients. (authored by mpyne).

mojo: Reorganize event notification code for new clients.

Jul 9 2018, 3:05 AM

mpyne committed R365:cfd2d8c128e9: mojo: Complete porting build-status.pl into kdesrc-build. (authored by mpyne).

mojo: Complete porting build-status.pl into kdesrc-build.

Jul 9 2018, 3:05 AM

mpyne committed R365:049e9bfce2de: mojo: Add some detail back to the default U/I. (authored by mpyne).

mojo: Add some detail back to the default U/I.

Jul 9 2018, 3:05 AM

mpyne committed R365:68e22f673a5a: mojo: Remove old StatusView code in favor of event-driven U/I. (authored by mpyne).

mojo: Remove old StatusView code in favor of event-driven U/I.

Jul 9 2018, 3:05 AM

mpyne committed R365:d29cc1313cb4: mojo: WIP for promise-based U/I. (authored by mpyne).

mojo: WIP for promise-based U/I.

Jul 9 2018, 3:05 AM

mpyne committed R365:11dd34f4c1a4: mojo: WIP 2, using new UI iface. (authored by mpyne).

mojo: WIP 2, using new UI iface.

Jul 9 2018, 3:05 AM

Jul 7 2018

mpyne added a comment to D13627: [KSharedDataCache] Assume lock before flush changes.

In D13627#287837, @anthonyfieroni wrote:

https://phabricator.kde.org/source/kiconthemes/browse/master/src/kiconloader.cpp$603
So the problem maybe not here as IconLoader loads icons but in icon writer
@davidedmundson , @dfaure who writes icon-cache.kcache in ~/.cache ?

Jul 7 2018, 4:07 PM · Frameworks

Jul 4 2018

mpyne committed R344:117646dd6232: Bring back inline tag editing. (authored by mpyne).

Bring back inline tag editing.

Jul 4 2018, 11:35 PM

mpyne committed R365:3dbada64198c: setup: Make the setup script work with cmake-installed kdesrc-build. (authored by mpyne).

setup: Make the setup script work with cmake-installed kdesrc-build.

Jul 4 2018, 8:22 PM

mpyne committed R365:ff11a6b079eb: Merge remote-tracking branch 'origin/master' into make_it_mojo (authored by mpyne).

Merge remote-tracking branch 'origin/master' into make_it_mojo

Jul 4 2018, 8:00 PM

Jul 2 2018

mpyne committed R344:7d165d3b9b5f: Remove slight bias in random track selection. (authored by mpyne).

Remove slight bias in random track selection.

Jul 2 2018, 2:21 AM

mpyne committed R344:cb388f252a4e: GIT_SILENT Remove unused header. (authored by mpyne).

GIT_SILENT Remove unused header.

Jul 2 2018, 2:21 AM

Jul 1 2018

mpyne committed R365:7f92da7b307c: Don't double-set CMAKE_PREFIX_PATH if set by user. (authored by mpyne).

Don't double-set CMAKE_PREFIX_PATH if set by user.

Jul 1 2018, 11:18 PM

mpyne committed R365:14b5093bf153: Fake a JSON module to make --pretend work without kde-build-metadata. (authored by mpyne).

Fake a JSON module to make --pretend work without kde-build-metadata.

Jul 1 2018, 11:18 PM

Jun 29 2018

mpyne accepted D9748: Give Juk a playback power inhibitor..

I've tested, it compiles and installs fine and seems to work in my testing with qdbusviewer to verify that the inhibition is set during playback. I'm not sure of a better way to test on my system since I don't go crazy with power management anyways but it's at least good enough to commit and get out to a wider user base for testing.

Jun 29 2018, 4:09 AM

May 27 2018

mpyne committed R365:ca30f09b511e: Add testcase for bug 394497 (ignore-modules/include-dependencies). (authored by mpyne).

Add testcase for bug 394497 (ignore-modules/include-dependencies).

May 27 2018, 8:51 PM

mpyne committed R365:fe41e0645de8: Fix --ignore-modules with --include-dependencies active. (authored by mpyne).

Fix --ignore-modules with --include-dependencies active.

May 27 2018, 8:51 PM

May 16 2018

mpyne committed R365:4a875d8d7877: kde-cmake: Add CMAKE_{MODULE,PREFIX}_PATH consistently. (authored by mpyne).

kde-cmake: Add CMAKE_{MODULE,PREFIX}_PATH consistently.

May 16 2018, 3:27 AM

May 12 2018

mpyne added a comment to D12739: Ignore system standard path when prepending environment variables.

OK thanks. Please commit whenever you're ready.

May 12 2018, 12:26 AM

May 9 2018

mpyne accepted D12739: Ignore system standard path when prepending environment variables.

Looks good to me, but do you know if there are any other directories we'd need to check (on Unixy systems) besides /usr?

May 9 2018, 11:59 PM

May 1 2018

mpyne committed R365:ac5cc6f1ba4c: doc: Correct spelling of --set-module-option-value (authored by mpyne).

doc: Correct spelling of --set-module-option-value

May 1 2018, 2:30 AM

mpyne committed R365:829624ebfcf5: Reboot a small test suite. (authored by mpyne).

Reboot a small test suite.

May 1 2018, 2:30 AM

Apr 26 2018

mpyne committed R344:f523576b0b6a: Merge remote-tracking branch 'origin/master' into Applications/18.04 (authored by mpyne).

Merge remote-tracking branch 'origin/master' into Applications/18.04

Apr 26 2018, 1:15 AM

Apr 18 2018

mpyne committed R365:8dffb8044978: mojo: Fix compile error with CLI status viewer. (authored by mpyne).

mojo: Fix compile error with CLI status viewer.

Apr 18 2018, 3:51 AM

Apr 17 2018

mpyne committed R365:91e87577e9ee: mojo: Add some color to the CUI when failures happen. (authored by mpyne).

mojo: Add some color to the CUI when failures happen.

Apr 17 2018, 2:24 AM

mpyne committed R365:9f5994baff4a: mojo: Fix CUI min module name calculation and accept phase progress. (authored by mpyne).

mojo: Fix CUI min module name calculation and accept phase progress.

Apr 17 2018, 2:24 AM

Apr 15 2018

mpyne committed R365:0d9fd543ca60: mojo: Forward build progress to status viewer. (authored by mpyne).

mojo: Forward build progress to status viewer.

Apr 15 2018, 10:04 PM

mpyne committed R365:214add2cb568: GIT_SILENT Bump version to celebrate KDE Applications 18.04. (authored by mpyne).

GIT_SILENT Bump version to celebrate KDE Applications 18.04.

Apr 15 2018, 8:33 PM

mpyne committed R365:081817f9bb99: mojo: Give CUI status viewer a progress bar on wide-enough TTYs. (authored by mpyne).

mojo: Give CUI status viewer a progress bar on wide-enough TTYs.

Apr 15 2018, 8:27 PM

mpyne committed R365:4d8fc89e8ed6: mojo: Add status events for when a phase starts. (authored by mpyne).

mojo: Add status events for when a phase starts.

Apr 15 2018, 8:27 PM

mpyne committed R365:142fd1d45d81: Merge remote-tracking branch 'origin/master' into make_it_mojo (authored by mpyne).

Merge remote-tracking branch 'origin/master' into make_it_mojo

Apr 15 2018, 4:05 AM

mpyne committed R365:698cc6d37663: qmake: Fix order-dependency of *.pro glob search. (authored by mpyne).

qmake: Fix order-dependency of *.pro glob search.

Apr 15 2018, 4:00 AM

mpyne committed R365:1d2cba75a057: mojo: Try to hyperlink error log files if errors happen. (authored by mpyne).

mojo: Try to hyperlink error log files if errors happen.

Apr 15 2018, 12:28 AM

mpyne committed R365:de06dab43446: mojo: Apply module option changes that happen in a subprocess. (authored by mpyne).

mojo: Apply module option changes that happen in a subprocess.

Apr 15 2018, 12:28 AM

mpyne committed R365:f9a62918dfe1: mojo: First attempt at forwarding debug msgs to status viewer. (authored by mpyne).

mojo: First attempt at forwarding debug msgs to status viewer.

Apr 15 2018, 12:28 AM

Apr 14 2018

mpyne committed R365:c3d82f75916e: mojo: Add --launch-browser cmdline option. (authored by mpyne).

mojo: Add --launch-browser cmdline option.

Apr 14 2018, 4:44 AM

mpyne committed R365:763a67dd060a: mojo: Improve Web page output. (authored by mpyne).

mojo: Improve Web page output.

Apr 14 2018, 4:44 AM

mpyne committed R365:41816448c5a0: mojo: Have the HTML status dynamically update the build status. (authored by mpyne).

mojo: Have the HTML status dynamically update the build status.

Apr 14 2018, 4:44 AM

mpyne committed R365:7e9dfd624fd3: mojo: Add an HTML response for requests to status server base URL. (authored by mpyne).

mojo: Add an HTML response for requests to status server base URL.

Apr 14 2018, 4:44 AM

mpyne committed R365:74c6ce136451: mojo: Return HTTP errors for invalid resources. (authored by mpyne).

mojo: Return HTTP errors for invalid resources.

Apr 14 2018, 4:44 AM

Apr 13 2018

mpyne committed R365:728bbc4c07c7: mojo: Move the status monitor into build context. (authored by mpyne).

mojo: Move the status monitor into build context.

Apr 13 2018, 12:34 AM

mpyne committed R365:84ff7d84eb44: mojo: Remove now-dead code. (authored by mpyne).

mojo: Remove now-dead code.

Apr 13 2018, 12:34 AM

Apr 10 2018

mpyne committed R365:bb81b35eb36e: mojo: Fix status handler always showing success. (authored by mpyne).

mojo: Fix status handler always showing success.

Apr 10 2018, 1:50 AM

mpyne committed R365:6ad3c239d896: mojo: Remove redundant error handler. (authored by mpyne).

mojo: Remove redundant error handler.

Apr 10 2018, 1:50 AM

mpyne committed R365:ab5b75df0bab: mojo: Make build phase failures propagate to handle_async_build. (authored by mpyne).

mojo: Make build phase failures propagate to handle_async_build.

Apr 10 2018, 1:42 AM

mpyne committed R365:68b08d3451a5: mojo: buildSingleModule is now dead code, remove. (authored by mpyne).

mojo: buildSingleModule is now dead code, remove.

Apr 10 2018, 1:42 AM

mpyne committed R365:21900fe79968: mojo: Add more status events, don't quit until all events sent. (authored by mpyne).

mojo: Add more status events, don't quit until all events sent.

Apr 10 2018, 1:12 AM

Apr 9 2018

mpyne committed R365:df7d9e872e30: mojo: Add a websocket-driven event log and use for status info. (authored by mpyne).

mojo: Add a websocket-driven event log and use for status info.

Apr 9 2018, 4:34 AM

mpyne committed R365:26d66873a9de: mojo: Fix double counting errors when update phase fails. (authored by mpyne).

mojo: Fix double counting errors when update phase fails.

Apr 9 2018, 4:34 AM

mpyne committed R365:f71ea57f70b8: mojo: Make sure status server file is unlinked on abnormal exit. (authored by mpyne).

mojo: Make sure status server file is unlinked on abnormal exit.

Apr 9 2018, 4:34 AM

mpyne committed R365:05f41a60fece: mojo: Use daemon server instead of rolling our own. (authored by mpyne).

mojo: Use daemon server instead of rolling our own.

Apr 9 2018, 4:34 AM

mpyne committed R365:bc3941cc1416: mojo: Use HTTP instead of unix socket, add way to find right port. (authored by mpyne).

mojo: Use HTTP instead of unix socket, add way to find right port.

Apr 9 2018, 4:34 AM

Apr 8 2018

mpyne committed R297:88eda28b3567: Add platform detection and adjustment to kded (authored by graesslin).

Add platform detection and adjustment to kded

Apr 8 2018, 3:59 PM

mpyne closed D11583: Add platform detection and adjustment to kded.

Apr 8 2018, 3:59 PM · Frameworks

Apr 4 2018

mpyne committed R365:9d09e4787898: git: Ensure we skip modules that we say we must skip. (authored by mpyne).

git: Ensure we skip modules that we say we must skip.

Apr 4 2018, 3:47 AM

Mar 31 2018

mpyne committed R365:59b5cf41d535: mojo: Complete promise-ifying Module.pm's build subroutine. (authored by mpyne).

mojo: Complete promise-ifying Module.pm's build subroutine.

Mar 31 2018, 8:20 PM

mpyne committed R365:cd445618c356: mojo: Break module install into a separate phase. (authored by mpyne).

mojo: Break module install into a separate phase.

Mar 31 2018, 8:20 PM

mpyne committed R365:5c5b16d17f49: mojo: Add a helper for Mojo subprocesses for common code. (authored by mpyne).

mojo: Add a helper for Mojo subprocesses for common code.

Mar 31 2018, 8:20 PM

mpyne committed R365:323f6caab70a: mojo: Make the Module build routine return a promise. (authored by mpyne).

mojo: Make the Module build routine return a promise.

Mar 31 2018, 8:20 PM

Mar 28 2018

mpyne accepted D11736: Pass qtdir variable to cmake cmdline args.

I believe the official way to integrate a separate Qt is to ensure that the QTDIR's /bin directory is in the PATH.

Mar 28 2018, 12:59 AM

Mar 26 2018

mpyne committed R365:99a8b7408cbd: mojo: Re-add the status server. (authored by mpyne).

mojo: Re-add the status server.

Mar 26 2018, 4:15 AM

mpyne committed R365:a6f09a1221b4: mojo: Further refinement to major build loop. (authored by mpyne).

mojo: Further refinement to major build loop.

Mar 26 2018, 2:43 AM

mpyne committed R365:c04d7d2e23ac: mojo: Handle modules whose updates were skipped. (authored by mpyne).

mojo: Handle modules whose updates were skipped.

Mar 26 2018, 2:43 AM

mpyne committed R365:0905eb72838b: mojo: Show a message if build fails while waiting for updates. (authored by mpyne).

mojo: Show a message if build fails while waiting for updates.

Mar 26 2018, 2:43 AM

mpyne committed R365:6ba09e40ef29: mojo: Ensure update handler always returns a Promise. (authored by mpyne).

mojo: Ensure update handler always returns a Promise.

Mar 26 2018, 2:43 AM

mpyne committed R365:07669b4b03fe: mojo: Consistently use promises/continuation-passing. (authored by mpyne).

mojo: Consistently use promises/continuation-passing.

Mar 26 2018, 2:43 AM

mpyne committed R365:9bc8b289c79a: mojo: Fix handling of update successes. (authored by mpyne).

mojo: Fix handling of update successes.

Mar 26 2018, 2:43 AM

mpyne committed R365:9bfdb02e5f1a: mojo: Fix ordering of build. (authored by mpyne).

mojo: Fix ordering of build.

Mar 26 2018, 2:43 AM

Mar 25 2018

mpyne committed R344:30cd501f866d: systray: Ensure quit from systray also saves config changes. (authored by mpyne).

systray: Ensure quit from systray also saves config changes.

Mar 25 2018, 8:26 PM

mpyne committed R344:a951caf3e9dd: Simplify shutdown handling. (authored by mpyne).

Simplify shutdown handling.

Mar 25 2018, 7:46 PM

mpyne committed R344:1eed47304c46: Don't try to start in docked mode without the systray. (authored by mpyne).

Don't try to start in docked mode without the systray.

Mar 25 2018, 7:46 PM

mpyne committed R365:c9a364c33b96: git: Don't use refs/tags/ on initial clone, part 3. (authored by mpyne).

git: Don't use refs/tags/ on initial clone, part 3.

Mar 25 2018, 5:44 PM

mpyne committed R365:d755448a6870: git: Don't use refs/tags/ on initial clone, part 2. (authored by mpyne).

git: Don't use refs/tags/ on initial clone, part 2.

Mar 25 2018, 5:33 PM

mpyne committed R365:2d3b152cf7b6: git: Don't overspecify tags on initial clone. (authored by mpyne).

git: Don't overspecify tags on initial clone.

Mar 25 2018, 5:26 PM

Mar 22 2018

mpyne committed R365:8c0f0682bd13: mojo: Get to a basic effort which seems to survive --pretend. (authored by mpyne).

mojo: Get to a basic effort which seems to survive --pretend.

Mar 22 2018, 4:05 AM

mpyne committed R365:f340a529d091: async: Simplify async code path by requiring its use. (authored by mpyne).

async: Simplify async code path by requiring its use.

Mar 22 2018, 4:05 AM

Mar 18 2018

mpyne committed R856:ac8c98472bae: cmake: Fix spelling for Chrome manifest feature desc. (authored by mpyne).

cmake: Fix spelling for Chrome manifest feature desc.

Mar 18 2018, 7:18 PM

Mar 17 2018

mpyne accepted D11419: Fix build with Qt 5.11 (missing QHeaderView).

Mar 17 2018, 9:44 PM

Mar 15 2018

mpyne added a comment to D11290: [UDevManager] Already filter for subsystem before querying.

I never had the bug myself, I just grepped through the attached log to see if it made sense or not. :) I'll close the bug for now, if it doesn't fix the issue then it'll just get reopened.

Mar 15 2018, 1:07 AM · Frameworks