Differential D11583

Add platform detection and adjustment to kded
ClosedPublic
Actions

Authored by graesslin on Mar 22 2018, 6:29 PM.

Details

Reviewers
apol
romangg
Group Reviewers
Frameworks
Plasma
Commits
R297:88eda28b3567: Add platform detection and adjustment to kded
Summary

Current Plasma/master branch does no longer set the QT_QPA_PLATFORM env
variable on Wayland. As kded is a process tightly connected to the
workspace it also needs to pick wayland QPA in a Wayland session. This
change brings in the adjustment from plasma-workspace and ensures that
kded works correctly on any Wayland desktop environment, being it
Plasma, GNOME or Weston.

Test Plan

Restarted session, kscreen got layout correctly

Diff Detail

Repository
R297 KDED
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Mar 22 2018, 6:29 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 22 2018, 6:29 PM
graesslin requested review of this revision.Mar 22 2018, 6:29 PM
romangg accepted this revision.Mar 23 2018, 5:41 PM
This revision is now accepted and ready to land.Mar 23 2018, 5:41 PM
apol accepted this revision.Apr 6 2018, 6:07 PM

I wonder if all this code should be ifdef'd for Qt 5.10 though. The premise is that this won't be a problem with Qt 5.11, right?

graesslin added a comment.Apr 7 2018, 5:45 AM
In D11583#241314, @apol wrote:

I wonder if all this code should be ifdef'd for Qt 5.10 though. The premise is that this won't be a problem with Qt 5.11, right?

Let's wait for it to happen, then we can still ifdef

graesslin added a comment.Apr 7 2018, 5:45 AM

Btw could someone please push for me. I'm not around the next two weeks

Closed by commit R297:88eda28b3567: Add platform detection and adjustment to kded (authored by graesslin, committed by mpyne). · Explain WhyApr 8 2018, 3:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kded.cpp (32 lines)

Diff 31687

View Options

src/kded.cpp

Loading...