| mpyne |
| Frameworks |
Keep the enum intact by emitting the class keyword in case the enum is
scoped.
Use the complete enum scope for parameter values, the enclosing scope is
only correct to use for unscoped enums.
The python Cursor.is_scoped_enum() method has been added with LLVM/Clang
version 5.0.
BUG: 397154
build kcoreaddons
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
LGTM but then I don't use the Python bindings. Have you already tried the kcoreaddons build to see if this makes it work where it had failed before?
Compilation succeeds again, and the generated code looks sane. I have not actually tested it, though.
This raises the minimum requirement to LLVM 5.0:
http://releases.llvm.org/5.0.0/tools/clang/docs/ReleaseNotes.html
LLVM 5.0 was released 2017-09-07:
http://lists.llvm.org/pipermail/llvm-announce/2017-September/000075.html
As long as older versions of LLVM result in the Python binding generation step being skipped completely (we already check for libclang in the find-package for this, right?), I don't think the dependency increase is a problem.