As we moved away from phabricator (to gitlab) for code reviews, this is no more relevant.

KDE already hosts our own instance, so in that regard we are already protected from the shutdown of Phacility.

Hi David,
I did not plan to get you involved in this discussion because I guessed you wouldn't have done it on-purpose, that's why I have opened a bug on Phabrikator. My point of view is that tools are meant to make life easier (like what GIT does), not bring extra layers of complexity, problems and extra work (hence the tone in the report less diplomatic that what I usually try to do, I think it was the straw that broke the camel's back).

I did use arc patch Dxxx to get the commit, but I didn't notice the ownership was wrong. This happens if you manually upload the patch to website instead of using arc utility. Yes, it's a stupid feature of phabricator, and I forgot about it unfortunately. Sorry.

Hello,
Yes, I confirm the first contribution was actually right. But I have just looked at it and saw that @drosca *had* to ask me a contributor name, which it seems he forgot in 2nd contrib.
Why can't Phab use the info from the GIT patch ? It already has everything (Subject, Summary, Author, ...).
What is the need to make project owner's life harder? Isn't Phab supposed to help?

In fact in the first diff you linked you are set correctly as the author in the commit but not the second one.

That's probably because @drosca committed those for you and didn't set you as the author.

In T5437#207118, @ognarb wrote:

@ahmadsamir In PHP always use === and !== instead of == and !=

@ahmadsamir In PHP always use === and !== instead of == and !=

Thanks for fixing it.

"$@" contains all arguments including "diff", so the function didn't work for me. My fixed version:

Yeah, better arc land than breaking something (until the next time it gets on my nerves and I try to hack the arcanist source code, I know next to nothing about PHP... :)).

arc land verifies that the patch has actually been approved (this saved me from landing the wrong commits a few times), it also deletes the local feature branch. But well, it can also push to the wrong branch :-)

Revisiting an old issue :)

Sorry for the delay in responding to this - it had fallen into a crack and was missed :(

In T5242#156513, @filipesaraiva wrote:

I had this same problem recently - land a commit from a different user but the authorsihp was changed. I reverted the commit. :(

I had this same problem recently - land a commit from a different user but the authorsihp was changed. I reverted the commit. :(

For the sake of the next person getting here through the frustrated-online-search tunnel (like I just did a few hours ago, after the untracked files conundrum hit me about 50 times), here's a simple bash function that I came up with to use --allow-untracked with arc diff (there are probably more elegant ways to do this, but this WFM, so):

The jokes always make me smile, but new contributor friendliness comes first. +1.

Personally I am very much in favour, even to tech-savy people who had to deal with systems like the Atlassian Stack (Jira, BitBucket etc.), Redmine and GitLab, Phab can sometimes be very confusing and it's not entirely sure if a button will do what you expect it to.
I also assume that for people who don't feel terribly comfortable with English yet, it might make it even harder.

Due to the flood of notifications and the enormous amount of excess mail that subscribing projects instead of mailing lists generates, it's been decided to just subscribe mailing lists.
Projects will still be added to reviews so people can filter within Phabricator.

Sorry, I haven't had time to look into this i'm afraid.

@Ben: you added this patch ?

As an FYI, it looks like there will be movement shortly around rendering in general across the whole of Phabricator for Markdown/Remarkup syntax.
Please see https://secure.phabricator.com/T13105

In T7711#124543, @habacker wrote:

If you could confirm updating the remaining commit messages works,

I will this on the next review update

I verified that this is working with an update for D10310

Arcanist is responsible for submitting the changes meaning the control is entirely client side and the server has no input.
Best we could do is patch Arcanist and provide a patched version for people to use with the changes we need made, or alternatively use the other Arcanist client written by a third party which i've seen mentioned elsewhere.

In T7711#124542, @bcooksley wrote:

Okay. Given that upstream has in the past rejected other default behaviour change requests

Phabricator does not have site wide property settings to allow sites having different default behavior ?

Okay. Given that upstream has in the past rejected other default behaviour change requests - and the current behaviour appears to very much be deliberate, i'm not sure if we should ask them about this.

Did that with https://phabricator.kde.org/D9831 and review title has been updated. Updating remaining commit messages not tested yet.

Thanks for this pointer - I'm going to try this.

If you could upload it here that would be great.

In T5242#122935, @habacker wrote:

I added author metadata to a local:commits property to $diff at the end of DifferentialCreateRawDiffConduitAPIMethod::execute() and saw that author meta data in querydiffs api method.

@bcooksley: I have a quick and dirty patch for this - where should I post it to ?

Ralf, have you got a patch which can be discussed with the Phabricator developers, or is this something I need to be looking into?