As default the cursor position is set to the day part of the date field.
CCBUG:374123
BUG:389631
FIXED-IN:4.8.2
Details
Details
- Reviewers
tbaumgart - Group Reviewers
KMyMoney - Commits
- R261:904775b2005c: Allow the user to select the initial date cursor position in the settings dialog
compiled and tested on linux
Diff Detail
Diff Detail
- Repository
- R261 KMyMoney
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
This change will not be cherry-pickable after https://phabricator.kde.org/D10161 landed on master/5.0.
| kmymoney/dialogs/settings/ksettingsregisterdecl.ui | ||
|---|---|---|
| 245 | What is the reason to add the native="true" attribute here and for the other TransactionSortOption objects? Are there any potential side effects? | |
Comment Actions
- moved KMyMoneySettings fix into separate review D10322
- fixed refactoring of related ui file by Qt designer
Comment Actions
Thanks for this info, separated patch
| kmymoney/dialogs/settings/ksettingsregisterdecl.ui | ||
|---|---|---|
| 245 | This has been added by Qt Designer - I'm going to update the ui file with only the required changes. | |
| kmymoney/dialogs/settings/ksettingsregisterdecl.ui | ||
|---|---|---|
| 245 | It's what I thought would have caused it. Thanks for clarification. | |
| 288 | I think 'Initial cursor position within the date field' is better. | |
| kmymoney/settings/kmymoney.kcfg | ||
| 327 | I think 'Initial cursor position within the date field' is better. | |
| kmymoney/widgets/kmymoneydateinput.cpp | ||
| 181 | Please use enums here instead of magic numbers. They could be added to the kmymoneydateinput class/namespace | |
Comment Actions
- fixed title wording
- use enums for config variable values
- use more descriptive name for the related config variable
| kmymoney/widgets/kmymoneydateinput.cpp | ||
|---|---|---|
| 181 | Even better the enums are provided type safe by class KMyMoneySettings | |