Great! You can Abandon this revision from the Add Action... menu above the comment field if you'd like (you can always re-open it later if need be).
result: Git Stashes is visually grouped with Branches... and is not clickable
Wed, Aug 14
I will look into it next week. The used icon is bogus. I was hoping for some input on that :) But i liked the idea of an icon in general.
Mon, Aug 12
Maybe it would make sense to move the whole dialog into git plugin's code.
Sun, Aug 11
Hi, thank you, I'm happy to be back!
@pavelp Hi from a more recent contributor to KDevelop, good to see you back again once more and care for your former work :)
Fri, Aug 9
Tue, Aug 6
I created some screenshots. Icon ist in the line edit (near the mouse pointer in the first picture).
I hope it is ok to add you as reviewer directly as you orchestrated the last commit from me in this area.
Fri, Aug 2
Wed, Jul 31
Fri, Jul 26
I have been mega busy for the last while and intend to contribute more to this project when my situation stabilizes in like two weeks. Whenever you have time, I would definitely be interested to hear what sort of challenges you have come across through experimentation. An issue which I have suspected from the onset is actually determining all that needs to be protected by DUChain's lock and those which don't since KDevelop source makes use of these locks so liberally. I'm wondering if in your experimentation there are open questions about the DUChain locking scope.
Thu, Jul 25
Work-around pushed as 8a18a08cf17c85000c7082d5192855430a519bab , seems to pass build also with neon ci and the gcc 7.4.0 there.
Wed, Jul 24
Seems the introduced QStringLiteral as default argument here in the template method executeCompletionTest() makes ubuntu bionic's GNU 7.4.0 C++ compiler screw up. At least there is some timely coincidence that the KDevelop builds on neon CI started to fail after this commit, with this error:
05:00:37 [100%] Building CXX object plugins/clang/tests/CMakeFiles/test_codecompletion.dir/test_codecompletion.cpp.o 05:00:37 plugins/clang/tests/CMakeFiles/test_codecompletion.dir/build.make:62: recipe for target 'plugins/clang/tests/CMakeFiles/test_codecompletion.dir/test_codecompletion.cpp.o' failed 05:00:37 make: Leaving directory '/workspace/build/obj-x86_64-linux-gnu' 05:00:37 /tmp/ccrWtnBp.s: Assembler messages: 05:00:37 /tmp/ccrWtnBp.s:65174: Error: symbol `_ZZNK12_GLOBAL__N_1UlvE_clEvE15qstring_literal' is already defined 05:00:37 /tmp/ccrWtnBp.s:68144: Error: symbol `_ZZNK12_GLOBAL__N_1UlvE_clEvE15qstring_literal' is already defined 05:00:37 make: *** [plugins/clang/tests/CMakeFiles/test_codecompletion.dir/test_codecompletion.cpp.o] Error 1 05:00:37 CMakeFiles/Makefile2:18121: recipe for target 'plugins/clang/tests/CMakeFiles/test_codecompletion.dir/all' failed 05:00:37 make: *** [plugins/clang/tests/CMakeFiles/test_codecompletion.dir/all] Error 2
Mon, Jul 22
Sun, Jul 21
Sat, Jul 20
Overall I think this is a good idea, although we need to figure out some details. Could you either remove commented out flags or add a comment why we have them (commented out)?
I don't know what would be required to support multiple DUChains, but it seems plausible that they can be locked separately. In this case it would help to have the explicit argument, I guess. It could even be inevitable, when there is no single global DUChain anymore.
Can we have a test for this?
There is another condition here: `if (lastShownMenu)`. So if the QMenu object instance got deleted
Fri, Jul 19
Add rtti flags since they affect defines.
Prefer not duplicating code.
Just do the simple thing. Copied the one line of code due to
the awkwardness of preprocessor directives inside template lists.
As the person who raised the Debian Stretch issue last time, I don't think it's worth caring about now that Buster is released.
Sorry for my conservative thinking again: Debian Buster (10) is still /very/ fresh; it was just released a couple days ago. The former "oldest" supported distro was Debian Stretch (9) with Qt 5.7 and KF 5.28. That'll stick around for some time.
(Using phabricator to make sure people are triggered for this central change)
Jul 18 2019
I'll activate the debug trace on change of my lastShownMenu though
In any case there isn't much else you can do; stepping through the code with a debugger is near impossible (the menu about-to-be-opened will already have grabbed mouse and keyboard focus so you'd need to display remotely).