Is there something wrong with the second diff ?
Thu, Dec 5
Sun, Dec 1
Sat, Nov 30
Thu, Nov 28
Mon, Nov 25
Looks good to me :)
Sat, Nov 23
Can someone else land the patch? I don’t think I have the required permissions.
Sun, Nov 17
Sat, Nov 16
Good enough as for me.
Nov 8 2019
@starbuck Thanks. Tried a first link with https://store.kde.org/p/1334948 and adapted the KNSRC file of KDevelop, worked as wanted.
(well, once I added a workaround for some strange KNewStuff behaviour on archive extraction, cmp. 39a8a51d33 ;) )
Nov 7 2019
I added the new category now here:
Thanks for the reply, sounds good.
Nov 6 2019
We certainly can add a new category = API Documentation QCH Files.
Linking files are possible via "Add url", simply pointing to a file as endpoint.
I'm not sure what needs to be done client-side, so Dan can likely help there.
I just need to know what the category name should be and when to add it.
Oct 29 2019
Move variadics from IndexedContainer to ArrayType
Oct 27 2019
I agree that conceptually this should be moved to (or supplemented by) the actual language plugins, but also agree that this might be out of scope for this change.
As far as the PHP changes are concerned this is fine with me. However, I'd prefer those patterns to be unit tested and not just documented in comments.
Could you have a look at adding those tests?
Conceptually, this looks fine. However, like this we end up with two different descriptions of "Array of" types in the navigation popups.
While this shows integer arrays as int, for variadics it will show array of (int). I think at the very least both should be displayed the same.
Oct 24 2019
Oct 21 2019
Rebased for the 5.4 branch. Still working perfectly for me, without noticeably slower reaction times on local filesystems.
Rebased for the 5.4 branch.
Oct 10 2019
I'm not suggesting to not create a preamble at all, but to create it only when we **know** it is needed.
Oct 9 2019
I've just stumbled into a case where I would need -stdlib=libc++, which this change would solve.
I still think this is the right change, but if there is no consensus I will implement @mwolff's suggestion. That would certainly be an improvement, but it doesn't really solve my problem. I'm currently working on Clang and have around 6 files open, which is really not a lot. I haven't changed any of them. The result:
Oct 7 2019
hey! can you also show a screenshot of PHP or Qt documentation showing? these can contain arbitrary HTML and sometimes even contain colored text that expects to be shown on bright backgrounds which would break with this patch. At least that was the case years ago when I worked on this the last time.
Oct 6 2019
Would it be possible and interesting to reuse code highlighting for the code quote ?
Oct 5 2019
With the patch :
Oct 1 2019
Sep 26 2019
Sep 24 2019
Sep 22 2019
Sep 20 2019
thanks, applied to 5.4