KDevelopProject
ActivePublic

Recent Activity

Today

mwolff accepted D21156: Fix browse mode not disabled after Ctrl is released.

lgtm, thanks - do you have commit rights? if so, please push to the 5.3 branch

Tue, Jun 25, 11:22 AM · Documentation, KDevelop

Yesterday

santilin updated the diff for D22062: Addition of php script output patterns. Initial development..

ScriptErrorFilteringStrategyFix: all the items where set as InformativeItem even when there were no matches

Mon, Jun 24, 4:50 AM · KDevelop
santilin added a comment to D22062: Addition of php script output patterns. Initial development..

This patch adds some patterns to ScriptErrorFilterStrategy to handle some PHP errors so that you can click on the message and the matching file is opened.

Mon, Jun 24, 4:48 AM · KDevelop
santilin requested review of D22062: Addition of php script output patterns. Initial development..
Mon, Jun 24, 4:31 AM · KDevelop

Thu, Jun 20

apol accepted D21936: Pass the android toolchain file path to CMake as a local file path not as a URI.
Thu, Jun 20, 5:36 PM · KDevelop
bstresing requested review of D21936: Pass the android toolchain file path to CMake as a local file path not as a URI.
Thu, Jun 20, 4:26 PM · KDevelop
simgunz updated the diff for D21156: Fix browse mode not disabled after Ctrl is released.
  • Document feature
Thu, Jun 20, 8:06 AM · Documentation, KDevelop
simgunz updated the diff for D21156: Fix browse mode not disabled after Ctrl is released.

I reverted the commit were the Ctrl feature was disabled, going back to the first fix I proposed

Thu, Jun 20, 7:50 AM · Documentation, KDevelop

Tue, Jun 18

mwolff added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

R32:bd048e67f056b5be25ed57fb2be947444f68c24e

so, I've now committed an alternative fix (or so I hope...) see:

commit bd048e67f056b5be25ed57fb2be947444f68c24e
Author: Milian Wolff <mail@milianw.de>
Date:   Mon Jun 17 22:26:32 2019 +0200

    Guard against crashes when IStatus object gets destroyed at bad times

I confirm this fixes the issue for me. Yay, thanks!

Tue, Jun 18, 9:11 AM · KDevelop
arrowd added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

so, I've now committed an alternative fix (or so I hope...) see:

commit bd048e67f056b5be25ed57fb2be947444f68c24e
Author: Milian Wolff <mail@milianw.de>
Date:   Mon Jun 17 22:26:32 2019 +0200

    Guard against crashes when IStatus object gets destroyed at bad times
Tue, Jun 18, 8:48 AM · KDevelop

Mon, Jun 17

mwolff added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

having looked at the raw diff quickly, I like what I'm seeing. What boilerplate are you referring to?

Mon, Jun 17, 8:40 PM · KDevelop
mwolff added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

so, I've now committed an alternative fix (or so I hope...) see:

Mon, Jun 17, 8:32 PM · KDevelop
mwolff added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

ok, sorry for the rabbit hole I sent you down. I still think that long-term we will need something like QPromise, but phabricator doesn't even let me view the interesting changes in shell/... so I cannot comment on the boilerplate

Mon, Jun 17, 8:14 PM · KDevelop
mwolff added a comment to D21156: Fix browse mode not disabled after Ctrl is released.

you are removing a feature, but only partially - a lot of code would become superfluous by this change and should be cleaned up accordingly

As rjvbb said, no feature have been removed. The feature is still there through the Alt key (as it was before), while not accessible anymore with the Ctrl key. There is no reason to have the same (undocumented) feature on two different keys. Moreover there is no code to cleanup, what is there is needed to have the feature working on the Alt key (at least for my understanding of the code, I have not noticed unuseful blocks).

Mon, Jun 17, 7:27 PM · Documentation, KDevelop
davidre added a comment to D21580: Grepview - Introduce a new intermediate level corresponding to lines.

This sadly seems to have broken navigating with the "Next item"/"Previous item" actions for me. Please give this a look.

Mon, Jun 17, 2:59 PM · KDevelop
kossebau added a comment to D21580: Grepview - Introduce a new intermediate level corresponding to lines.

This sadly seems to have broken navigating with the "Next item"/"Previous item" actions for me. Please give this a look.

Mon, Jun 17, 2:11 PM · KDevelop

Sat, Jun 15

fbampaloukas removed a member for KDevelop: fbampaloukas.
Sat, Jun 15, 9:22 PM
fbampaloukas removed a watcher for KDevelop: fbampaloukas.
Sat, Jun 15, 9:22 PM
fbampaloukas added a member for KDevelop: fbampaloukas.
Sat, Jun 15, 9:22 PM
fbampaloukas added a watcher for KDevelop: fbampaloukas.
Sat, Jun 15, 9:22 PM

Fri, Jun 14

hmitonneau added a watcher for KDevelop: hmitonneau.
Fri, Jun 14, 10:27 AM

Wed, Jun 12

davidre closed D21580: Grepview - Introduce a new intermediate level corresponding to lines.
Wed, Jun 12, 2:53 PM · KDevelop
apol accepted D21580: Grepview - Introduce a new intermediate level corresponding to lines.
Wed, Jun 12, 2:07 PM · KDevelop
davidre added a comment to D21580: Grepview - Introduce a new intermediate level corresponding to lines.

ping

Wed, Jun 12, 1:13 PM · KDevelop

Mon, Jun 10

sredman added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

brauch is referring to this

for /f "usebackq tokens=3*" %%a in (`reg query "HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7" /s`) do (
     set vs15_path=%%a %%b
     if exist "!vs15_path!Common7\Tools\VsDevCmd.bat" (
	set "VS150COMNTOOLS=!vs15_path!Common7\Tools\"
	goto :end
     )
   )
)
:end

Oops. What happened here is I was hacking on the release version which looks more like the patch I posted. I'll see if I can make sense of the master branch version and make it more like that!

Mon, Jun 10, 6:50 PM · KDevelop
Petross404 added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

brauch is referring to this

Mon, Jun 10, 6:39 PM · KDevelop
sredman added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

Why did you replace the registry query by a fixed path?

Mon, Jun 10, 6:29 PM · KDevelop
Petross404 added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.
echo Define which compiler for VS2017 to use. Possible architectures are:
Mon, Jun 10, 6:22 PM · KDevelop
brauch added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

Why did you replace the registry query by a fixed path?

Mon, Jun 10, 5:19 PM · KDevelop
apol updated subscribers of D21589: Duplicate Visual Studio 2017 hack for VS 2019.

LGTM, maybe @kfunk or @brauch know more?

Mon, Jun 10, 11:44 AM · KDevelop

Tue, Jun 4

sredman added a reviewer for D21589: Duplicate Visual Studio 2017 hack for VS 2019: KDevelop.
Tue, Jun 4, 9:27 PM · KDevelop
sredman requested review of D21589: Duplicate Visual Studio 2017 hack for VS 2019.
Tue, Jun 4, 9:26 PM · KDevelop
davidre updated the diff for D21580: Grepview - Introduce a new intermediate level corresponding to lines.

Missing idx_line

Tue, Jun 4, 3:07 PM · KDevelop
davidre updated the test plan for D21580: Grepview - Introduce a new intermediate level corresponding to lines.
Tue, Jun 4, 3:02 PM · KDevelop
davidre requested review of D21580: Grepview - Introduce a new intermediate level corresponding to lines.
Tue, Jun 4, 3:01 PM · KDevelop

Wed, May 29

kfunk closed D21458: clang: fix test bench_codecompletion compilation.
Wed, May 29, 8:52 AM · KDevelop
mwolff accepted D21458: clang: fix test bench_codecompletion compilation.

lgtm

Wed, May 29, 8:00 AM · KDevelop

Tue, May 28

hmitonneau requested review of D21458: clang: fix test bench_codecompletion compilation.
Tue, May 28, 11:34 AM · KDevelop
arrowd added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..
In D18758#469623, @apol wrote:

Quite possibly, it doesn't happen outside of tests after all, right?

Tue, May 28, 8:22 AM · KDevelop

Mon, May 27

kfunk closed D17760: astyle: support the system astyle library.
Mon, May 27, 6:43 AM · KDevelop
kfunk accepted D17760: astyle: support the system astyle library.

Works fine for me on Ubuntu 19.04 -- lgtm!

Mon, May 27, 6:36 AM · KDevelop

May 25 2019

apol accepted D17760: astyle: support the system astyle library.
May 25 2019, 3:11 AM · KDevelop

May 24 2019

pino added a comment to D17760: astyle: support the system astyle library.

Ping?

May 24 2019, 8:03 PM · KDevelop
apol added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

Quite possibly, it doesn't happen outside of tests after all, right?

May 24 2019, 7:27 PM · KDevelop
arrowd added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

I'm more interested in fixing the intial issue. With KIO jobs in openProject turned async, the crash now happens right in qWait(1) of KDevelop::TestCore::shutdown(). And what's strange is that adding qWait(1) at the end of testReload() test still fixes issue.

May 24 2019, 4:14 PM · KDevelop

May 23 2019

apol added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

Can't we really fix this without bringing a dependency?
If we really want the dependency, can we just link against it instead of dragging it into our source code?

May 23 2019, 11:19 AM · KDevelop

May 21 2019

arrowd updated the diff for D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

Changes:

  • Import QtPromise 0.5.0 into kdevplatform/3dparty/ directory.
  • Remove synchronious KIO calls from Project::open() and use QPromises there instead.
May 21 2019, 10:12 AM · KDevelop

May 18 2019

simgunz added a comment to D21156: Fix browse mode not disabled after Ctrl is released.

you are removing a feature, but only partially - a lot of code would become superfluous by this change and should be cleaned up accordingly

May 18 2019, 10:25 AM · Documentation, KDevelop

May 16 2019

rjvbb added a comment to D21156: Fix browse mode not disabled after Ctrl is released.
you are removing a feature
May 16 2019, 12:32 AM · Documentation, KDevelop

May 15 2019

mwolff requested changes to D21156: Fix browse mode not disabled after Ctrl is released.

you are removing a feature, but only partially - a lot of code would become superfluous by this change and should be cleaned up accordingly

May 15 2019, 9:25 PM · Documentation, KDevelop