lgtm, thanks - do you have commit rights? if so, please push to the 5.3 branch
ScriptErrorFilteringStrategyFix: all the items where set as InformativeItem even when there were no matches
This patch adds some patterns to ScriptErrorFilterStrategy to handle some PHP errors so that you can click on the message and the matching file is opened.
Thu, Jun 20
- Document feature
I reverted the commit were the Ctrl feature was disabled, going back to the first fix I proposed
Tue, Jun 18
Mon, Jun 17
having looked at the raw diff quickly, I like what I'm seeing. What boilerplate are you referring to?
so, I've now committed an alternative fix (or so I hope...) see:
ok, sorry for the rabbit hole I sent you down. I still think that long-term we will need something like QPromise, but phabricator doesn't even let me view the interesting changes in shell/... so I cannot comment on the boilerplate
This sadly seems to have broken navigating with the "Next item"/"Previous item" actions for me. Please give this a look.
Sat, Jun 15
Fri, Jun 14
Wed, Jun 12
Mon, Jun 10
Oops. What happened here is I was hacking on the release version which looks more like the patch I posted. I'll see if I can make sense of the master branch version and make it more like that!
brauch is referring to this
echo Define which compiler for VS2017 to use. Possible architectures are:
Why did you replace the registry query by a fixed path?
Tue, Jun 4
Wed, May 29
Tue, May 28
Mon, May 27
Works fine for me on Ubuntu 19.04 -- lgtm!
May 25 2019
May 24 2019
Quite possibly, it doesn't happen outside of tests after all, right?
I'm more interested in fixing the intial issue. With KIO jobs in openProject turned async, the crash now happens right in qWait(1) of KDevelop::TestCore::shutdown(). And what's strange is that adding qWait(1) at the end of testReload() test still fixes issue.
May 23 2019
Can't we really fix this without bringing a dependency?
If we really want the dependency, can we just link against it instead of dragging it into our source code?
May 21 2019
- Import QtPromise 0.5.0 into kdevplatform/3dparty/ directory.
- Remove synchronious KIO calls from Project::open() and use QPromises there instead.
May 18 2019
May 16 2019
you are removing a feature
May 15 2019
you are removing a feature, but only partially - a lot of code would become superfluous by this change and should be cleaned up accordingly