KDevelopProject
ActivePublic

Recent Activity

Tue, Apr 16

mwolff accepted D18224: Clang Plugin: Report some problems from included files.

patch lgtm now, many thanks!

Tue, Apr 16, 1:36 PM · KDevelop
mwolff added a comment to D18224: Clang Plugin: Report some problems from included files.

Upon reopening a file, we should only update the problems of changed files that got updated. Otherwise we should only grab the TU for the main .cpp file and attach it, such that we can do code completion.

If I understand this correctly, then perhaps something does not behave as it should there, since in some cases, a lot of files' problems seem to get updated when re-opening a file, including lots of system headers that certainly haven't changed. In other cases, no calls to ParseSession::problemsForFile() are made. It seems that the first case can be triggered by making changes to a header, closing it without saving, and then re-opening it.

Tue, Apr 16, 1:34 PM · KDevelop

Mon, Apr 15

thomassc added a comment to D18224: Clang Plugin: Report some problems from included files.

Upon reopening a file, we should only update the problems of changed files that got updated. Otherwise we should only grab the TU for the main .cpp file and attach it, such that we can do code completion.

Mon, Apr 15, 10:59 PM · KDevelop
thomassc updated the diff for D18224: Clang Plugin: Report some problems from included files.

Re-add m_diagnosticsCache with a hopefully correct caching implementation. Differing from the original situation, the new function createExternalProblem() adapts the problems it creates to the specific file they are inserted in. The cache thus only caches the original problems as created by ClangDiagnosticEvaluator::createProblem(). createExternalProblem() makes copies of these with a new copy constructor added to ClangProblem.

Mon, Apr 15, 10:59 PM · KDevelop
mwolff added a comment to D18551: clang: Create preamble only on second parse.

quite obviously libclang doesn't handle it

Mon, Apr 15, 7:38 PM · KDevelop
rjvbb added a comment to D18551: clang: Create preamble only on second parse.
Do you mean something like `#include <Foo>` which then contains a `#include <foo.h>`?
Mon, Apr 15, 9:01 AM · KDevelop
mwolff added a comment to D18551: clang: Create preamble only on second parse.

Re: reparsing reliably each time a headerfile is changed: wouldn't the use of forwarding headers increase the chance of missing a change?

Mon, Apr 15, 8:25 AM · KDevelop
mwolff added a comment to D18224: Clang Plugin: Report some problems from included files.

I re-tested the behavior on files from an actual project and it showed the same behavior when editing files as described in my last post, regardless of how many files are included from the files that are edited. I noticed that the behavior is different when re-opening files: in this case, problemsForFile() is actually called for a larger set of files (although from only looking at this set of files, it seemed a bit random and it was not clear to me how it is determined, I'll have to dig into the source code for this at some point ...).

Mon, Apr 15, 8:17 AM · KDevelop
mwolff added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..
In D18758#450081, @apol wrote:

Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?

That would mean adding a bunch of noexcept all over the place or risk quite some performance penalty. I'd prefer keeping it localised.

Mon, Apr 15, 8:13 AM · KDevelop

Sun, Apr 14

apol added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?

Sun, Apr 14, 6:14 PM · KDevelop
tristanp requested review of D20548: Fix document switcher plugin with multiple splitted view..
Sun, Apr 14, 4:31 PM · KDevelop
thomassc added a comment to D18224: Clang Plugin: Report some problems from included files.

I am sorry, I think that I misunderstood how the cache works. Please disregard my previous message. I am wondering where the problem that I've been seeing then comes from, seems like it has a different origin.

Sun, Apr 14, 10:11 AM · KDevelop

Sat, Apr 13

thomassc added a comment to D18224: Clang Plugin: Report some problems from included files.

I re-tested the behavior on files from an actual project and it showed the same behavior when editing files as described in my last post, regardless of how many files are included from the files that are edited. I noticed that the behavior is different when re-opening files: in this case, problemsForFile() is actually called for a larger set of files (although from only looking at this set of files, it seemed a bit random and it was not clear to me how it is determined, I'll have to dig into the source code for this at some point ...).

Sat, Apr 13, 9:21 PM · KDevelop
thomassc closed D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.
Sat, Apr 13, 7:55 PM · KDevelop
arrowd added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?

Sat, Apr 13, 6:55 PM · KDevelop
gennad removed a watcher for KDevelop: gennad.
Sat, Apr 13, 6:18 PM
mwolff added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?

Sat, Apr 13, 4:51 PM · KDevelop
mwolff requested changes to D18224: Clang Plugin: Report some problems from included files.

Hey Thomas, please don't remove the cache. See f2a6941e086cdf506c8fb1798c52982bff43792d for why this was introduced. Your tests don't include other files, so probably that's why you didn't see any effect of the cache?

Sat, Apr 13, 4:49 PM · KDevelop
mwolff accepted D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

thanks, lgtm!

Sat, Apr 13, 4:41 PM · KDevelop

Tue, Apr 9

hein closed D20419: Fix build on Qt 5.13 branch.
Tue, Apr 9, 10:43 PM · KDevelop
apol accepted D20419: Fix build on Qt 5.13 branch.
Tue, Apr 9, 9:47 PM · KDevelop
hein requested review of D20419: Fix build on Qt 5.13 branch.
Tue, Apr 9, 9:38 PM · KDevelop
christiant added a comment to D20142: DVCS Branch Manager with filtering and sorting proposal.

Probably not - this is my first commit. Where do I need to apply :-D

Tue, Apr 9, 8:23 AM · KDevelop, VDG
apol accepted D20142: DVCS Branch Manager with filtering and sorting proposal.

Good stuff, do you have push rights?

Tue, Apr 9, 1:04 AM · KDevelop, VDG

Mon, Apr 8

christiant updated the diff for D20142: DVCS Branch Manager with filtering and sorting proposal.

Upload correct patch

Mon, Apr 8, 8:34 PM · KDevelop, VDG
christiant added a comment to D20142: DVCS Branch Manager with filtering and sorting proposal.

Yeah, you're right.

Mon, Apr 8, 12:19 PM · KDevelop, VDG
apol added a comment to D20142: DVCS Branch Manager with filtering and sorting proposal.

I think you uploaded the patch against the last version, not against master.

Mon, Apr 8, 12:04 AM · KDevelop, VDG

Sat, Apr 6

thomassc updated the diff for D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

Thanks for the info. I didn't spot it at first since it is hidden in a dropdown menu.

Sat, Apr 6, 2:58 PM · KDevelop
thomassc commandeered D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.
Sat, Apr 6, 2:56 PM · KDevelop
thomassc updated the diff for D18224: Clang Plugin: Report some problems from included files.

Address Milian's comments; remove m_diagnosticsCache.

Sat, Apr 6, 2:52 PM · KDevelop
thomassc added inline comments to D18224: Clang Plugin: Report some problems from included files.
Sat, Apr 6, 2:50 PM · KDevelop
arrowd added a comment to D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

@thomassc it is because I commandeered your revision to be able to update it. If you want, you do the same. First select "Commandeer Revision" at the bottom of this page, and then use arc diff (possibly with --update D18567) to update it.

Sat, Apr 6, 12:33 PM · KDevelop
thomassc added a comment to D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

Thanks for the update. Seems good to me.

Sat, Apr 6, 12:16 PM · KDevelop

Fri, Apr 5

christiant updated the diff for D20142: DVCS Branch Manager with filtering and sorting proposal.

Work through feedback:

Fri, Apr 5, 11:12 PM · KDevelop, VDG
arrowd updated the diff for D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

Simplify code.

Fri, Apr 5, 12:56 PM · KDevelop
arrowd commandeered D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.
Fri, Apr 5, 12:56 PM · KDevelop

Thu, Apr 4

arrowd added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

After finishing initial implementation I found out that QtPromise requires exceptions enabled. KDevelop seem to have exceptions disabled right now.

Thu, Apr 4, 6:36 PM · KDevelop

Tue, Apr 2

christiant added a comment to D20142: DVCS Branch Manager with filtering and sorting proposal.

I will do that.

Tue, Apr 2, 10:28 AM · KDevelop, VDG

Mon, Apr 1

kfunk added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

As long as it integrates well with the rest of the KDevelop build I'm fine. Would probably just copy the QtPromise source tree into maybe kdevelop.git:3rdparty/ and create a CMakeLists.txt which creates a STATIC or OBJECT library for it? QtPromise looks easy enough to build.

Mon, Apr 1, 5:44 PM · KDevelop
mwolff updated subscribers of D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

yes, QtPromise or AsyncFuture (https://github.com/benlau/asyncfuture) could be used - I wouldn't be opposed to introducing it as a thirdparty dependency (or git submodule)

Mon, Apr 1, 4:43 PM · KDevelop
arrowd added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

KAsync looks a bit unmaintained. On the other hand, QtPromise seems to be an active project. Should I start looking into the latter?

Mon, Apr 1, 12:06 PM · KDevelop
arrowd closed D14391: Fix random order of plugin's config pages.
Mon, Apr 1, 11:29 AM · KDevelop
mwolff added a comment to D14391: Fix random order of plugin's config pages.

if it applies cleanly, you can also push to 5.3, otherwise master is fine - it's not a really urgent bug fix after all (imo)

Mon, Apr 1, 11:02 AM · KDevelop
arrowd added a comment to D14391: Fix random order of plugin's config pages.

Onto master?

Mon, Apr 1, 10:58 AM · KDevelop
mwolff accepted D14391: Fix random order of plugin's config pages.
Mon, Apr 1, 10:46 AM · KDevelop
kfunk added inline comments to D20142: DVCS Branch Manager with filtering and sorting proposal.
Mon, Apr 1, 6:39 AM · KDevelop, VDG

Sun, Mar 31

apol added a comment to D20142: DVCS Branch Manager with filtering and sorting proposal.

Looks good to me overall, Let's clean it up so we can get it in.

Sun, Mar 31, 2:47 PM · KDevelop, VDG
christiant added a comment to D20142: DVCS Branch Manager with filtering and sorting proposal.

How it looks.

Sun, Mar 31, 11:02 AM · KDevelop, VDG
christiant requested review of D20142: DVCS Branch Manager with filtering and sorting proposal.
Sun, Mar 31, 10:20 AM · KDevelop, VDG

Fri, Mar 29

arrowd added a comment to D14391: Fix random order of plugin's config pages.

I don't remember details of this revision, but at least it seems to do like how we agreed.

Fri, Mar 29, 1:06 PM · KDevelop