igorkushnir (Igor Kushnir)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 22 2016, 5:18 PM (165 w, 1 d)
Availability
Available

Recent Activity

Jan 17 2019

igorkushnir requested review of D18325: Debugger plugin fixes.
Jan 17 2019, 5:04 PM · KDevelop

Aug 2 2017

igorkushnir added a comment to D7061: Improve search in documentation view: kate-look, hide on ESC, live search.

There is a similar simpler review request here: https://git.reviewboard.kde.org/r/126856/diff/3#index_header
It was already reviewed by Milian Wolff. Feel free to pick anything useful from the old review diff into this one.

Aug 2 2017, 7:46 AM

Mar 24 2017

igorkushnir updated the diff for D3041: Enable zoom feature in built-in documentation widgets.

Rebasing on master.

Mar 24 2017, 6:56 PM
igorkushnir updated the diff for D3040: Allow scaling documentation view (BUG 285162).

Rebasing on master.

Mar 24 2017, 6:54 PM

Mar 22 2017

igorkushnir added a comment to D5129: QtWebKit documentation regression fixes.

By the way, is building with QtWebKit supported if there are both QtWebKit and QtWebEngine installed? I had to change CMakeLits.txt to force-use QtWebKit:

-find_package(Qt5WebEngineWidgets)
-if(TARGET Qt5::WebEngineWidgets)
+#find_package(Qt5WebEngineWidgets)
+if(0)
Mar 22 2017, 3:35 PM
igorkushnir added a comment to D5129: QtWebKit documentation regression fixes.

Note that there are other recent regressions with both QtWebKit and QtWebEngine implementations.

Mar 22 2017, 3:32 PM
igorkushnir created D5129: QtWebKit documentation regression fixes.
Mar 22 2017, 3:22 PM
igorkushnir added a comment to D3040: Allow scaling documentation view (BUG 285162).

This branch is based on a very old KDevPlatform revision. There are conflicts when rebasing on master. Should I rebase on master and update this review request? Or maybe rebase on some other branch?

Mar 22 2017, 9:08 AM

Mar 19 2017

igorkushnir added inline comments to D3040: Allow scaling documentation view (BUG 285162).
Mar 19 2017, 4:38 PM
igorkushnir updated the diff for D3040: Allow scaling documentation view (BUG 285162).
  • Minor cleanup
Mar 19 2017, 4:33 PM

Mar 8 2017

igorkushnir updated the diff for D3040: Allow scaling documentation view (BUG 285162).
  • Replace qCWarningS with Q_ASSERTs
Mar 8 2017, 12:34 PM

Feb 25 2017

igorkushnir updated the diff for D3040: Allow scaling documentation view (BUG 285162).

Improve Ctrl+0 shortcut support, address review comments

Feb 25 2017, 10:02 AM

Feb 22 2017

igorkushnir added a comment to D3040: Allow scaling documentation view (BUG 285162).
In D3040#88407, @rjvbb wrote:

I guess that depends on the exact way you implement it, but I would assume that it should be possible to do it in such a way that the action applies only to the focussed widget. After all, the "Close" action doesn't close all widgets either, just the one that has focus.

Feb 22 2017, 7:56 AM

Feb 21 2017

igorkushnir added a comment to D3040: Allow scaling documentation view (BUG 285162).
In D3040#88399, @rjvbb wrote:

Wouldn't it be possible to define an application-wide "Reset Zoom" (or "Zoom 100%") action with a shortcut that can be configured via the usual mechanism? That way you wouldn't have to jump through hoops in your code, and the action would (ultimately) become available in the other contexts where it would be most welcome.

Feb 21 2017, 8:00 PM
igorkushnir added a comment to D3040: Allow scaling documentation view (BUG 285162).

I guess everyone is OK with Ctrl+0 working only when the documentation widget has focus. This widget actually gets focus on scrolling, even though individual windows on my system don't get focus in such cases. So this should not be a problem.

Feb 21 2017, 7:26 PM

Feb 19 2017

igorkushnir added inline comments to D3040: Allow scaling documentation view (BUG 285162).
Feb 19 2017, 2:11 PM
igorkushnir updated the diff for D3040: Allow scaling documentation view (BUG 285162).

Address review comments

Feb 19 2017, 2:10 PM

Oct 17 2016

igorkushnir added a comment to D3040: Allow scaling documentation view (BUG 285162).

ZoomController class serves two purposes:

  1. Separates generic scaling/zoom logic from the unrelated StandardDocumentationView logic. If I had placed zoom logic (complete with storing to KConfig) into StandardDocumentationView.cpp, it would occupy more than a half of that file!
  2. ZoomController class can be easily reused in another similar situation instead of duplicating generic scaling/storing logic.
Oct 17 2016, 5:15 PM

Oct 16 2016

igorkushnir updated the diff for D3041: Enable zoom feature in built-in documentation widgets.

Eliminate documentation zoom context menu actions

Oct 16 2016, 11:48 AM
igorkushnir updated the diff for D3040: Allow scaling documentation view (BUG 285162).

Eliminate documentation zoom context menu actions

Oct 16 2016, 11:47 AM

Oct 13 2016

igorkushnir added a comment to D3040: Allow scaling documentation view (BUG 285162).
In D3040#56430, @apol wrote:

Wouldn't it be better just to allow the documentation view to change size with ctrl+mouse wheel or ctrl+'+'?

I really don't see why we need all of this.

Oct 13 2016, 6:02 AM

Oct 12 2016

igorkushnir added a comment to D3040: Allow scaling documentation view (BUG 285162).

D2902 does not fix the original issue for me because I want larger font size for documentation, and my system default is too small.
Maybe it works well in Plasma, but not in XFCE and possibly some other environments.
Being able to increase/decrease documentation scale can be a useful feature in many use-cases.

Oct 12 2016, 6:59 PM
igorkushnir added a comment to D3040: Allow scaling documentation view (BUG 285162).

Screenshots:

Oct 12 2016, 6:51 PM
igorkushnir added a reviewer for D3041: Enable zoom feature in built-in documentation widgets: KDevelop.
Oct 12 2016, 6:43 PM
igorkushnir added a reviewer for D3040: Allow scaling documentation view (BUG 285162): KDevelop.
Oct 12 2016, 6:43 PM
igorkushnir added a comment to D3040: Allow scaling documentation view (BUG 285162).

I tried to allow configuring documentation zoom actions shortcuts:

Oct 12 2016, 6:42 PM
igorkushnir added a dependent revision for D3040: Allow scaling documentation view (BUG 285162): D3041: Enable zoom feature in built-in documentation widgets.
Oct 12 2016, 6:28 PM
igorkushnir retitled D3041: Enable zoom feature in built-in documentation widgets from to Enable zoom feature in built-in documentation widgets.
Oct 12 2016, 6:28 PM
igorkushnir retitled D3040: Allow scaling documentation view (BUG 285162) from to Allow scaling documentation view (BUG 285162).
Oct 12 2016, 6:23 PM