pprkut (Heinz Wiesinger)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 24 2017, 6:42 PM (141 w, 5 d)
Availability
Available

Recent Activity

Sun, Oct 27

pprkut committed R52:4c46f097425c: Add support for class constant visibility (authored by pprkut).
Add support for class constant visibility
Sun, Oct 27, 8:23 AM
pprkut added a comment to D22062: Addition of php script output patterns. Initial development..

I agree that conceptually this should be moved to (or supplemented by) the actual language plugins, but also agree that this might be out of scope for this change.
As far as the PHP changes are concerned this is fine with me. However, I'd prefer those patterns to be unit tested and not just documented in comments.
Could you have a look at adding those tests?

Sun, Oct 27, 7:54 AM · KDevelop
pprkut added a reviewer for D24921: [KDevelop/PHP] Add support for "array of type": pprkut.
Sun, Oct 27, 7:39 AM · KDevelop
pprkut added a comment to D24921: [KDevelop/PHP] Add support for "array of type".

Conceptually, this looks fine. However, like this we end up with two different descriptions of "Array of" types in the navigation popups.
While this shows integer arrays as int[], for variadics it will show array of (int). I think at the very least both should be displayed the same.

Sun, Oct 27, 7:39 AM · KDevelop
pprkut updated the task description for T6803: PHP 7.1 features.
Sun, Oct 27, 7:10 AM · KDevelop

Oct 7 2019

pprkut committed R52:cb71eff2153a: Fix expressions using array constants (authored by pprkut).
Fix expressions using array constants
Oct 7 2019, 11:05 AM
pprkut committed R52:df6070ff9991: Don't mark class constants as normal members (authored by pprkut).
Don't mark class constants as normal members
Oct 7 2019, 11:05 AM

Mar 18 2019

pprkut committed R52:2b4a2abcc233: Update phpfunctions.php to phpdoc revision 347011 (authored by pprkut).
Update phpfunctions.php to phpdoc revision 347011
Mar 18 2019, 7:03 PM
pprkut committed R52:fb4484a9b18c: Parse more function aliases (authored by pprkut).
Parse more function aliases
Mar 18 2019, 7:03 PM
pprkut committed R52:1004709844d0: More special handling for mcrypt constants (authored by pprkut).
More special handling for mcrypt constants
Mar 18 2019, 7:03 PM
pprkut committed R52:bbdaceac3287: Parse more constants (authored by pprkut).
Parse more constants
Mar 18 2019, 7:03 PM
pprkut committed R52:fed9a170e9b9: Parse more class constants (authored by pprkut).
Parse more class constants
Mar 18 2019, 7:03 PM
pprkut committed R52:a6b8d3a1e664: Parse more constants within tables (authored by pprkut).
Parse more constants within tables
Mar 18 2019, 7:03 PM
pprkut committed R52:c95326706c26: Parse constants under para (authored by pprkut).
Parse constants under para
Mar 18 2019, 7:03 PM
pprkut committed R52:cd5cc1375da3: Parse url stat constants (authored by pprkut).
Parse url stat constants
Mar 18 2019, 7:03 PM
pprkut committed R52:9a4fb516de9c: Parse file upload constants (authored by pprkut).
Parse file upload constants
Mar 18 2019, 7:03 PM
pprkut committed R52:34ede9006d6e: Parse php token constants (authored by pprkut).
Parse php token constants
Mar 18 2019, 7:03 PM
pprkut committed R52:1055217b856c: Parse constants under tables (authored by pprkut).
Parse constants under tables
Mar 18 2019, 7:03 PM
pprkut committed R52:35b50146169e: Parse nl-langinfo constants (authored by pprkut).
Parse nl-langinfo constants
Mar 18 2019, 7:03 PM
pprkut committed R52:709b95116e0d: Parse constants under section and within tables (authored by pprkut).
Parse constants under section and within tables
Mar 18 2019, 7:03 PM
pprkut committed R52:77fb3cad39de: Fix function declarations with varargs (authored by pprkut).
Fix function declarations with varargs
Mar 18 2019, 7:03 PM
pprkut committed R52:c031d1c43754: Parse constants split over multiple lists within one file (authored by pprkut).
Parse constants split over multiple lists within one file
Mar 18 2019, 7:03 PM

Jan 9 2019

pprkut added a comment to D18122: Fix Xdebug disconnecting after php finished if multiple connections are allowed.

I'm afraid I don't know much about this either :-/
The fact that the unit tests are currently completely broken doesn't help. I did try them with and without this change and what I *can* say is that it's neither worse nor better.

Jan 9 2019, 7:46 PM · KDevelop

Jan 5 2019

pprkut requested review of D17990: Update php syntax support.
Jan 5 2019, 3:55 PM · Frameworks, Kate

Nov 22 2018

pprkut committed R52:60dbbdf90ba3: Merge branch '5.3' (authored by pprkut).
Merge branch '5.3'
Nov 22 2018, 7:59 PM
pprkut committed R52:4e07839f5a97: Fix handling of array indexes after ClassNameReferences (authored by pprkut).
Fix handling of array indexes after ClassNameReferences
Nov 22 2018, 7:58 PM

Nov 17 2018

pprkut committed R52:2469eba750b2: Fix syntax support for dynamic member access. (authored by pprkut).
Fix syntax support for dynamic member access.
Nov 17 2018, 4:45 PM
pprkut closed D16461: Fix syntax support for dynamic member access..
Nov 17 2018, 4:45 PM · KDevelop

Oct 28 2018

pprkut added inline comments to D16461: Fix syntax support for dynamic member access..
Oct 28 2018, 7:04 PM · KDevelop
pprkut updated the diff for D16461: Fix syntax support for dynamic member access..

Add more checks to the if-statements

Oct 28 2018, 7:02 PM · KDevelop
pprkut added inline comments to D16461: Fix syntax support for dynamic member access..
Oct 28 2018, 6:00 PM · KDevelop
pprkut updated the diff for D16461: Fix syntax support for dynamic member access..

Restructure if-statements in visitStaticMember.
Remove commented code from unit tests.

Oct 28 2018, 5:58 PM · KDevelop

Oct 27 2018

pprkut requested review of D16461: Fix syntax support for dynamic member access..
Oct 27 2018, 3:43 PM · KDevelop

Sep 5 2018

pprkut committed R52:15d4629bbafe: Merge branch '5.3' (authored by pprkut).
Merge branch '5.3'
Sep 5 2018, 8:08 PM
pprkut committed R52:74ccc561f1c3: Merge branch '5.2' into 5.3 (authored by pprkut).
Merge branch '5.2' into 5.3
Sep 5 2018, 8:04 PM
pprkut committed R52:cb5bf5f425c0: Fix ClassNameReferences. (authored by pprkut).
Fix ClassNameReferences.
Sep 5 2018, 7:11 PM
pprkut closed D14818: Fix ClassNameReferences..
Sep 5 2018, 7:11 PM · KDevelop

Aug 19 2018

pprkut committed R52:1c1e8b55ffe1: Don't display declaration comment twice in documentation popup. (authored by pprkut).
Don't display declaration comment twice in documentation popup.
Aug 19 2018, 10:39 AM

Aug 17 2018

pprkut added inline comments to D14818: Fix ClassNameReferences..
Aug 17 2018, 4:30 PM · KDevelop
pprkut updated the diff for D14818: Fix ClassNameReferences..

Split out duplicate code and reordered it a bit to make it easier to follow.

Aug 17 2018, 4:29 PM · KDevelop
pprkut committed R52:42d3c0e577e2: Improved type detection for object properties. (authored by pprkut).
Improved type detection for object properties.
Aug 17 2018, 3:09 PM
pprkut closed D14876: Improved type detection for object properties..
Aug 17 2018, 3:09 PM · KDevelop
pprkut added a comment to D14876: Improved type detection for object properties..

Splitting some code out into a separate function is a bit more tricky than I thought. I have prototype code for it, but it just doesn't quite work right (unit tests don't pass :( ).
I'll merge it for now the way it is and have a look at the refactored version after.

Aug 17 2018, 2:57 PM · KDevelop
pprkut committed R52:488b24571de9: Improve resolution of namespaced identifiers. (authored by pprkut).
Improve resolution of namespaced identifiers.
Aug 17 2018, 9:54 AM
pprkut closed D14839: Improve resolution of namespaced identifiers..
Aug 17 2018, 9:54 AM · KDevelop

Aug 16 2018

pprkut updated the summary of D14876: Improved type detection for object properties..
Aug 16 2018, 1:15 PM · KDevelop
pprkut updated the diff for D14876: Improved type detection for object properties..

Added more unit tests for bugs fixed by this :)

Aug 16 2018, 1:14 PM · KDevelop
pprkut added a dependency for D14876: Improved type detection for object properties.: D14839: Improve resolution of namespaced identifiers..
Aug 16 2018, 12:31 PM · KDevelop
pprkut added a dependent revision for D14839: Improve resolution of namespaced identifiers.: D14876: Improved type detection for object properties..
Aug 16 2018, 12:31 PM · KDevelop
pprkut requested review of D14876: Improved type detection for object properties..
Aug 16 2018, 12:28 PM · KDevelop

Aug 14 2018

pprkut committed R52:86dceed8be89: Fix typo 'Resheduled' -> 'Rescheduled' (authored by pprkut).
Fix typo 'Resheduled' -> 'Rescheduled'
Aug 14 2018, 3:57 PM
pprkut requested review of D14839: Improve resolution of namespaced identifiers..
Aug 14 2018, 3:21 PM · KDevelop
pprkut updated the task description for T6804: PHP 7.2 features.
Aug 14 2018, 2:53 PM · KDevelop
pprkut requested review of D14818: Fix ClassNameReferences..
Aug 14 2018, 8:31 AM · KDevelop

Aug 13 2018

pprkut committed R52:3b25c8fbfc09: Put error and iterator in front as well. (authored by pprkut).
Put error and iterator in front as well.
Aug 13 2018, 8:41 PM
pprkut committed R52:974cdf9a08ec: Update phpfunctions.php (authored by pprkut).
Update phpfunctions.php
Aug 13 2018, 8:41 PM
pprkut committed R52:3fd4676517e4: Make EventUtil's constructor private. (authored by pprkut).
Make EventUtil's constructor private.
Aug 13 2018, 8:41 PM
pprkut committed R52:9c02b63b6422: Make sure to not add properties/methods more than once. (authored by pprkut).
Make sure to not add properties/methods more than once.
Aug 13 2018, 8:41 PM
pprkut committed R52:6c3f76cb78ce: Parse class constants and properties below partintro tags. (authored by pprkut).
Parse class constants and properties below partintro tags.
Aug 13 2018, 8:41 PM
pprkut committed R52:403b37e23e4e: Create better class comments in create_functions.php (authored by pprkut).
Create better class comments in create_functions.php
Aug 13 2018, 8:41 PM
pprkut committed R52:c166de672dc4: Parse abstract modifier for classes. (authored by pprkut).
Parse abstract modifier for classes.
Aug 13 2018, 8:41 PM
pprkut committed R52:2e54e59aa83c: Parse final modifier for classes in create_functions.php (authored by pprkut).
Parse final modifier for classes in create_functions.php
Aug 13 2018, 8:41 PM
pprkut committed R52:6cc9ed45f242: Improve detection of interfaces in create_functions.php (authored by pprkut).
Improve detection of interfaces in create_functions.php
Aug 13 2018, 8:41 PM
pprkut committed R52:4e258f0a63db: Make sure NULL, TRUE and FALSE constants are not removed in create_functions.php (authored by pprkut).
Make sure NULL, TRUE and FALSE constants are not removed in create_functions.php
Aug 13 2018, 8:41 PM
pprkut committed R52:a7d110e9100a: Exclude certain modifiers when declaring interface methods in create_functions. (authored by pprkut).
Exclude certain modifiers when declaring interface methods in create_functions.
Aug 13 2018, 8:41 PM
pprkut committed R52:f478bcc2baaa: Parse return value comments in create_functions.php (authored by pprkut).
Parse return value comments in create_functions.php
Aug 13 2018, 8:41 PM
pprkut committed R52:d8fee7f55d05: Parse more variations of class properties in create_functions.php (authored by pprkut).
Parse more variations of class properties in create_functions.php
Aug 13 2018, 8:41 PM
pprkut committed R52:b936197e5c2d: Add modifiers to method declarations in create_functions.php (authored by pprkut).
Add modifiers to method declarations in create_functions.php
Aug 13 2018, 8:41 PM
pprkut committed R52:a3cd6944ac86: Filter out noise when generating phpdoc in create_functions.php (authored by pprkut).
Filter out noise when generating phpdoc in create_functions.php
Aug 13 2018, 8:40 PM
pprkut committed R52:8851b3f59273: Avoid generating duplicate comments in create_functions.php (authored by pprkut).
Avoid generating duplicate comments in create_functions.php
Aug 13 2018, 8:40 PM
pprkut committed R52:36b4bf029702: Parse refpurpose to add more docs for functions/methods. (authored by pprkut).
Parse refpurpose to add more docs for functions/methods.
Aug 13 2018, 8:40 PM
pprkut committed R52:7ae997297b6f: Make create_functions.php remove spaces at the end of lines. (authored by pprkut).
Make create_functions.php remove spaces at the end of lines.
Aug 13 2018, 8:40 PM
pprkut committed R52:b98ac78ed805: Handle componere classes in create_functions.php (authored by pprkut).
Handle componere classes in create_functions.php
Aug 13 2018, 8:40 PM
pprkut committed R32:56bca5044e16: Ignore file size limit for internal data files. (authored by pprkut).
Ignore file size limit for internal data files.
Aug 13 2018, 2:44 PM
pprkut closed D14789: Ignore file size limit for internal data files..
Aug 13 2018, 2:43 PM · KDevelop
pprkut added a comment to D14789: Ignore file size limit for internal data files..

Shows as "Accepted" here, so lot's see :)

Aug 13 2018, 2:39 PM · KDevelop
pprkut updated the diff for D14789: Ignore file size limit for internal data files..

Compare canonical paths.

Aug 13 2018, 1:09 PM · KDevelop
pprkut abandoned D14498: Fix unit test failures related to the DUChain lock..

Proper fix in 45329c939edfcb3d57d6a53b83ca435da5aa04d8

Aug 13 2018, 12:26 PM · KDevelop
pprkut committed R52:45329c939edf: Properly get the DUChain lock for constant declarations. (authored by pprkut).
Properly get the DUChain lock for constant declarations.
Aug 13 2018, 12:24 PM
pprkut requested review of D14789: Ignore file size limit for internal data files..
Aug 13 2018, 12:11 PM · KDevelop
pprkut updated the task description for T6809: PHP 7.0 features.
Aug 13 2018, 12:04 PM · KDevelop
pprkut closed T6816: PHP 5.5 features as Resolved.
Aug 13 2018, 12:03 PM · KDevelop
pprkut updated the task description for T6816: PHP 5.5 features.
Aug 13 2018, 12:03 PM · KDevelop
pprkut committed R52:d0363ecdc430: Add support for Generators. (authored by pprkut).
Add support for Generators.
Aug 13 2018, 11:56 AM
pprkut closed D13580: Add support for Generators..
Aug 13 2018, 11:56 AM · KDevelop
pprkut committed R52:dedb6db30ce7: Fix chained print expressions. (authored by pprkut).
Fix chained print expressions.
Aug 13 2018, 11:56 AM
pprkut closed D13547: Expression syntax improvements.
Aug 13 2018, 11:56 AM · KDevelop
pprkut committed R52:ea9b7f55cc5b: Disallow some illegal expressions. (authored by pprkut).
Disallow some illegal expressions.
Aug 13 2018, 11:56 AM
pprkut committed R52:e9abb872cb66: Merge branch '5.2' (authored by pprkut).
Merge branch '5.2'
Aug 13 2018, 10:14 AM
pprkut committed R52:86518e47c687: Fix bugtracker URL in appstream metadata. (authored by pprkut).
Fix bugtracker URL in appstream metadata.
Aug 13 2018, 9:19 AM
pprkut committed R52:72101835ae02: Reschedule parse jobs also when the parse queue is empty. (authored by pprkut).
Reschedule parse jobs also when the parse queue is empty.
Aug 13 2018, 9:19 AM
pprkut committed R52:4b1f5377eb9f: Determine correct type for relational and equality expressions. (authored by pprkut).
Determine correct type for relational and equality expressions.
Aug 13 2018, 9:19 AM
pprkut closed D14113: Reschedule parse jobs also when the parse queue is empty..
Aug 13 2018, 9:19 AM · KDevelop

Aug 11 2018

pprkut added a comment to D14498: Fix unit test failures related to the DUChain lock..

ping :)

Aug 11 2018, 1:57 PM · KDevelop
pprkut added a comment to D14113: Reschedule parse jobs also when the parse queue is empty..

ping :)

Aug 11 2018, 1:57 PM · KDevelop
pprkut added a comment to D13547: Expression syntax improvements.

If there's no objections, I'm gonna merge this on Monday together with D13580

Aug 11 2018, 1:56 PM · KDevelop

Aug 2 2018

pprkut added inline comments to D13580: Add support for Generators..
Aug 2 2018, 6:33 PM · KDevelop
pprkut updated the diff for D13580: Add support for Generators..

Less spaghetti in the lexer.

Aug 2 2018, 6:31 PM · KDevelop

Jul 30 2018

pprkut requested review of D14498: Fix unit test failures related to the DUChain lock..
Jul 30 2018, 8:33 PM · KDevelop
pprkut added a comment to D13580: Add support for Generators..

I rebased this against master and found it has the same problem as D13547, i.e. it introduces 10 first/follow conflicts :/
Not sure it's worth trying to solve it here either.

Jul 30 2018, 7:30 PM · KDevelop