- User Since
- Feb 24 2017, 6:42 PM (99 w, 2 d)
Wed, Jan 9
I'm afraid I don't know much about this either :-/
The fact that the unit tests are currently completely broken doesn't help. I did try them with and without this change and what I *can* say is that it's neither worse nor better.
Sat, Jan 5
Nov 22 2018
Nov 17 2018
Oct 28 2018
Add more checks to the if-statements
Restructure if-statements in visitStaticMember.
Remove commented code from unit tests.
Oct 27 2018
Sep 5 2018
Aug 19 2018
Aug 17 2018
Split out duplicate code and reordered it a bit to make it easier to follow.
Splitting some code out into a separate function is a bit more tricky than I thought. I have prototype code for it, but it just doesn't quite work right (unit tests don't pass :( ).
I'll merge it for now the way it is and have a look at the refactored version after.
Aug 16 2018
Added more unit tests for bugs fixed by this :)
Aug 14 2018
Aug 13 2018
Shows as "Accepted" here, so lot's see :)
Compare canonical paths.
Proper fix in 45329c939edfcb3d57d6a53b83ca435da5aa04d8
Aug 11 2018
If there's no objections, I'm gonna merge this on Monday together with D13580
Aug 2 2018
Less spaghetti in the lexer.
Jul 30 2018
I rebased this against master and found it has the same problem as D13547, i.e. it introduces 10 first/follow conflicts :/
Not sure it's worth trying to solve it here either.
Jul 28 2018
Jul 15 2018
Jul 14 2018
Jun 17 2018
Jun 14 2018
Jun 13 2018
Jun 7 2018
Renamed isObjectTypehint => isClassTypehint to avoid confusion when
'object' typehint support is implemented.
Jun 3 2018
Feb 24 2018
Jan 27 2018
Jan 6 2018
Not really a cmake expert. Changes look sound, but can't really judge whether they are correct. Generally looks fine to me, apart from installing the php.g grammar file.