pprkut (Heinz Wiesinger)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 24 2017, 6:42 PM (187 w, 4 d)
Availability
Available

Recent Activity

May 6 2020

pprkut updated the task description for T6803: PHP 7.1 features.
May 6 2020, 7:43 AM · KDevelop

May 5 2020

pprkut committed R52:6799a48cbf7c: Fix a crash when showing the documentation popup (authored by pprkut).
Fix a crash when showing the documentation popup
May 5 2020, 2:20 PM
pprkut added a comment to D26254: Add support for PHP 7.4's typed properties.

I had a look at this again. Updated to latest master of both kdevelop and kdev-php just to make sure I didn't miss a commit in kdevelop that might have influenced this, but my tests still pass just fine. Furthermore, I don't see what your patch would fix. The change you made is in a code-path that's unaffected by property types, and if there is a crash there it should've triggered just the same before the change.

May 5 2020, 2:09 PM · KDevelop
pprkut committed R52:8349069a8842: Add support for PHP 7.1's catching multiple exceptions syntax (authored by pprkut).
Add support for PHP 7.1's catching multiple exceptions syntax
May 5 2020, 1:55 PM

Apr 9 2020

pprkut added a comment to D26254: Add support for PHP 7.4's typed properties.

Hmm, this is odd.

Apr 9 2020, 3:56 PM · KDevelop

Feb 1 2020

pprkut updated the task description for T6810: PHP 5.6 features.
Feb 1 2020, 1:20 PM · KDevelop
pprkut updated the task description for T6810: PHP 5.6 features.
Feb 1 2020, 1:19 PM · KDevelop

Jan 18 2020

pprkut committed R52:893d7c8dfaca: Fix uses of function call parameters after closures (authored by pprkut).
Fix uses of function call parameters after closures
Jan 18 2020, 10:18 PM
pprkut committed R52:54964af00e7e: Add support for PHP 7.4's typed properties (authored by pprkut).
Add support for PHP 7.4's typed properties
Jan 18 2020, 10:18 PM
pprkut closed D26254: Add support for PHP 7.4's typed properties.
Jan 18 2020, 10:18 PM · KDevelop

Jan 13 2020

pprkut committed R52:01bee88947f6: Support importing functions and constants from other namespaces (authored by hmitonneau).
Support importing functions and constants from other namespaces
Jan 13 2020, 6:44 PM
pprkut closed D25956: [KDevelop/PHP] Importing functions and const from other namespaces.
Jan 13 2020, 6:44 PM · KDevelop
pprkut added a comment to D26254: Add support for PHP 7.4's typed properties.

I would really like to have this in 5.5, so if there's no review by next weekend I'll merge as is.

Jan 13 2020, 6:02 PM · KDevelop
pprkut accepted D25956: [KDevelop/PHP] Importing functions and const from other namespaces.
Jan 13 2020, 5:53 PM · KDevelop

Jan 5 2020

pprkut added a comment to D25956: [KDevelop/PHP] Importing functions and const from other namespaces.

Looks good :)

Jan 5 2020, 11:45 AM · KDevelop

Dec 28 2019

pprkut requested review of D26254: Add support for PHP 7.4's typed properties.
Dec 28 2019, 9:59 AM · KDevelop
pprkut added inline comments to D25956: [KDevelop/PHP] Importing functions and const from other namespaces.
Dec 28 2019, 9:48 AM · KDevelop
pprkut committed R52:f68154391a30: Fix rename of a variable (authored by hmitonneau).
Fix rename of a variable
Dec 28 2019, 9:25 AM
pprkut closed D25587: [KDevelop/PHP] fix rename of a variable.
Dec 28 2019, 9:25 AM · KDevelop
pprkut accepted D25587: [KDevelop/PHP] fix rename of a variable.

Looks good :)

Dec 28 2019, 9:19 AM · KDevelop

Dec 26 2019

pprkut committed R52:53f30e5b9b2b: Add support for "array of type" (authored by hmitonneau).
Add support for "array of type"
Dec 26 2019, 11:27 AM
pprkut closed D24921: [KDevelop/PHP] Add support for "array of type".
Dec 26 2019, 11:27 AM · KDevelop

Dec 23 2019

pprkut added a comment to D24921: [KDevelop/PHP] Add support for "array of type".

Sorry this took so long! I have it ready to merge, just need to know the email you'd like me to use for the commit author

Dec 23 2019, 7:41 AM · KDevelop

Dec 14 2019

pprkut added a comment to D25587: [KDevelop/PHP] fix rename of a variable.

I appreciate the effort, but I think this is the wrong approach. I really think the $ is part of the variable.

Dec 14 2019, 9:51 AM · KDevelop
pprkut accepted D24921: [KDevelop/PHP] Add support for "array of type".
Dec 14 2019, 9:32 AM · KDevelop
pprkut added a comment to D24921: [KDevelop/PHP] Add support for "array of type".

Hi! Sorry, I was just really busy and didn't have time to take a closer look.

Dec 14 2019, 9:32 AM · KDevelop

Nov 25 2019

pprkut accepted D25513: Fix minor typos, use https:// links.

Looks good to me :)

Nov 25 2019, 8:54 AM · KDevelop

Oct 27 2019

pprkut committed R52:4c46f097425c: Add support for class constant visibility (authored by pprkut).
Add support for class constant visibility
Oct 27 2019, 8:23 AM
pprkut added a comment to D22062: Addition of php script output patterns. Initial development..

I agree that conceptually this should be moved to (or supplemented by) the actual language plugins, but also agree that this might be out of scope for this change.
As far as the PHP changes are concerned this is fine with me. However, I'd prefer those patterns to be unit tested and not just documented in comments.
Could you have a look at adding those tests?

Oct 27 2019, 7:54 AM · KDevelop
pprkut added a reviewer for D24921: [KDevelop/PHP] Add support for "array of type": pprkut.
Oct 27 2019, 7:39 AM · KDevelop
pprkut added a comment to D24921: [KDevelop/PHP] Add support for "array of type".

Conceptually, this looks fine. However, like this we end up with two different descriptions of "Array of" types in the navigation popups.
While this shows integer arrays as int[], for variadics it will show array of (int). I think at the very least both should be displayed the same.

Oct 27 2019, 7:39 AM · KDevelop
pprkut updated the task description for T6803: PHP 7.1 features.
Oct 27 2019, 7:10 AM · KDevelop

Oct 7 2019

pprkut committed R52:cb71eff2153a: Fix expressions using array constants (authored by pprkut).
Fix expressions using array constants
Oct 7 2019, 11:05 AM
pprkut committed R52:df6070ff9991: Don't mark class constants as normal members (authored by pprkut).
Don't mark class constants as normal members
Oct 7 2019, 11:05 AM

Mar 18 2019

pprkut committed R52:2b4a2abcc233: Update phpfunctions.php to phpdoc revision 347011 (authored by pprkut).
Update phpfunctions.php to phpdoc revision 347011
Mar 18 2019, 7:03 PM
pprkut committed R52:fb4484a9b18c: Parse more function aliases (authored by pprkut).
Parse more function aliases
Mar 18 2019, 7:03 PM
pprkut committed R52:1004709844d0: More special handling for mcrypt constants (authored by pprkut).
More special handling for mcrypt constants
Mar 18 2019, 7:03 PM
pprkut committed R52:bbdaceac3287: Parse more constants (authored by pprkut).
Parse more constants
Mar 18 2019, 7:03 PM
pprkut committed R52:fed9a170e9b9: Parse more class constants (authored by pprkut).
Parse more class constants
Mar 18 2019, 7:03 PM
pprkut committed R52:a6b8d3a1e664: Parse more constants within tables (authored by pprkut).
Parse more constants within tables
Mar 18 2019, 7:03 PM
pprkut committed R52:c95326706c26: Parse constants under para (authored by pprkut).
Parse constants under para
Mar 18 2019, 7:03 PM
pprkut committed R52:cd5cc1375da3: Parse url stat constants (authored by pprkut).
Parse url stat constants
Mar 18 2019, 7:03 PM
pprkut committed R52:9a4fb516de9c: Parse file upload constants (authored by pprkut).
Parse file upload constants
Mar 18 2019, 7:03 PM
pprkut committed R52:34ede9006d6e: Parse php token constants (authored by pprkut).
Parse php token constants
Mar 18 2019, 7:03 PM
pprkut committed R52:1055217b856c: Parse constants under tables (authored by pprkut).
Parse constants under tables
Mar 18 2019, 7:03 PM
pprkut committed R52:35b50146169e: Parse nl-langinfo constants (authored by pprkut).
Parse nl-langinfo constants
Mar 18 2019, 7:03 PM
pprkut committed R52:709b95116e0d: Parse constants under section and within tables (authored by pprkut).
Parse constants under section and within tables
Mar 18 2019, 7:03 PM
pprkut committed R52:77fb3cad39de: Fix function declarations with varargs (authored by pprkut).
Fix function declarations with varargs
Mar 18 2019, 7:03 PM
pprkut committed R52:c031d1c43754: Parse constants split over multiple lists within one file (authored by pprkut).
Parse constants split over multiple lists within one file
Mar 18 2019, 7:03 PM

Jan 9 2019

pprkut added a comment to D18122: Fix Xdebug disconnecting after php finished if multiple connections are allowed.

I'm afraid I don't know much about this either :-/
The fact that the unit tests are currently completely broken doesn't help. I did try them with and without this change and what I *can* say is that it's neither worse nor better.

Jan 9 2019, 7:46 PM · KDevelop

Jan 5 2019

pprkut requested review of D17990: Update php syntax support.
Jan 5 2019, 3:55 PM · Frameworks, Kate

Nov 22 2018

pprkut committed R52:60dbbdf90ba3: Merge branch '5.3' (authored by pprkut).
Merge branch '5.3'
Nov 22 2018, 7:59 PM
pprkut committed R52:4e07839f5a97: Fix handling of array indexes after ClassNameReferences (authored by pprkut).
Fix handling of array indexes after ClassNameReferences
Nov 22 2018, 7:58 PM

Nov 17 2018

pprkut committed R52:2469eba750b2: Fix syntax support for dynamic member access. (authored by pprkut).
Fix syntax support for dynamic member access.
Nov 17 2018, 4:45 PM
pprkut closed D16461: Fix syntax support for dynamic member access..
Nov 17 2018, 4:45 PM · KDevelop

Oct 28 2018

pprkut added inline comments to D16461: Fix syntax support for dynamic member access..
Oct 28 2018, 7:04 PM · KDevelop
pprkut updated the diff for D16461: Fix syntax support for dynamic member access..

Add more checks to the if-statements

Oct 28 2018, 7:02 PM · KDevelop
pprkut added inline comments to D16461: Fix syntax support for dynamic member access..
Oct 28 2018, 6:00 PM · KDevelop
pprkut updated the diff for D16461: Fix syntax support for dynamic member access..

Restructure if-statements in visitStaticMember.
Remove commented code from unit tests.

Oct 28 2018, 5:58 PM · KDevelop

Oct 27 2018

pprkut requested review of D16461: Fix syntax support for dynamic member access..
Oct 27 2018, 3:43 PM · KDevelop

Sep 5 2018

pprkut committed R52:15d4629bbafe: Merge branch '5.3' (authored by pprkut).
Merge branch '5.3'
Sep 5 2018, 8:08 PM
pprkut committed R52:74ccc561f1c3: Merge branch '5.2' into 5.3 (authored by pprkut).
Merge branch '5.2' into 5.3
Sep 5 2018, 8:04 PM
pprkut committed R52:cb5bf5f425c0: Fix ClassNameReferences. (authored by pprkut).
Fix ClassNameReferences.
Sep 5 2018, 7:11 PM
pprkut closed D14818: Fix ClassNameReferences..
Sep 5 2018, 7:11 PM · KDevelop

Aug 19 2018

pprkut committed R52:1c1e8b55ffe1: Don't display declaration comment twice in documentation popup. (authored by pprkut).
Don't display declaration comment twice in documentation popup.
Aug 19 2018, 10:39 AM

Aug 17 2018

pprkut added inline comments to D14818: Fix ClassNameReferences..
Aug 17 2018, 4:30 PM · KDevelop
pprkut updated the diff for D14818: Fix ClassNameReferences..

Split out duplicate code and reordered it a bit to make it easier to follow.

Aug 17 2018, 4:29 PM · KDevelop
pprkut committed R52:42d3c0e577e2: Improved type detection for object properties. (authored by pprkut).
Improved type detection for object properties.
Aug 17 2018, 3:09 PM
pprkut closed D14876: Improved type detection for object properties..
Aug 17 2018, 3:09 PM · KDevelop
pprkut added a comment to D14876: Improved type detection for object properties..

Splitting some code out into a separate function is a bit more tricky than I thought. I have prototype code for it, but it just doesn't quite work right (unit tests don't pass :( ).
I'll merge it for now the way it is and have a look at the refactored version after.

Aug 17 2018, 2:57 PM · KDevelop
pprkut committed R52:488b24571de9: Improve resolution of namespaced identifiers. (authored by pprkut).
Improve resolution of namespaced identifiers.
Aug 17 2018, 9:54 AM
pprkut closed D14839: Improve resolution of namespaced identifiers..
Aug 17 2018, 9:54 AM · KDevelop

Aug 16 2018

pprkut updated the summary of D14876: Improved type detection for object properties..
Aug 16 2018, 1:15 PM · KDevelop
pprkut updated the diff for D14876: Improved type detection for object properties..

Added more unit tests for bugs fixed by this :)

Aug 16 2018, 1:14 PM · KDevelop
pprkut added a dependency for D14876: Improved type detection for object properties.: D14839: Improve resolution of namespaced identifiers..
Aug 16 2018, 12:31 PM · KDevelop
pprkut added a dependent revision for D14839: Improve resolution of namespaced identifiers.: D14876: Improved type detection for object properties..
Aug 16 2018, 12:31 PM · KDevelop
pprkut requested review of D14876: Improved type detection for object properties..
Aug 16 2018, 12:28 PM · KDevelop

Aug 14 2018

pprkut committed R52:86dceed8be89: Fix typo 'Resheduled' -> 'Rescheduled' (authored by pprkut).
Fix typo 'Resheduled' -> 'Rescheduled'
Aug 14 2018, 3:57 PM
pprkut requested review of D14839: Improve resolution of namespaced identifiers..
Aug 14 2018, 3:21 PM · KDevelop
pprkut updated the task description for T6804: PHP 7.2 features.
Aug 14 2018, 2:53 PM · KDevelop
pprkut requested review of D14818: Fix ClassNameReferences..
Aug 14 2018, 8:31 AM · KDevelop

Aug 13 2018

pprkut committed R52:3b25c8fbfc09: Put error and iterator in front as well. (authored by pprkut).
Put error and iterator in front as well.
Aug 13 2018, 8:41 PM
pprkut committed R52:974cdf9a08ec: Update phpfunctions.php (authored by pprkut).
Update phpfunctions.php
Aug 13 2018, 8:41 PM
pprkut committed R52:3fd4676517e4: Make EventUtil's constructor private. (authored by pprkut).
Make EventUtil's constructor private.
Aug 13 2018, 8:41 PM
pprkut committed R52:9c02b63b6422: Make sure to not add properties/methods more than once. (authored by pprkut).
Make sure to not add properties/methods more than once.
Aug 13 2018, 8:41 PM
pprkut committed R52:6c3f76cb78ce: Parse class constants and properties below partintro tags. (authored by pprkut).
Parse class constants and properties below partintro tags.
Aug 13 2018, 8:41 PM
pprkut committed R52:403b37e23e4e: Create better class comments in create_functions.php (authored by pprkut).
Create better class comments in create_functions.php
Aug 13 2018, 8:41 PM
pprkut committed R52:c166de672dc4: Parse abstract modifier for classes. (authored by pprkut).
Parse abstract modifier for classes.
Aug 13 2018, 8:41 PM
pprkut committed R52:2e54e59aa83c: Parse final modifier for classes in create_functions.php (authored by pprkut).
Parse final modifier for classes in create_functions.php
Aug 13 2018, 8:41 PM
pprkut committed R52:6cc9ed45f242: Improve detection of interfaces in create_functions.php (authored by pprkut).
Improve detection of interfaces in create_functions.php
Aug 13 2018, 8:41 PM
pprkut committed R52:4e258f0a63db: Make sure NULL, TRUE and FALSE constants are not removed in create_functions.php (authored by pprkut).
Make sure NULL, TRUE and FALSE constants are not removed in create_functions.php
Aug 13 2018, 8:41 PM
pprkut committed R52:a7d110e9100a: Exclude certain modifiers when declaring interface methods in create_functions. (authored by pprkut).
Exclude certain modifiers when declaring interface methods in create_functions.
Aug 13 2018, 8:41 PM
pprkut committed R52:f478bcc2baaa: Parse return value comments in create_functions.php (authored by pprkut).
Parse return value comments in create_functions.php
Aug 13 2018, 8:41 PM
pprkut committed R52:d8fee7f55d05: Parse more variations of class properties in create_functions.php (authored by pprkut).
Parse more variations of class properties in create_functions.php
Aug 13 2018, 8:41 PM
pprkut committed R52:b936197e5c2d: Add modifiers to method declarations in create_functions.php (authored by pprkut).
Add modifiers to method declarations in create_functions.php
Aug 13 2018, 8:41 PM
pprkut committed R52:a3cd6944ac86: Filter out noise when generating phpdoc in create_functions.php (authored by pprkut).
Filter out noise when generating phpdoc in create_functions.php
Aug 13 2018, 8:40 PM
pprkut committed R52:8851b3f59273: Avoid generating duplicate comments in create_functions.php (authored by pprkut).
Avoid generating duplicate comments in create_functions.php
Aug 13 2018, 8:40 PM
pprkut committed R52:36b4bf029702: Parse refpurpose to add more docs for functions/methods. (authored by pprkut).
Parse refpurpose to add more docs for functions/methods.
Aug 13 2018, 8:40 PM
pprkut committed R52:7ae997297b6f: Make create_functions.php remove spaces at the end of lines. (authored by pprkut).
Make create_functions.php remove spaces at the end of lines.
Aug 13 2018, 8:40 PM
pprkut committed R52:b98ac78ed805: Handle componere classes in create_functions.php (authored by pprkut).
Handle componere classes in create_functions.php
Aug 13 2018, 8:40 PM