hmitonneau (Hugues Mitonneau)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
May 28 2019, 10:56 AM (68 w, 4 d)
Availability
Available

Recent Activity

Jul 23 2020

hmitonneau updated the diff for D29444: [KDevelop/PHP] Implement Grouped namespaces.

What is missing:

  • Declaration with alias into grouped namespace are not processed: use Foo\ { const C as FooC };
  • There is no test
  • The mix between UseImportType, ParserUseImportType, DeclarationType is not clean
Jul 23 2020, 5:03 PM · KDevelop

May 6 2020

hmitonneau added a comment to D26254: Add support for PHP 7.4's typed properties.

The test output:

2: FAIL!  : Php::TestDUChain::classMemberVar() 'var->type<IntegralType>()' returned FALSE. ()
2:    Loc: [/home/hmitonneau/kde/src/kdev-php/duchain/tests/duchain.cpp(449)]
May 6 2020, 7:31 AM · KDevelop

May 5 2020

hmitonneau added a comment to D29444: [KDevelop/PHP] Implement Grouped namespaces.

Are the trailing commas from T6804 supported?

May 5 2020, 12:52 PM · KDevelop
hmitonneau requested review of D29444: [KDevelop/PHP] Implement Grouped namespaces.
May 5 2020, 10:20 AM · KDevelop

Apr 15 2020

hmitonneau added a comment to D26254: Add support for PHP 7.4's typed properties.

I have compiled from scratch with kdesrc-build (with cmake-options -DCMAKE_BUILD_TYPE=RelWithDebInfo). The duchain test still doesn't pass.
After some debug, it seems that m_gotTypeFromTypeHint is not always initialized correctly.
The following patch fix the problem for me:

Apr 15 2020, 4:06 PM · KDevelop

Apr 9 2020

hmitonneau added a comment to D26254: Add support for PHP 7.4's typed properties.

Sorry for the very late comment...
Before this commit, the type of properties were deduced from the assign default value:


Since this commit, the type is <no type> if it is not explicitly specified (either in php7 style or in doc-comment)

Apr 9 2020, 3:18 PM · KDevelop

Jan 7 2020

hmitonneau updated the diff for D25956: [KDevelop/PHP] Importing functions and const from other namespaces.

add some tests

Jan 7 2020, 12:12 PM · KDevelop

Jan 3 2020

hmitonneau updated the diff for D25956: [KDevelop/PHP] Importing functions and const from other namespaces.

fix: const are case sensitive
improve tests

Jan 3 2020, 12:12 PM · KDevelop

Dec 26 2019

hmitonneau added a comment to D24921: [KDevelop/PHP] Add support for "array of type".

No problem.
You can use hugues@mitonneau.me
Thanks

Dec 26 2019, 8:48 AM · KDevelop

Dec 17 2019

hmitonneau updated the diff for D25587: [KDevelop/PHP] fix rename of a variable.

This new patch re-implement KDevelop::BasicRefactoring::applyChangesToDeclarations and KDevelop::BasicRefactoring::applyChanges in Php::Refactoring.

Dec 17 2019, 10:23 AM · KDevelop

Dec 14 2019

hmitonneau added a comment to D24921: [KDevelop/PHP] Add support for "array of type".

No, I don't have commit access.

Dec 14 2019, 11:42 AM · KDevelop

Dec 13 2019

hmitonneau added a comment to D24921: [KDevelop/PHP] Add support for "array of type".

Is there something wrong with the second diff ?

Dec 13 2019, 4:20 PM · KDevelop
hmitonneau requested review of D25956: [KDevelop/PHP] Importing functions and const from other namespaces.
Dec 13 2019, 3:38 PM · KDevelop

Nov 28 2019

hmitonneau requested review of D25587: [KDevelop/PHP] fix rename of a variable.
Nov 28 2019, 10:29 AM · KDevelop

Oct 29 2019

hmitonneau updated the diff for D24921: [KDevelop/PHP] Add support for "array of type".

Move variadics from IndexedContainer to ArrayType

Oct 29 2019, 11:29 AM · KDevelop

Oct 24 2019

hmitonneau requested review of D24921: [KDevelop/PHP] Add support for "array of type".
Oct 24 2019, 1:47 PM · KDevelop

Jun 14 2019

hmitonneau added a watcher for KDevelop: hmitonneau.
Jun 14 2019, 10:27 AM

May 28 2019

hmitonneau requested review of D21458: clang: fix test bench_codecompletion compilation.
May 28 2019, 11:34 AM · KDevelop