Feed Advanced Search

Yesterday

apol added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

Can't we really fix this without bringing a dependency?
If we really want the dependency, can we just link against it instead of dragging it into our source code?

Thu, May 23, 11:19 AM · KDevelop

Tue, May 21

arrowd updated the diff for D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

Changes:

  • Import QtPromise 0.5.0 into kdevplatform/3dparty/ directory.
  • Remove synchronious KIO calls from Project::open() and use QPromises there instead.
Tue, May 21, 10:12 AM · KDevelop

Sat, May 18

simgunz added a comment to D21156: Fix browse mode not disabled after Ctrl is released.

you are removing a feature, but only partially - a lot of code would become superfluous by this change and should be cleaned up accordingly

Sat, May 18, 10:25 AM · KDevelop

Thu, May 16

rjvbb added a comment to D21156: Fix browse mode not disabled after Ctrl is released.
you are removing a feature
Thu, May 16, 12:32 AM · KDevelop

Wed, May 15

mwolff requested changes to D21156: Fix browse mode not disabled after Ctrl is released.

you are removing a feature, but only partially - a lot of code would become superfluous by this change and should be cleaned up accordingly

Wed, May 15, 9:25 PM · KDevelop
rjvbb accepted D21156: Fix browse mode not disabled after Ctrl is released.

Sounds good enough for me then!

Wed, May 15, 3:05 PM · KDevelop
simgunz added a comment to D21156: Fix browse mode not disabled after Ctrl is released.

With the Alt key the bug does not appear, because the existing code disables correctly the browse mode when Alt is released. For some reasons key press and release events are different for Ctrl key but are the same for Alt. Probably the method avoidMenuAltFocus manages this behavior correctly for the Alt key (I have not analyzed in detail what it does) and then we enter correctly in the if at line 230 where source browse mode is disabled. So removing the redundant Ctrl key solves the bug completely (at least I haven't manage to reproduce it).

Wed, May 15, 1:36 PM · KDevelop
rjvbb added a comment to D21156: Fix browse mode not disabled after Ctrl is released.

You identified an event chain which leads to the browsing mode not being restored correctly. This should happen less often with the Alt modifier but it can still happen (hit Alt to display a tooltip or open a menu and then move the mouse over that tooltip or select a menu item?).

Wed, May 15, 11:55 AM · KDevelop
simgunz updated subscribers of D21156: Fix browse mode not disabled after Ctrl is released.
Wed, May 15, 11:27 AM · KDevelop
simgunz updated the summary of D21156: Fix browse mode not disabled after Ctrl is released.
Wed, May 15, 11:26 AM · KDevelop
simgunz updated the diff for D21156: Fix browse mode not disabled after Ctrl is released.
  • Disable Ctrl and keep only Alt
Wed, May 15, 11:25 AM · KDevelop

Sun, May 12

simgunz added a reviewer for D21156: Fix browse mode not disabled after Ctrl is released: KDevelop.
Sun, May 12, 2:09 PM · KDevelop
simgunz requested review of D21156: Fix browse mode not disabled after Ctrl is released.
Sun, May 12, 2:07 PM · KDevelop

Wed, May 1

thomassc closed D18224: Clang Plugin: Report some problems from included files.
Wed, May 1, 12:39 PM · KDevelop

Tue, Apr 30

kossebau closed D20920: Add DesktopEntry to notifyrc.
Tue, Apr 30, 6:01 PM · KDevelop
kfunk accepted D20920: Add DesktopEntry to notifyrc.

Feel free to push it into the 5.3 branch then.

Tue, Apr 30, 2:03 PM · KDevelop
broulik requested review of D20920: Add DesktopEntry to notifyrc.
Tue, Apr 30, 12:51 PM · KDevelop

Apr 22 2019

christiant added a comment to D20142: DVCS Branch Manager with filtering and sorting proposal.

No problem. I don't think I'm yet involved enough to apply - besides being a user.

Apr 22 2019, 9:47 PM · KDevelop, VDG

Apr 19 2019

apol added a comment to D20142: DVCS Branch Manager with filtering and sorting proposal.

Probably not - this is my first commit. Where do I need to apply :-D

Apr 19 2019, 11:42 PM · KDevelop, VDG
apol closed D20142: DVCS Branch Manager with filtering and sorting proposal.
Apr 19 2019, 11:41 PM · KDevelop, VDG

Apr 18 2019

christiant added a comment to D20142: DVCS Branch Manager with filtering and sorting proposal.

Anything I need to do?

Apr 18 2019, 9:35 PM · KDevelop, VDG
christiant removed a member for KDevelop: christiant.
Apr 18 2019, 9:33 PM
christiant added a member for KDevelop: christiant.
Apr 18 2019, 9:31 PM
christiant added a watcher for KDevelop: christiant.
Apr 18 2019, 9:31 PM

Apr 16 2019

mwolff accepted D18224: Clang Plugin: Report some problems from included files.

patch lgtm now, many thanks!

Apr 16 2019, 1:36 PM · KDevelop
mwolff added a comment to D18224: Clang Plugin: Report some problems from included files.

Upon reopening a file, we should only update the problems of changed files that got updated. Otherwise we should only grab the TU for the main .cpp file and attach it, such that we can do code completion.

If I understand this correctly, then perhaps something does not behave as it should there, since in some cases, a lot of files' problems seem to get updated when re-opening a file, including lots of system headers that certainly haven't changed. In other cases, no calls to ParseSession::problemsForFile() are made. It seems that the first case can be triggered by making changes to a header, closing it without saving, and then re-opening it.

Apr 16 2019, 1:34 PM · KDevelop

Apr 15 2019

thomassc added a comment to D18224: Clang Plugin: Report some problems from included files.

Upon reopening a file, we should only update the problems of changed files that got updated. Otherwise we should only grab the TU for the main .cpp file and attach it, such that we can do code completion.

Apr 15 2019, 10:59 PM · KDevelop
thomassc updated the diff for D18224: Clang Plugin: Report some problems from included files.

Re-add m_diagnosticsCache with a hopefully correct caching implementation. Differing from the original situation, the new function createExternalProblem() adapts the problems it creates to the specific file they are inserted in. The cache thus only caches the original problems as created by ClangDiagnosticEvaluator::createProblem(). createExternalProblem() makes copies of these with a new copy constructor added to ClangProblem.

Apr 15 2019, 10:59 PM · KDevelop
mwolff added a comment to D18551: clang: Create preamble only on second parse.

quite obviously libclang doesn't handle it

Apr 15 2019, 7:38 PM · KDevelop
rjvbb added a comment to D18551: clang: Create preamble only on second parse.
Do you mean something like `#include <Foo>` which then contains a `#include <foo.h>`?
Apr 15 2019, 9:01 AM · KDevelop
mwolff added a comment to D18551: clang: Create preamble only on second parse.

Re: reparsing reliably each time a headerfile is changed: wouldn't the use of forwarding headers increase the chance of missing a change?

Apr 15 2019, 8:25 AM · KDevelop
mwolff added a comment to D18224: Clang Plugin: Report some problems from included files.

I re-tested the behavior on files from an actual project and it showed the same behavior when editing files as described in my last post, regardless of how many files are included from the files that are edited. I noticed that the behavior is different when re-opening files: in this case, problemsForFile() is actually called for a larger set of files (although from only looking at this set of files, it seemed a bit random and it was not clear to me how it is determined, I'll have to dig into the source code for this at some point ...).

Apr 15 2019, 8:17 AM · KDevelop
mwolff added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..
In D18758#450081, @apol wrote:

Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?

That would mean adding a bunch of noexcept all over the place or risk quite some performance penalty. I'd prefer keeping it localised.

Apr 15 2019, 8:13 AM · KDevelop

Apr 14 2019

apol added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?

Apr 14 2019, 6:14 PM · KDevelop
tristanp requested review of D20548: Fix document switcher plugin with multiple splitted view..
Apr 14 2019, 4:31 PM · KDevelop
thomassc added a comment to D18224: Clang Plugin: Report some problems from included files.

I am sorry, I think that I misunderstood how the cache works. Please disregard my previous message. I am wondering where the problem that I've been seeing then comes from, seems like it has a different origin.

Apr 14 2019, 10:11 AM · KDevelop

Apr 13 2019

thomassc added a comment to D18224: Clang Plugin: Report some problems from included files.

I re-tested the behavior on files from an actual project and it showed the same behavior when editing files as described in my last post, regardless of how many files are included from the files that are edited. I noticed that the behavior is different when re-opening files: in this case, problemsForFile() is actually called for a larger set of files (although from only looking at this set of files, it seemed a bit random and it was not clear to me how it is determined, I'll have to dig into the source code for this at some point ...).

Apr 13 2019, 9:21 PM · KDevelop
thomassc closed D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.
Apr 13 2019, 7:55 PM · KDevelop
arrowd added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?

Apr 13 2019, 6:55 PM · KDevelop
gennad removed a watcher for KDevelop: gennad.
Apr 13 2019, 6:18 PM
mwolff added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?

Apr 13 2019, 4:51 PM · KDevelop
mwolff requested changes to D18224: Clang Plugin: Report some problems from included files.

Hey Thomas, please don't remove the cache. See f2a6941e086cdf506c8fb1798c52982bff43792d for why this was introduced. Your tests don't include other files, so probably that's why you didn't see any effect of the cache?

Apr 13 2019, 4:49 PM · KDevelop
mwolff accepted D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

thanks, lgtm!

Apr 13 2019, 4:41 PM · KDevelop

Apr 9 2019

hein closed D20419: Fix build on Qt 5.13 branch.
Apr 9 2019, 10:43 PM · KDevelop
apol accepted D20419: Fix build on Qt 5.13 branch.
Apr 9 2019, 9:47 PM · KDevelop
hein requested review of D20419: Fix build on Qt 5.13 branch.
Apr 9 2019, 9:38 PM · KDevelop
christiant added a comment to D20142: DVCS Branch Manager with filtering and sorting proposal.

Probably not - this is my first commit. Where do I need to apply :-D

Apr 9 2019, 8:23 AM · KDevelop, VDG
apol accepted D20142: DVCS Branch Manager with filtering and sorting proposal.

Good stuff, do you have push rights?

Apr 9 2019, 1:04 AM · KDevelop, VDG

Apr 8 2019

christiant updated the diff for D20142: DVCS Branch Manager with filtering and sorting proposal.

Upload correct patch

Apr 8 2019, 8:34 PM · KDevelop, VDG
christiant added a comment to D20142: DVCS Branch Manager with filtering and sorting proposal.

Yeah, you're right.

Apr 8 2019, 12:19 PM · KDevelop, VDG
apol added a comment to D20142: DVCS Branch Manager with filtering and sorting proposal.

I think you uploaded the patch against the last version, not against master.

Apr 8 2019, 12:04 AM · KDevelop, VDG

Apr 6 2019

thomassc updated the diff for D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

Thanks for the info. I didn't spot it at first since it is hidden in a dropdown menu.

Apr 6 2019, 2:58 PM · KDevelop
thomassc commandeered D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.
Apr 6 2019, 2:56 PM · KDevelop
thomassc updated the diff for D18224: Clang Plugin: Report some problems from included files.

Address Milian's comments; remove m_diagnosticsCache.

Apr 6 2019, 2:52 PM · KDevelop
thomassc added inline comments to D18224: Clang Plugin: Report some problems from included files.
Apr 6 2019, 2:50 PM · KDevelop
arrowd added a comment to D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

@thomassc it is because I commandeered your revision to be able to update it. If you want, you do the same. First select "Commandeer Revision" at the bottom of this page, and then use arc diff (possibly with --update D18567) to update it.

Apr 6 2019, 12:33 PM · KDevelop
thomassc added a comment to D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

Thanks for the update. Seems good to me.

Apr 6 2019, 12:16 PM · KDevelop

Apr 5 2019

christiant updated the diff for D20142: DVCS Branch Manager with filtering and sorting proposal.

Work through feedback:

Apr 5 2019, 11:12 PM · KDevelop, VDG
arrowd updated the diff for D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

Simplify code.

Apr 5 2019, 12:56 PM · KDevelop
arrowd commandeered D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.
Apr 5 2019, 12:56 PM · KDevelop

Apr 4 2019

arrowd added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

After finishing initial implementation I found out that QtPromise requires exceptions enabled. KDevelop seem to have exceptions disabled right now.

Apr 4 2019, 6:36 PM · KDevelop

Apr 2 2019

christiant added a comment to D20142: DVCS Branch Manager with filtering and sorting proposal.

I will do that.

Apr 2 2019, 10:28 AM · KDevelop, VDG

Apr 1 2019

kfunk added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

As long as it integrates well with the rest of the KDevelop build I'm fine. Would probably just copy the QtPromise source tree into maybe kdevelop.git:3rdparty/ and create a CMakeLists.txt which creates a STATIC or OBJECT library for it? QtPromise looks easy enough to build.

Apr 1 2019, 5:44 PM · KDevelop
mwolff updated subscribers of D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

yes, QtPromise or AsyncFuture (https://github.com/benlau/asyncfuture) could be used - I wouldn't be opposed to introducing it as a thirdparty dependency (or git submodule)

Apr 1 2019, 4:43 PM · KDevelop
arrowd added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

KAsync looks a bit unmaintained. On the other hand, QtPromise seems to be an active project. Should I start looking into the latter?

Apr 1 2019, 12:06 PM · KDevelop
arrowd closed D14391: Fix random order of plugin's config pages.
Apr 1 2019, 11:29 AM · KDevelop
mwolff added a comment to D14391: Fix random order of plugin's config pages.

if it applies cleanly, you can also push to 5.3, otherwise master is fine - it's not a really urgent bug fix after all (imo)

Apr 1 2019, 11:02 AM · KDevelop
arrowd added a comment to D14391: Fix random order of plugin's config pages.

Onto master?

Apr 1 2019, 10:58 AM · KDevelop
mwolff accepted D14391: Fix random order of plugin's config pages.
Apr 1 2019, 10:46 AM · KDevelop
kfunk added inline comments to D20142: DVCS Branch Manager with filtering and sorting proposal.
Apr 1 2019, 6:39 AM · KDevelop, VDG

Mar 31 2019

apol added a comment to D20142: DVCS Branch Manager with filtering and sorting proposal.

Looks good to me overall, Let's clean it up so we can get it in.

Mar 31 2019, 2:47 PM · KDevelop, VDG
christiant added a comment to D20142: DVCS Branch Manager with filtering and sorting proposal.

How it looks.

Mar 31 2019, 11:02 AM · KDevelop, VDG
christiant requested review of D20142: DVCS Branch Manager with filtering and sorting proposal.
Mar 31 2019, 10:20 AM · KDevelop, VDG

Mar 29 2019

arrowd added a comment to D14391: Fix random order of plugin's config pages.

I don't remember details of this revision, but at least it seems to do like how we agreed.

Mar 29 2019, 1:06 PM · KDevelop
arrowd updated the diff for D14391: Fix random order of plugin's config pages.

Remove API changes and just sort plugins list.

Mar 29 2019, 1:05 PM · KDevelop

Mar 20 2019

mwolff closed D19673: Discovered unit-tests using bracket arguments and/or listed in files other than CTestTestFile.cmake.
Mar 20 2019, 6:34 PM · KDevelop

Mar 19 2019

sirgienko closed D19861: Fix some unused variable warnings.
Mar 19 2019, 9:43 PM · KDevelop
apol added a comment to D19861: Fix some unused variable warnings.

Of course, forgot to tell. Now we are in gitlab:
https://invent.kde.org/kde/kdevelop

Mar 19 2019, 9:38 PM · KDevelop
sirgienko added a comment to D19861: Fix some unused variable warnings.
In D19861#434135, @apol wrote:

Yes, sorry :)

Mar 19 2019, 1:43 PM · KDevelop

Mar 18 2019

apol added a comment to D19861: Fix some unused variable warnings.

Yes, sorry :)

Mar 18 2019, 11:22 PM · KDevelop
sirgienko added a comment to D19861: Fix some unused variable warnings.
In D19861#433859, @apol wrote:

Can you send the patch?

Mar 18 2019, 5:41 PM · KDevelop
apol accepted D19861: Fix some unused variable warnings.

Can you send the patch?

Mar 18 2019, 5:36 PM · KDevelop
sirgienko requested review of D19861: Fix some unused variable warnings.
Mar 18 2019, 5:28 PM · KDevelop

Mar 17 2019

rjvbb abandoned D17289: KDevelop/Shell: set dedicated TMPDIR.
Not really: it says that a temporary directory for every kdevelop instance is created
Mar 17 2019, 1:44 PM · KDevelop
lbeltrame added a comment to D17760: astyle: support the system astyle library.

Then the best should be to file a bug on bugzilla.opensuse.org asking for that to be packaged.

Mar 17 2019, 1:05 PM · KDevelop
pino added a comment to D17760: astyle: support the system astyle library.

Is this part of the astyle tarball, or a separate project?

Mar 17 2019, 1:02 PM · KDevelop
lbeltrame added a comment to D17760: astyle: support the system astyle library.

Is this part of the astyle tarball, or a separate project?

Mar 17 2019, 12:55 PM · KDevelop
pino added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

no need for making it "deterministic" in any way. There is no benefit in doing that.

I think there is so, it's the whole point of this PR.

Mar 17 2019, 11:56 AM · KDevelop
rjvbb added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

no need for making it "deterministic" in any way. There is no benefit in doing that.

Mar 17 2019, 11:37 AM · KDevelop
pino added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.
OK, I stand corrected on this. OTOH, the rest of my notes about this being wrong anyway still stand.

I'm not convinced about those arguments but have no objection either to making the temp dir user-exclusive - it's a detail that should be easy enough. There's probably a reason I'm not using QTemporaryDir though

Mar 17 2019, 11:24 AM · KDevelop
rjvbb added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.
OK, I stand corrected on this. OTOH, the rest of my notes about this being wrong anyway still stand.
Mar 17 2019, 11:01 AM · KDevelop
pino added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

using the user ID is definitely wrong here: with this change, opening a second kdevelop will erase the temporary directory of the first...

Maybe test-drive the patch (like I have been doing) before advancing hypotheses - don't you think I'd have noticed this kind of astronomically stupid error?
The tmp.dir name also includes the session ID, and you can only open a given session once.

Mar 17 2019, 10:29 AM · KDevelop
rjvbb added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

using the user ID is definitely wrong here: with this change, opening a second kdevelop will erase the temporary directory of the first...

Mar 17 2019, 10:22 AM · KDevelop
pino requested changes to D17289: KDevelop/Shell: set dedicated TMPDIR.
Mar 17 2019, 9:21 AM · KDevelop
pino updated subscribers of D17760: astyle: support the system astyle library.

Question: does any distro package that?

At least my openSUSE doesn't nor any other distro I know of, only thing I found was:

https://rpmfind.net/linux/rpm2html/search.php?query=libastyle-devel

I skimmed through https://repology.org/project/astyle/packages and found none.

Mar 17 2019, 8:58 AM · KDevelop
pino updated the diff for D17760: astyle: support the system astyle library.
  • add some rudimental version detection of the astyle library, since it provides no pkg-config file nor version macros/variables...
  • request libastyle >= 3.1
Mar 17 2019, 8:47 AM · KDevelop

Mar 15 2019

rjvbb added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

Milian Wolff wrote on 20190312::20:02:54 re: "D17289: KDevelop/Shell: set dedicated TMPDIR"

Mar 15 2019, 10:07 AM · KDevelop
tnorth added a comment to D19673: Discovered unit-tests using bracket arguments and/or listed in files other than CTestTestFile.cmake.

That's right, thanks a lot!

Mar 15 2019, 10:01 AM · KDevelop

Mar 14 2019

rjvbb added a comment to D18551: clang: Create preamble only on second parse.

Re: reparsing reliably each time a headerfile is changed: wouldn't the use of forwarding headers increase the chance of missing a change?

Mar 14 2019, 9:49 AM · KDevelop

Mar 13 2019

kfunk added a comment to D19673: Discovered unit-tests using bracket arguments and/or listed in files other than CTestTestFile.cmake.

Note: It's Thibault North <thibault.north@gmail.com>

Mar 13 2019, 4:13 PM · KDevelop