Feed Advanced Search

Today

kossebau added a comment to D23321: Indicate appsteam the ps desktop file isn't a separate application.
In D23321#516034, @apol wrote:

BUG: 410687

Wed, Aug 21, 3:25 PM · KDevelop
apol added a comment to D23321: Indicate appsteam the ps desktop file isn't a separate application.
In D23321#516020, @apol wrote:

Don't mention the ps desktop file as the executable

It was mentioned on purpose though, cmp. commit message of ab22ca659cf337fc1de01d69b0ced949156f01e5 (result of discussion on KDevelop with @flherne )

Wed, Aug 21, 3:25 PM · KDevelop
apol updated the diff for D23321: Indicate appsteam the ps desktop file isn't a separate application.

BUG: 410687

Wed, Aug 21, 3:23 PM · KDevelop
kossebau updated subscribers of D23321: Indicate appsteam the ps desktop file isn't a separate application.
Wed, Aug 21, 3:12 PM · KDevelop
kossebau added a comment to D23321: Indicate appsteam the ps desktop file isn't a separate application.
In D23321#516020, @apol wrote:

Don't mention the ps desktop file as the executable

Wed, Aug 21, 3:11 PM · KDevelop
apol updated the diff for D23321: Indicate appsteam the ps desktop file isn't a separate application.

Don't mention the ps desktop file as the executable

Wed, Aug 21, 3:09 PM · KDevelop
kossebau requested changes to D23321: Indicate appsteam the ps desktop file isn't a separate application.

From what I understood, this is effectless, as _ps is referenced by <launchable>. We need to check with @mak here.

Wed, Aug 21, 3:05 PM · KDevelop
ngraham updated the summary of D23321: Indicate appsteam the ps desktop file isn't a separate application.
Wed, Aug 21, 3:02 PM · KDevelop
ngraham accepted D23321: Indicate appsteam the ps desktop file isn't a separate application.

Yep, according to @mak, this should work.

Wed, Aug 21, 3:02 PM · KDevelop
apol requested review of D23321: Indicate appsteam the ps desktop file isn't a separate application.
Wed, Aug 21, 3:01 PM · KDevelop

Yesterday

akellermann requested review of D23303: gcclikecompiler: properly resolve include paths containing symbolic links .
Tue, Aug 20, 7:23 PM · KDevelop

Sun, Aug 18

aprcela abandoned D23212: [kdevelop] Remove 'Git Stashes' text above separator.
Sun, Aug 18, 10:08 AM · KDevelop
ngraham added a comment to D23212: [kdevelop] Remove 'Git Stashes' text above separator.

Great! You can Abandon this revision from the Add Action... menu above the comment field if you'd like (you can always re-open it later if need be).

Sun, Aug 18, 1:13 AM · KDevelop

Sat, Aug 17

aprcela added a comment to D23212: [kdevelop] Remove 'Git Stashes' text above separator.

result: Git Stashes is visually grouped with Branches... and is not clickable

What you're objecting do is actually just the way menu section headers look in the Breeze widget style. I agree that it causes confusion and visual problems, but it should be fixed there, not here in KDevelop.

Here's the applicable Breeze code that draws these headers https://cgit.kde.org/breeze.git/tree/kstyle/breezestyle.cpp#n4741

Would you like to have a go at improving it there?

Sat, Aug 17, 8:52 PM · KDevelop
ngraham added a comment to D23212: [kdevelop] Remove 'Git Stashes' text above separator.

result: Git Stashes is visually grouped with Branches... and is not clickable

Sat, Aug 17, 7:41 PM · KDevelop
ngraham added a reviewer for D23212: [kdevelop] Remove 'Git Stashes' text above separator: KDevelop.
Sat, Aug 17, 7:36 PM · KDevelop
kossebau created T11415: Entry for QCH documentation files (for KDevelop & more in the future).
Sat, Aug 17, 5:08 PM · KDevelop, KDE Store
aprcela retitled D23212: [kdevelop] Remove 'Git Stashes' text above separator from Remove 'Git Stashes' text above separator to [kdevelop] Remove 'Git Stashes' text above separator.
Sat, Aug 17, 10:32 AM · KDevelop
aprcela updated the test plan for D23212: [kdevelop] Remove 'Git Stashes' text above separator.
Sat, Aug 17, 10:29 AM · KDevelop
aprcela requested review of D23212: [kdevelop] Remove 'Git Stashes' text above separator.
Sat, Aug 17, 10:28 AM · KDevelop

Wed, Aug 14

christiant added a comment to D22978: Toggle filtering of remote branches in DVCS Branch Manager.

I will look into it next week. The used icon is bogus. I was hoping for some input on that :) But i liked the idea of an icon in general.

Wed, Aug 14, 5:29 PM · KDevelop

Mon, Aug 12

apol added a comment to D22978: Toggle filtering of remote branches in DVCS Branch Manager.

Maybe it would make sense to move the whole dialog into git plugin's code.

Mon, Aug 12, 11:24 AM · KDevelop

Sun, Aug 11

pavelp added a comment to D23038: Fix compilation with Kdevelop 5.4.

@pavelp Hi from a more recent contributor to KDevelop, good to see you back again once more and care for your former work :)

Hi, thank you, I'm happy to be back!

Sun, Aug 11, 9:42 PM · KDevelop
pavelp closed D23038: Fix compilation with Kdevelop 5.4.
Sun, Aug 11, 9:34 PM · KDevelop
kossebau added a comment to D23038: Fix compilation with Kdevelop 5.4.

@pavelp Hi from a more recent contributor to KDevelop, good to see you back again once more and care for your former work :)

Sun, Aug 11, 2:08 PM · KDevelop

Fri, Aug 9

pavelp added a reviewer for D23038: Fix compilation with Kdevelop 5.4: KDevelop.
Fri, Aug 9, 6:08 AM · KDevelop
pavelp requested review of D23038: Fix compilation with Kdevelop 5.4.
Fri, Aug 9, 6:03 AM · KDevelop

Tue, Aug 6

christiant added a comment to D22978: Toggle filtering of remote branches in DVCS Branch Manager.

I created some screenshots. Icon ist in the line edit (near the mouse pointer in the first picture).

Tue, Aug 6, 10:09 PM · KDevelop
christiant added a comment to D22978: Toggle filtering of remote branches in DVCS Branch Manager.

I hope it is ok to add you as reviewer directly as you orchestrated the last commit from me in this area.

Tue, Aug 6, 10:01 PM · KDevelop
christiant requested review of D22978: Toggle filtering of remote branches in DVCS Branch Manager.
Tue, Aug 6, 9:58 PM · KDevelop

Fri, Aug 2

tristanp added inline comments to D22158: Navigation context uses theme color..
Fri, Aug 2, 6:57 PM · KDevelop
tristanp added inline comments to D20548: Fix document switcher plugin with multiple splitted view..
Fri, Aug 2, 6:54 PM · KDevelop

Wed, Jul 31

kossebau added a reviewer for D22660: Fixed crash when filtering class list: KDevelop.
Wed, Jul 31, 12:40 PM · KDevelop
mdlubakowski requested review of D22854: Added support for configurable font styles for syntax highlighting.
Wed, Jul 31, 11:46 AM · KDevelop

Fri, Jul 26

mswan added a comment to D22182: Remove anchorClicked lock which causes deadlock.

I have been mega busy for the last while and intend to contribute more to this project when my situation stabilizes in like two weeks. Whenever you have time, I would definitely be interested to hear what sort of challenges you have come across through experimentation. An issue which I have suspected from the onset is actually determining all that needs to be protected by DUChain's lock and those which don't since KDevelop source makes use of these locks so liberally. I'm wondering if in your experimentation there are open questions about the DUChain locking scope.

Fri, Jul 26, 7:44 PM · KDevelop

Thu, Jul 25

kossebau added a comment to D22455: Fix code completion for nameless structs/unions with the same member.

Work-around pushed as 8a18a08cf17c85000c7082d5192855430a519bab , seems to pass build also with neon ci and the gcc 7.4.0 there.

Thu, Jul 25, 12:45 PM · KDevelop

Wed, Jul 24

kossebau added a comment to D22455: Fix code completion for nameless structs/unions with the same member.

Seems the introduced QStringLiteral as default argument here in the template method executeCompletionTest() makes ubuntu bionic's GNU 7.4.0 C++ compiler screw up. At least there is some timely coincidence that the KDevelop builds on neon CI started to fail after this commit, with this error:

05:00:37 [100%] Building CXX object plugins/clang/tests/CMakeFiles/test_codecompletion.dir/test_codecompletion.cpp.o
05:00:37 plugins/clang/tests/CMakeFiles/test_codecompletion.dir/build.make:62: recipe for target 'plugins/clang/tests/CMakeFiles/test_codecompletion.dir/test_codecompletion.cpp.o' failed
05:00:37 make[4]: Leaving directory '/workspace/build/obj-x86_64-linux-gnu'
05:00:37 /tmp/ccrWtnBp.s: Assembler messages:
05:00:37 /tmp/ccrWtnBp.s:65174: Error: symbol `_ZZNK12_GLOBAL__N_1UlvE_clEvE15qstring_literal' is already defined
05:00:37 /tmp/ccrWtnBp.s:68144: Error: symbol `_ZZNK12_GLOBAL__N_1UlvE_clEvE15qstring_literal' is already defined
05:00:37 make[4]: *** [plugins/clang/tests/CMakeFiles/test_codecompletion.dir/test_codecompletion.cpp.o] Error 1
05:00:37 CMakeFiles/Makefile2:18121: recipe for target 'plugins/clang/tests/CMakeFiles/test_codecompletion.dir/all' failed
05:00:37 make[3]: *** [plugins/clang/tests/CMakeFiles/test_codecompletion.dir/all] Error 2

from https://build.neon.kde.org/job/bionic_unstable_extras_kdevelop_bin_amd64/220/console

Wed, Jul 24, 2:01 PM · KDevelop

Mon, Jul 22

mdlubakowski requested review of D22660: Fixed crash when filtering class list.
Mon, Jul 22, 6:25 PM · KDevelop

Jul 21 2019

kossebau abandoned D22559: Bump min dep versions of Qt & KF to 5.9 & 5.44.

I do not think bumping versions "just because " has any value.

I kind of agree here. Unless we have features that we know are only available with a certain version, we might needlessly restrict how people can build this. They might assume we have a good reason for choosing that specific version and that older versions can't possibly work. When I package stuff for openSUSE, I would never try decreasing minimum versions of dependencies, because I assume that these are actually the minimum. On the other hand, I regularly stumble across software that doesn't specify minimum versions for dependencies, but assumes it's "reasonably recent".

Jul 21 2019, 12:13 PM · KDevelop

Jul 20 2019

aaronpuchert added a comment to D22182: Remove anchorClicked lock which causes deadlock.

Also, in spite of what I said earlier, I think the explicit DUChain locking should be done and there eventually should be some work done to determine which objects will only interact with one specific DUChain per instance of that object, i.e. an object that should reference a specific DUChain, e.g. ClangSupport. We could make the first pass at this involve replacing all of those DUChainReadLocker lock; lines with DUChainReaderLocker lock(DUChain::lock());, [...]

Jul 20 2019, 8:22 PM · KDevelop
aaronpuchert added a comment to D22217: Pass extra build flags to compiler for parsing..

Overall I think this is a good idea, although we need to figure out some details. Could you either remove commented out flags or add a comment why we have them (commented out)?

Jul 20 2019, 8:18 PM · KDevelop
aaronpuchert closed D22197: Add working directory to clang parser..
Jul 20 2019, 7:37 PM · KDevelop
aaronpuchert added a comment to D22182: Remove anchorClicked lock which causes deadlock.

I don't know what would be required to support multiple DUChains, but it seems plausible that they can be locked separately. In this case it would help to have the explicit argument, I guess. It could even be inevitable, when there is no single global DUChain anymore.

Jul 20 2019, 7:28 PM · KDevelop
aaronpuchert added a comment to D22559: Bump min dep versions of Qt & KF to 5.9 & 5.44.

I do not think bumping versions "just because " has any value.

Jul 20 2019, 1:06 PM · KDevelop
apol added a comment to D22566: Add basic support for CXType_ExtVector..

Can we have a test for this?

Jul 20 2019, 9:28 AM · KDevelop
rjvbb added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.
There is another condition here: `if (lastShownMenu)`. So if the QMenu object instance got deleted
Jul 20 2019, 9:27 AM · KDevelop

Jul 19 2019

bungeman updated the diff for D22217: Pass extra build flags to compiler for parsing..

Add rtti flags since they affect defines.

Jul 19 2019, 10:19 PM · KDevelop
bungeman updated the diff for D22566: Add basic support for CXType_ExtVector..

Prefer not duplicating code.

Jul 19 2019, 8:25 PM · KDevelop
bungeman updated the summary of D22566: Add basic support for CXType_ExtVector..
Jul 19 2019, 8:04 PM · KDevelop
bungeman updated the diff for D22566: Add basic support for CXType_ExtVector..

Just do the simple thing. Copied the one line of code due to
the awkwardness of preprocessor directives inside template lists.

Jul 19 2019, 7:55 PM · KDevelop
bungeman added a reviewer for D22566: Add basic support for CXType_ExtVector.: KDevelop.
Jul 19 2019, 7:34 PM · KDevelop
bungeman requested review of D22566: Add basic support for CXType_ExtVector..
Jul 19 2019, 7:32 PM · KDevelop
buschinski closed D22455: Fix code completion for nameless structs/unions with the same member.
Jul 19 2019, 5:21 PM · KDevelop
flherne accepted D22559: Bump min dep versions of Qt & KF to 5.9 & 5.44.

As the person who raised the Debian Stretch issue last time, I don't think it's worth caring about now that Buster is released.

Jul 19 2019, 4:52 PM · KDevelop
buschinski updated the summary of D22455: Fix code completion for nameless structs/unions with the same member.
Jul 19 2019, 4:16 PM · KDevelop
kfunk accepted D22559: Bump min dep versions of Qt & KF to 5.9 & 5.44.

Sorry for my conservative thinking again: Debian Buster (10) is still /very/ fresh; it was just released a couple days ago. The former "oldest" supported distro was Debian Stretch (9) with Qt 5.7 and KF 5.28. That'll stick around for some time.

Jul 19 2019, 3:12 PM · KDevelop
kossebau added a comment to D22559: Bump min dep versions of Qt & KF to 5.9 & 5.44.

(Using phabricator to make sure people are triggered for this central change)

Jul 19 2019, 12:45 PM · KDevelop
kossebau requested review of D22559: Bump min dep versions of Qt & KF to 5.9 & 5.44.
Jul 19 2019, 12:44 PM · KDevelop

Jul 18 2019

kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

I'll activate the debug trace on change of my lastShownMenu though

I'm doing this (in my patch from D16882 which still applies after reverting D22424):

+        if (menu != lastShownMenu.data()) {
+            if (lastShownMenu) {
+                qCWarning(SHELL) << "Added items to new contextmenu" << menu;
+            }
+            lastShownMenu = menu;
+        }

under the assumption that this will print a warning (enabled in qtlogging.ini) when lastShownMenu will be updated but not the 1st time a ctx menu is opened. Is that assumption wrong, because I'm not seeing any warnings after disabling the CTags menu (and restarting KDevelop for good measure).

Jul 18 2019, 3:52 PM · KDevelop
rjvbb added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

I'll activate the debug trace on change of my lastShownMenu though

Jul 18 2019, 3:26 PM · KDevelop
rjvbb added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

In any case there isn't much else you can do; stepping through the code with a debugger is near impossible (the menu about-to-be-opened will already have grabbed mouse and keyboard focus so you'd need to display remotely).

Jul 18 2019, 1:36 PM · KDevelop
kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

How do you think I debugged the situation? I did the same thing in Kate too.

Jul 18 2019, 1:23 PM · KDevelop
rjvbb added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.
Please add a line

  qDebug() << "Showing context menu" << menu;

to KDevelop::TextDocument::populateContextMenu.
Jul 18 2019, 1:12 PM · KDevelop
kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

Since we're dealing with "please read/see again": idem for my comment :P which only states that a single QMenu instance is being (re)used. I've never seen it change

Jul 18 2019, 12:38 PM · KDevelop
rjvbb added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.
>>   > FWIW I got to look at the KTE implementation of the context menu mechanism that is used here. It indeed uses and reuses a single QMenu instance (there's even a comment in the code about that).
>>   
>>   Please give links into the code, as I am lost what you exactly refer to here.
> 
> see the source of `KTextEditor::ViewPrivate::contextMenu()`. The ctx menu is in fact managed by KXMLGUI.

The context menu is queried every time from KXMLGUI that method is called.  So  if KXMLGUI internally decides to recreate the context menu, you get another object the next time. Please see again the description of this very bug.
Jul 18 2019, 12:11 PM · KDevelop
kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.
The other option would have been to release 5.3.3 without a fix for ctags plugin users, rendering it unusable for people relying on packaged kdevelop.

Erm, aren't you forgetting about my patch which could have been applied to the (EOL!) 5.3 branch? That does the job just as well and would have left time to find a fix for #409858 in time for the next release.

Jul 18 2019, 11:18 AM · KDevelop
rjvbb added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.
The other option would have been to release 5.3.3 without a fix for ctags plugin users, rendering it unusable for people relying on packaged kdevelop.
Jul 18 2019, 11:09 AM · KDevelop
kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

Friedrich W. H. Kossebau wrote on 20190717::00:12:44 re: "D22424: TextDocument: remove actions from contextmenu on hide already"

This revision was not accepted when it landed; it landed in state "Needs Review".

Hmm, since when is this acceptable?

Jul 18 2019, 10:43 AM · KDevelop
rjvbb added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

Friedrich W. H. Kossebau wrote on 20190717::00:12:44 re: "D22424: TextDocument: remove actions from contextmenu on hide already"

Jul 18 2019, 9:01 AM · KDevelop

Jul 17 2019

kossebau closed D22424: TextDocument: remove actions from contextmenu on hide already.
Jul 17 2019, 12:12 AM · KDevelop
kossebau updated the summary of D22424: TextDocument: remove actions from contextmenu on hide already.
Jul 17 2019, 12:00 AM · KDevelop

Jul 16 2019

kossebau added a comment to D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.

I could try your solution, of course, but what annoys me is that it comes months after I worked on mine.

Jul 16 2019, 11:19 PM · KDevelop
kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

However, the patch has a side-effect: I'm getting messages like this each time I switch or open documents:

kdevplatform.shell: Broken text-document:  QUrl("file:///opt/local/var/tmp/kdevelop-tmp-505-%7Bf793a513-f14e-47b9-8448-06ca72900c04%7D/kdevelop_Q27955.patch")

This example is for a file that indeed doesn't exist, but that I also do not have open (so WTH?!) but I also get it for files that open perfectly.

I fail to see an immediate reason for this, so I'm back to running my own patch.

Interesting. Not seen here, but giving this some stress testing now. The kdevelop_xxxxx.patch is coming from the diff review system creating text document objects for displaying the diffs, but I also see no direct relation ship to this patch here. Will poke around a bit,

Jul 16 2019, 2:12 PM · KDevelop
apol closed D22456: Show session name in the Delete Session confirmation dialog.
Jul 16 2019, 11:49 AM · KDevelop
rjvbb added inline comments to D22424: TextDocument: remove actions from contextmenu on hide already.
Jul 16 2019, 8:33 AM · KDevelop

Jul 15 2019

kossebau updated the diff for D22424: TextDocument: remove actions from contextmenu on hide already.

update to first review feedback

Jul 15 2019, 9:33 PM · KDevelop
kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

Thanks for first review & testing.

Jul 15 2019, 9:33 PM · KDevelop
mdlubakowski added a comment to D22456: Show session name in the Delete Session confirmation dialog.
In D22456#496025, @apol wrote:

LGTM can you land it?

Jul 15 2019, 7:33 PM · KDevelop
apol accepted D22456: Show session name in the Delete Session confirmation dialog.

LGTM can you land it?

Jul 15 2019, 6:41 PM · KDevelop
mswan added a comment to D22182: Remove anchorClicked lock which causes deadlock.

Okay, that all makes sense to me. Also, in spite of what I said earlier, I think the explicit DUChain locking should be done and there eventually should be some work done to determine which objects will only interact with one specific DUChain per instance of that object, i.e. an object that should reference a specific DUChain, e.g. ClangSupport. We could make the first pass at this involve replacing all of those DUChainReadLocker lock; lines with DUChainReaderLocker lock(DUChain::lock());, but ideally we would eventually come to some understanding about which objects are instantiated within a specific DUChain context such that multiple instances can coexist with entirely independent DUChain interactions. The eventual use case for this is something like T11223 which at this point has so very many unknowns that it would be difficult to start tailoring changes like proposed here to that end. At this stage with the desired changes loosely described above, I am inclined to think that there needs to be some explicitly stated semantics of DUChain::lock(), i.e. it locks all DUChain instances. If we eventually start adding support for multiple DUChain instances we would at least not have to worry about any of these existing locks being overly permissive given the suggested default semantics. I don't know if anything I have just said changes anything about how we would go about applying Clang Thread Safety annotations to this project, but I suspect that it does. Thoughts?

Jul 15 2019, 2:00 PM · KDevelop
mswan updated the task description for T11223: Option to support target-specific DUChain.
Jul 15 2019, 1:45 PM · KDevelop
mswan updated the task description for T11223: Option to support target-specific DUChain.
Jul 15 2019, 1:32 PM · KDevelop
mswan triaged T11224: Build target context view as Wishlist priority.
Jul 15 2019, 1:19 PM · KDevelop
mswan updated the task description for T11223: Option to support target-specific DUChain.
Jul 15 2019, 1:07 PM · KDevelop
mswan triaged T11223: Option to support target-specific DUChain as Wishlist priority.
Jul 15 2019, 12:58 PM · KDevelop
mdlubakowski updated the diff for D22456: Show session name in the Delete Session confirmation dialog.
  • Added missing header for column with session name
Jul 15 2019, 5:25 AM · KDevelop
apol added a comment to D22456: Show session name in the Delete Session confirmation dialog.

LGTM otherwise

Jul 15 2019, 1:16 AM · KDevelop
apol accepted D22455: Fix code completion for nameless structs/unions with the same member.
Jul 15 2019, 1:14 AM · KDevelop

Jul 14 2019

mdlubakowski added a reviewer for D22456: Show session name in the Delete Session confirmation dialog: KDevelop.
Jul 14 2019, 5:09 PM · KDevelop
mdlubakowski retitled D22456: Show session name in the Delete Session confirmation dialog from Show session name in the Delete Session confimration dialog to Show session name in the Delete Session confirmation dialog.
Jul 14 2019, 5:07 PM · KDevelop
mdlubakowski requested review of D22456: Show session name in the Delete Session confirmation dialog.
Jul 14 2019, 5:04 PM · KDevelop
buschinski requested review of D22455: Fix code completion for nameless structs/unions with the same member.
Jul 14 2019, 2:43 PM · KDevelop

Jul 13 2019

davidre updated the task description for T11221: Grepview - Group matches by line.
Jul 13 2019, 7:06 PM · KDevelop
davidre created T11221: Grepview - Group matches by line.
Jul 13 2019, 7:04 PM · KDevelop
rjvbb added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

I've tested this in the 5.3 branch now, which required applying hunk #3 manually to texteditor.cpp .

Jul 13 2019, 3:36 PM · KDevelop
rjvbb added inline comments to D22424: TextDocument: remove actions from contextmenu on hide already.
Jul 13 2019, 1:11 PM · KDevelop
anthonyfieroni added inline comments to D22424: TextDocument: remove actions from contextmenu on hide already.
Jul 13 2019, 10:59 AM · KDevelop
rjvbb added a comment to D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.

I could try your solution, of course, but what annoys me is that it comes months after I worked on mine. I currently have too many other things going on in my life to dive in and figure out what on earth was going on again. I do think I outlined it well enough above in the initial description and/or exchange; I should find a moment this weekend to sit down and re-read it with a fresh mind.
It would help if you had a specific critique on my solution other than "it doesn't use this or that signal" (or, what I kind of sense, "it comes from you"). No disrespect intended, but your description in D22424 isn't that easy to read either (it felt like reading German, for some inexplicable reason ;) ).

Jul 13 2019, 9:51 AM · KDevelop
rjvbb added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

Just a few remarks on the comments that should make them easier to understand (a priori comments should illustrate code and not require lots of different code the understand their meaning ;))

Jul 13 2019, 9:51 AM · KDevelop

Jul 12 2019

kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

Reasons why currently I favour this over D16882:

  • slightly less complex, as it does more what one expects, adding & removing actions on show & hide
  • no global static
Jul 12 2019, 4:21 PM · KDevelop