Differential D26294

Allow to load widget based KCMs from kcms subdir
Needs ReviewPublic
Actions

Authored by volkov on Dec 30 2019, 4:22 PM.

Details

Reviewers
None
Group Reviewers
Frameworks

Diff Detail

Repository
R295 KCMUtils
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20408
Build 20426: arc lint + arc unit
volkov created this revision.Dec 30 2019, 4:22 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 30 2019, 4:22 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
volkov requested review of this revision.Dec 30 2019, 4:22 PM
volkov updated this revision to Diff 72393.Dec 30 2019, 4:24 PM

change branch

apol added a subscriber: apol.Dec 31 2019, 6:34 PM

It would be useful if you were a bit more explicit about how you tested it on the commit message.

src/kcmoduleloader.cpp
103

I see that cm is initialized with a nullptr parent. Why's it different here?

apol removed a subscriber: apol.Dec 31 2019, 6:34 PM
apol added a subscriber: apol.

Revision Contents
Changeset List

PathPackages
Msrc/kcmoduleloader.cpp (4 lines)

Diff 72393

View Options

src/kcmoduleloader.cpp

Loading...