marten (Jonathan Marten)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 20 2016, 1:07 PM (193 w, 4 d)
Availability
Available

Recent Activity

Thu, Nov 7

marten updated the diff for D25186: Update internal printer enabled/paused state if it changes externally.

Actually everything appears to still work if isPaused is handled entirely declaratively.

Thu, Nov 7, 1:48 PM
marten updated the diff for D25186: Update internal printer enabled/paused state if it changes externally.

Yes, that seems to work (and simplifies the code a bit).

Thu, Nov 7, 1:38 PM
marten requested review of D25186: Update internal printer enabled/paused state if it changes externally.
Thu, Nov 7, 8:46 AM

Nov 5 2019

marten committed R883:1555258: Kooka en_GB: New translations for OCR and TIFF.
Kooka en_GB: New translations for OCR and TIFF
Nov 5 2019, 9:34 AM

Nov 4 2019

marten committed R660:c2ba68ee5329: Pass KookaImage to OCR by reference, to avoid generating a copy (authored by marten).
Pass KookaImage to OCR by reference, to avoid generating a copy
Nov 4 2019, 11:41 AM
marten committed R660:38f900e40371: Extract I18N messages for plugins (into 'kooka.po') (authored by marten).
Extract I18N messages for plugins (into 'kooka.po')
Nov 4 2019, 10:22 AM

Nov 3 2019

marten committed R660:466112401f1e: DialogStateSaver: Ensure that the window is valid before getting its screen (authored by marten).
DialogStateSaver: Ensure that the window is valid before getting its screen
Nov 3 2019, 3:24 PM

Oct 28 2019

marten committed R660:6552508665a2: Port deprecated QSignalMapper -> lambda connection (authored by marten).
Port deprecated QSignalMapper -> lambda connection
Oct 28 2019, 5:02 PM
marten committed R660:7a9cd518a897: Port deprecated QFontMetrics::width -> horizontalAdvance (authored by marten).
Port deprecated QFontMetrics::width -> horizontalAdvance
Oct 28 2019, 5:02 PM
marten committed R660:965b6f725b6b: Port deprecated qSort -> std::sort (authored by marten).
Port deprecated qSort -> std::sort
Oct 28 2019, 3:49 PM
marten committed R660:2f0188330fef: DialogStateSaver: Port deprecated QDesktopWidget -> QScreen (authored by marten).
DialogStateSaver: Port deprecated QDesktopWidget -> QScreen
Oct 28 2019, 3:49 PM
marten committed R660:8358e0c6ae05: Eliminate remaining 'zero as null pointer constant' warnings (authored by marten).
Eliminate remaining 'zero as null pointer constant' warnings
Oct 28 2019, 3:26 PM
marten committed R660:7de2240fe637: Port NULL -> nullptr (authored by marten).
Port NULL -> nullptr
Oct 28 2019, 3:26 PM
marten committed R660:4ac982cf916b: Port deprecated QString::null -> QString() (authored by kpiwowarski).
Port deprecated QString::null -> QString()
Oct 28 2019, 2:49 PM
marten closed D24579: Use QString() instead of deprecated QString::null.
Oct 28 2019, 2:49 PM

Oct 21 2019

marten committed R226:8e3c193d04f3: WebEnginePart: Do not prompt as if a new tab were a popup (authored by marten).
WebEnginePart: Do not prompt as if a new tab were a popup
Oct 21 2019, 1:47 PM
marten closed D24195: WebEnginePart: A new tab requested by user is not a popup.
Oct 21 2019, 1:47 PM

Oct 17 2019

marten updated the diff for D24195: WebEnginePart: A new tab requested by user is not a popup.

Updated in accordance with review comments, variable names corresponding to what they actually do.

Oct 17 2019, 1:24 PM

Oct 15 2019

marten added inline comments to D24195: WebEnginePart: A new tab requested by user is not a popup.
Oct 15 2019, 10:40 AM
marten updated the diff for D24195: WebEnginePart: A new tab requested by user is not a popup.

If you mean to incorporate the tests directly into actionRequestedByUser:

Oct 15 2019, 10:39 AM

Oct 11 2019

marten added a reviewer for D24195: WebEnginePart: A new tab requested by user is not a popup: dfaure.
Oct 11 2019, 8:14 PM

Oct 7 2019

marten committed R226:a009fde4e40b: SessionRestoreDialog: Fix showing of "dialog-warning" icon (authored by marten).
SessionRestoreDialog: Fix showing of "dialog-warning" icon
Oct 7 2019, 9:02 AM

Sep 24 2019

marten requested review of D24195: WebEnginePart: A new tab requested by user is not a popup.
Sep 24 2019, 2:29 PM

Sep 23 2019

marten added a comment to M155: KMail revamped.

I'm not convinced that trying to show a reading time is that useful. Estimating this will need to take so much into account - it seems easy to divide the length of the message by the user's personal reading speed, but getting an accurate estimate will also depend on the amount of original (non-quoted and non-signature) text, the variation in reading speed between individual messages (junk can be dismissed with just a glance, a party invite may just be skimmed for a date/time, while a technical discussion will have to be read in detail, etc) that an estimate algorithm would need to be trained on a great number of messages before getting anywhere near a realistic result. If the time shown bears no relation to reality then the user will learn to ignore it and there is no point in showing it.

Sep 23 2019, 2:57 PM

Sep 22 2019

marten added a comment to M155: KMail revamped.

Good idea to have the button, but maybe it should be placed in the header area instead of the body of the message for security reasons (so that it cannot be spoofed by a malicious HTML message).

Sep 22 2019, 11:25 AM

Sep 17 2019

marten committed R120:eed2d620cbd5: Consistent virtual desktop numbering between Switch Window popup and taskbar (authored by marten).
Consistent virtual desktop numbering between Switch Window popup and taskbar
Sep 17 2019, 6:32 AM
marten closed D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar.
Sep 17 2019, 6:32 AM · Plasma

Sep 15 2019

marten updated the diff for D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar.

Ignore the desktop ID and simply use the loop index, adjusted so that the desktop numbers start at 1. This is the same formatting as used by KWin (kwin/useractions.cpp) and the Task Manager applet (plasma-desktop/applets/taskmanager/package/contents/ui/ContextMenu.qml). This should work as intended on both X11 and Wayland.

Sep 15 2019, 4:37 PM · Plasma

Sep 9 2019

marten accepted D22816: Get rid of dependency on KIconThemes.
Sep 9 2019, 6:57 PM
marten added a comment to D22816: Get rid of dependency on KIconThemes.

Thanks for the fix - a much better solution to the HiDPI support.

Sep 9 2019, 6:57 PM
marten accepted D22825: Fix shrinking of group boxes' titles.

Thanks for the fix!

Sep 9 2019, 6:55 PM

Aug 18 2019

marten planned changes to D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar.

@GB_2 thanks for testing; a desktop UUID is obviously not friendly to show to the user, so there needs to be some sort of X11/Wayland runtime check here.

Aug 18 2019, 8:47 AM · Plasma

Aug 17 2019

marten added a comment to D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar.

So does this fully fix 410190, or only partially?

Aug 17 2019, 11:03 AM · Plasma

Jul 29 2019

marten accepted D22808: Add support for High DPI.
Jul 29 2019, 3:54 PM
marten accepted D22806: Make dependency on Plasma optional.

Good idea to reduce required dependencies, many thanks.

Jul 29 2019, 1:10 PM

Jul 25 2019

marten requested review of D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar.
Jul 25 2019, 3:17 PM · Plasma
marten committed R883:1547556: Spectacle en_GB: Fix plural of "seconds" delay time suffix.
Spectacle en_GB: Fix plural of "seconds" delay time suffix
Jul 25 2019, 9:53 AM

Jul 20 2019

marten abandoned D7820: man ioslave: spurious numbers included in clang(1) man page.
Jul 20 2019, 4:09 PM · Frameworks, Dolphin, Plasma

Jul 11 2019

marten added a comment to D7820: man ioslave: spurious numbers included in clang(1) man page.

Confirmed that man:clang(1) now correctly displays the man page with no spurious numbers shown. Would be happy to abandon this review request.

Jul 11 2019, 7:52 AM · Frameworks, Dolphin, Plasma

Jul 10 2019

marten added a comment to D22352: Add option --raw for the show command..

Good point regarding the possibility of decoding other formats.

Jul 10 2019, 10:00 AM

Jul 9 2019

marten added inline comments to D22352: Add option --raw for the show command..
Jul 9 2019, 9:22 PM

Jun 27 2019

marten committed R660:c30a09b18b6d: Use pkg-config(1) to find SANE (authored by marten).
Use pkg-config(1) to find SANE
Jun 27 2019, 12:40 PM

Jun 19 2019

marten committed R44:57716edd29b7: Option and GUI to use the system proxy settings for IMAP connection (authored by marten).
Option and GUI to use the system proxy settings for IMAP connection
Jun 19 2019, 7:03 AM
marten closed D21464: IMAP: Option to use system proxy settings (Configuration and GUI).
Jun 19 2019, 7:03 AM · KDE PIM
marten committed R177:544bae2f88f3: Provide an option wheether to use the system proxy settings (authored by marten).
Provide an option wheether to use the system proxy settings
Jun 19 2019, 6:27 AM
marten closed D21463: KIMAP: Option to use system proxy settings (Core part).
Jun 19 2019, 6:27 AM · KDE PIM

Jun 15 2019

marten added a comment to D21463: KIMAP: Option to use system proxy settings (Core part).

@mlaurent, are you also happy to accept this revision?

Jun 15 2019, 7:36 PM · KDE PIM

Jun 3 2019

marten updated the diff for D21463: KIMAP: Option to use system proxy settings (Core part).

New function setUseProxyInternal() to set proxy state and, if the connection is active, disconnect and reconnect it with the new proxy setting.

Jun 3 2019, 4:05 PM · KDE PIM

May 31 2019

marten requested review of D21516: Variables for column/row are switched for Profile - Initial Terminal Size.
May 31 2019, 7:12 PM · Konsole
marten added inline comments to D21463: KIMAP: Option to use system proxy settings (Core part).
May 31 2019, 3:33 PM · KDE PIM
marten updated the diff for D21463: KIMAP: Option to use system proxy settings (Core part).

Diff updated in accordance with review comments

May 31 2019, 3:27 PM · KDE PIM
marten updated the diff for D21464: IMAP: Option to use system proxy settings (Configuration and GUI).

Tab converted to spaces

May 31 2019, 3:04 PM · KDE PIM

May 30 2019

marten committed R883:1542968: Konsole en-GB: Fix "columns" plural suffix.
Konsole en-GB: Fix "columns" plural suffix
May 30 2019, 4:57 PM

May 29 2019

marten updated the diff for D21464: IMAP: Option to use system proxy settings (Configuration and GUI).

KIMAP required version updated

May 29 2019, 8:43 AM · KDE PIM
marten updated the diff for D21463: KIMAP: Option to use system proxy settings (Core part).

Version number updated

May 29 2019, 8:24 AM · KDE PIM

May 28 2019

marten added a comment to D21463: KIMAP: Option to use system proxy settings (Core part).

Laurent, do you mean the PIM_VERSION in kimap/CMakeLists.txt (which then sets KIMAP_LIB_VERSION), currently "5.11.40"? I was under the impression that this was managed by the release scripts and all PIM components had to have the same version.
I assume that you don't mean the SOVERSION of the kimap library (which doesn't have a minor version).

May 28 2019, 7:02 PM · KDE PIM
marten updated the summary of D21464: IMAP: Option to use system proxy settings (Configuration and GUI).
May 28 2019, 3:44 PM · KDE PIM
marten committed R660:cd9ffb187cf0: OCR configuration: Spelling fixes and missing window title (authored by marten).
OCR configuration: Spelling fixes and missing window title
May 28 2019, 3:44 PM
marten committed R660:12add7eb4f53: ImageTransform: Pass QString parameter by const reference (authored by marten).
ImageTransform: Pass QString parameter by const reference
May 28 2019, 3:44 PM
marten updated the summary of D21464: IMAP: Option to use system proxy settings (Configuration and GUI).
May 28 2019, 3:44 PM · KDE PIM
marten requested review of D21464: IMAP: Option to use system proxy settings (Configuration and GUI).
May 28 2019, 3:43 PM · KDE PIM
marten requested review of D21463: KIMAP: Option to use system proxy settings (Core part).
May 28 2019, 3:39 PM · KDE PIM

May 25 2019

marten committed R733:124cd14e7054: Comment fix, setUseProxy() should be setUseNetworkProxy() (authored by marten).
Comment fix, setUseProxy() should be setUseNetworkProxy()
May 25 2019, 11:59 AM

May 19 2019

marten committed R883:1542117: en-GB Akonadi IMAP resource: IMprove wording of ManageSieve message.
en-GB Akonadi IMAP resource: IMprove wording of ManageSieve message
May 19 2019, 5:08 PM

May 18 2019

marten added a comment to T7430: POP3,SMTP protocols should not use proxy.

See https://bugs.kde.org/show_bug.cgi?id=407685 for IMAP.

May 18 2019, 5:43 PM · KDE PIM

May 4 2019

marten abandoned D19332: KProcess compile fix for obsolete QProcess members in 5.13.

Appears to have been already implemented by https://phabricator.kde.org/R244:b2b873d612a018d33866ddfd497f87bb7dd79573

May 4 2019, 8:50 PM · Frameworks
marten requested review of D21015: Need to set VLC audio device after setting media source.
May 4 2019, 12:34 PM

May 2 2019

marten added a comment to T9431: [Akonadi CLI] Revive and extend the akonadiclient tool.

The tool is up to date and working as far as I am aware, but any bug reports or suggestions for additions would of course be welcome.

May 2 2019, 1:35 PM · KDE PIM: Junior Jobs, MyCroft Integration, KDE PIM

Mar 27 2019

marten closed D20075: AttachmentUpdateJob needs to be exported even without BUILD_TESTING.
Mar 27 2019, 12:38 PM · KDE PIM
marten committed R94:23446e9e0190: AttachmentUpdateJob needs to be exported even without BUILD_TESTING (authored by marten).
AttachmentUpdateJob needs to be exported even without BUILD_TESTING
Mar 27 2019, 12:38 PM
marten committed R320:1b56cc62c93d: kio_smb: Change incorrect use of QUrl::adjusted() (authored by marten).
kio_smb: Change incorrect use of QUrl::adjusted()
Mar 27 2019, 11:52 AM
marten closed D19439: kio_smb: Change incorrect use of QUrl::adjusted().
Mar 27 2019, 11:52 AM · Frameworks, Dolphin
marten updated the diff for D20075: AttachmentUpdateJob needs to be exported even without BUILD_TESTING.

Use the standard export header

Mar 27 2019, 10:23 AM · KDE PIM
marten requested review of D20075: AttachmentUpdateJob needs to be exported even without BUILD_TESTING.
Mar 27 2019, 10:01 AM · KDE PIM

Mar 26 2019

marten added a comment to D19439: kio_smb: Change incorrect use of QUrl::adjusted().

Ping - anyone able to review please?

Mar 26 2019, 5:17 PM · Frameworks, Dolphin
marten committed R201:b2604e50af39: Use single-argument constructor of WebEngineViewer::WebEnginePage (authored by marten).
Use single-argument constructor of WebEngineViewer::WebEnginePage
Mar 26 2019, 4:29 PM
marten closed D19854: Use single-argument constructor of WebEngineViewer::WebEnginePage.
Mar 26 2019, 4:29 PM · KDE PIM

Mar 25 2019

marten updated the diff for D19854: Use single-argument constructor of WebEngineViewer::WebEnginePage.

No need to declare destructor as virtual

Mar 25 2019, 9:10 AM · KDE PIM

Mar 20 2019

marten added inline comments to D19854: Use single-argument constructor of WebEngineViewer::WebEnginePage.
Mar 20 2019, 12:51 PM · KDE PIM

Mar 18 2019

marten requested review of D19854: Use single-argument constructor of WebEngineViewer::WebEnginePage.
Mar 18 2019, 2:25 PM · KDE PIM
marten committed R345:666ce7b85ca1: Show PulseAudio "Capture Devices" in the system tray popup (authored by marten).
Show PulseAudio "Capture Devices" in the system tray popup
Mar 18 2019, 1:48 PM
marten committed R883:1537667: Fix capitalisation in "Do you really want to move this item to the Trash?".
Fix capitalisation in "Do you really want to move this item to the Trash?"
Mar 18 2019, 8:47 AM
marten committed R241:534ebe58c4ca: Delete/Trash confirmation dialogue: Fix misleading title (authored by marten).
Delete/Trash confirmation dialogue: Fix misleading title
Mar 18 2019, 8:30 AM
marten closed D19847: Delete/Trash confirmation dialogue: Fix misleading title and make consistent.
Mar 18 2019, 8:30 AM · Frameworks
marten committed R345:8e38f8557e4b: Show the current device/destination for a moveable channel (authored by marten).
Show the current device/destination for a moveable channel
Mar 18 2019, 7:43 AM
marten committed R345:7df9c10ce380: Further simplify PulseAudio backend using checkOpResult() (authored by marten).
Further simplify PulseAudio backend using checkOpResult()
Mar 18 2019, 7:43 AM
marten committed R345:5ba834bf01cc: Treat PulseAudio capture devices/streams as capture instead of playback (authored by marten).
Treat PulseAudio capture devices/streams as capture instead of playback
Mar 18 2019, 7:43 AM
marten committed R345:9d30ba08cd42: MixDevice/Volume: Tidy up and const'ify (authored by marten).
MixDevice/Volume: Tidy up and const'ify
Mar 18 2019, 7:43 AM
marten committed R345:8d732176129e: Eliminate the "Hardware Information" action, it was never used (authored by marten).
Eliminate the "Hardware Information" action, it was never used
Mar 18 2019, 7:43 AM

Mar 17 2019

marten requested review of D19847: Delete/Trash confirmation dialogue: Fix misleading title and make consistent.
Mar 17 2019, 8:47 PM · Frameworks

Mar 16 2019

marten committed R97:777bbe6e8536: Create QApplication before using I18N (authored by marten).
Create QApplication before using I18N
Mar 16 2019, 9:24 PM
marten committed R97:0b871355b3c9: Create QApplication before using I18N (authored by marten).
Create QApplication before using I18N
Mar 16 2019, 8:11 PM

Mar 12 2019

marten added a comment to D19559: Move management of QWebEngineProfile to WebEnginePage, to avoid crash on KMail exit or viewer window close.

Will let the Akregator change soak for a bit, to make sure there are no problems, and then submit it.

Mar 12 2019, 8:53 AM · KDE PIM
marten committed R94:9f0ce086c6a4: Move management of QWebEngineProfile to WebEnginePage (authored by marten).
Move management of QWebEngineProfile to WebEnginePage
Mar 12 2019, 8:49 AM
marten closed D19559: Move management of QWebEngineProfile to WebEnginePage, to avoid crash on KMail exit or viewer window close.
Mar 12 2019, 8:49 AM · KDE PIM

Mar 9 2019

marten committed R451:89499e900b20: Correctly locate the KPart library now that it is in a subdirectory (authored by marten).
Correctly locate the KPart library now that it is in a subdirectory
Mar 9 2019, 9:26 PM

Mar 8 2019

marten updated the diff for D19559: Move management of QWebEngineProfile to WebEnginePage, to avoid crash on KMail exit or viewer window close.

Setup and destruction of the QWebEngineProfile moved to WebEnginePage, so MailWebEngineView need know nothing about the profile and MailWebEnginePage only needs to access it via profile().

Mar 8 2019, 8:52 AM · KDE PIM

Mar 7 2019

marten added a comment to D19559: Move management of QWebEngineProfile to WebEnginePage, to avoid crash on KMail exit or viewer window close.

@dvratil: in light of @anthonyfieroni's comments, should this fix go into WebEnginePage (messagelib/webengineviewer/src/webenginepage.cpp) instead?

Mar 7 2019, 1:15 PM · KDE PIM
marten updated the diff for D19559: Move management of QWebEngineProfile to WebEnginePage, to avoid crash on KMail exit or viewer window close.

There's always a better way to do it...

Mar 7 2019, 12:02 PM · KDE PIM
marten updated the diff for D19559: Move management of QWebEngineProfile to WebEnginePage, to avoid crash on KMail exit or viewer window close.

Yes, doing that seems to work. It's not as elegant an implementation as it could be, because the QWebEngineProfile still needs to be created by MailWebEngineView and passed to the MailWebEnginePage which adopts it as a child. It's not possible to manage the profile entirely within MailWebEnginePage because a profile can only be set when a QWebEnginePage is created, and trying to do that in the constructor:

Mar 7 2019, 9:37 AM · KDE PIM