- User Since
- Mar 20 2016, 1:07 PM (186 w, 5 d)
Thu, Oct 17
Updated in accordance with review comments, variable names corresponding to what they actually do.
Tue, Oct 15
If you mean to incorporate the tests directly into actionRequestedByUser:
Fri, Oct 11
Mon, Oct 7
Tue, Sep 24
Mon, Sep 23
I'm not convinced that trying to show a reading time is that useful. Estimating this will need to take so much into account - it seems easy to divide the length of the message by the user's personal reading speed, but getting an accurate estimate will also depend on the amount of original (non-quoted and non-signature) text, the variation in reading speed between individual messages (junk can be dismissed with just a glance, a party invite may just be skimmed for a date/time, while a technical discussion will have to be read in detail, etc) that an estimate algorithm would need to be trained on a great number of messages before getting anywhere near a realistic result. If the time shown bears no relation to reality then the user will learn to ignore it and there is no point in showing it.
Sun, Sep 22
Good idea to have the button, but maybe it should be placed in the header area instead of the body of the message for security reasons (so that it cannot be spoofed by a malicious HTML message).
Sep 17 2019
Sep 15 2019
Ignore the desktop ID and simply use the loop index, adjusted so that the desktop numbers start at 1. This is the same formatting as used by KWin (kwin/useractions.cpp) and the Task Manager applet (plasma-desktop/applets/taskmanager/package/contents/ui/ContextMenu.qml). This should work as intended on both X11 and Wayland.
Sep 9 2019
Thanks for the fix - a much better solution to the HiDPI support.
Aug 18 2019
@GB_2 thanks for testing; a desktop UUID is obviously not friendly to show to the user, so there needs to be some sort of X11/Wayland runtime check here.
Aug 17 2019
Jul 29 2019
Good idea to reduce required dependencies, many thanks.
Jul 25 2019
Jul 20 2019
Jul 11 2019
Confirmed that man:clang(1) now correctly displays the man page with no spurious numbers shown. Would be happy to abandon this review request.
Jul 10 2019
Good point regarding the possibility of decoding other formats.
Jul 9 2019
Jun 27 2019
Jun 19 2019
Jun 15 2019
@mlaurent, are you also happy to accept this revision?
Jun 3 2019
New function setUseProxyInternal() to set proxy state and, if the connection is active, disconnect and reconnect it with the new proxy setting.
May 31 2019
Diff updated in accordance with review comments
Tab converted to spaces
May 30 2019
May 29 2019
KIMAP required version updated
Version number updated
May 28 2019
Laurent, do you mean the PIM_VERSION in kimap/CMakeLists.txt (which then sets KIMAP_LIB_VERSION), currently "5.11.40"? I was under the impression that this was managed by the release scripts and all PIM components had to have the same version.
I assume that you don't mean the SOVERSION of the kimap library (which doesn't have a minor version).
May 25 2019
May 19 2019
May 18 2019
See https://bugs.kde.org/show_bug.cgi?id=407685 for IMAP.
May 4 2019
Appears to have been already implemented by https://phabricator.kde.org/R244:b2b873d612a018d33866ddfd497f87bb7dd79573
May 2 2019
The tool is up to date and working as far as I am aware, but any bug reports or suggestions for additions would of course be welcome.
Mar 27 2019
Use the standard export header
Mar 26 2019
Ping - anyone able to review please?
Mar 25 2019
No need to declare destructor as virtual
Mar 20 2019
Mar 18 2019
Mar 17 2019
Mar 16 2019
Mar 12 2019
Will let the Akregator change soak for a bit, to make sure there are no problems, and then submit it.
Mar 9 2019
Mar 8 2019
Setup and destruction of the QWebEngineProfile moved to WebEnginePage, so MailWebEngineView need know nothing about the profile and MailWebEnginePage only needs to access it via profile().
Mar 7 2019
There's always a better way to do it...
Yes, doing that seems to work. It's not as elegant an implementation as it could be, because the QWebEngineProfile still needs to be created by MailWebEngineView and passed to the MailWebEnginePage which adopts it as a child. It's not possible to manage the profile entirely within MailWebEnginePage because a profile can only be set when a QWebEnginePage is created, and trying to do that in the constructor:
Mar 6 2019
Sounds a good idea, will investigate.
Something like this...?
Mar 1 2019
Use the same condition as the Qt header uses
Feb 27 2019
Not sure why I'm being asked to review?