- User Since
- Mar 20 2016, 1:07 PM (218 w, 2 d)
Wed, May 20
@sandsmark: do you have commit access?
@kurmikon: do you have commit access?
Thu, May 14
Wed, May 13
Happy for there to be a GUI for the volume step. It doesn't work everywhere (e.g. it should also apply to clicks on the the system tray volume slider), and it would be nice if a restart of KMix was not required, but those can be fixed later. Please see inline comments.
Mon, May 11
Appreciate that using a pointer doesn't change anything at runtime, it was just for the purpose of eliminating an include in the mixer_pulse.h header file.
Sat, May 9
Fri, May 1
Updated in accordance with review comments.
Wed, Apr 29
I've thought about this a bit more and can't find any explanation as to why the DBus signal does not loop back to the sending process as well as all other listeners. It may be an unspecified detail of the DBus implementation that could possibly change at any time and start happening. So maybe it would be better to retain the boolean flag and fix the ordering - in other words, keep things simple and implement the change as in the original diff.
Apologies for taking a long time to review this. Great work, good idea to try to reduce external dependencies as much as possible (especially any starting with 'g').
Apr 26 2020
Apr 21 2020
Apr 17 2020
Apr 16 2020
I'm happy to work on the refactoring if you think it's the right thing to do.
Apr 15 2020
Apr 11 2020
Yes, that would mean fewer changes to the validate_svg.sh script.
Apr 7 2020
Apr 5 2020
Removed obsolete/misleading comment
Bump to ECM version requested on D28595.
@rrosch: The EXPORT and DESCRIPTION arguments to ecm_qt_declare_logging_category are supported since ECM 5.68.0.
Apr 4 2020
Agreed that debugging is a mess, especially with the if(1) and if(0) randomly scattered around. Will address this later.
Would you also be able to look at D28551 (porting signal connections)?
Apr 3 2020
Correction to list of changes above - update to new signal connection syntax will follow in a separate review.
Apr 1 2020
Mar 31 2020
Group setup for each button together
Mar 30 2020
Just noticed that originally the accelerator 'O' was set for both the "Open With" and "Open with <default application>" buttons. Set to 'W' for "Open With".
Mar 29 2020
Mar 28 2020
Mar 27 2020
Mar 26 2020
Mar 15 2020
Mar 13 2020
Mar 12 2020
Apply the fix to kfmclient_html.desktop as advised.
Mar 9 2020
Needs %U in Exec= line to handle URLs directly and to not download temporary files.
Feb 8 2020
Feb 6 2020
Feb 5 2020
@ahmadsamir: Yes, the problem could be fixed in Dolphin, but that leaves a potential trap for any other KPart that reimplements openUrl().
Feb 4 2020
Yes, I'd concluded that the real place to fix the problem was at the KParts level, but not being a KParts expert wanted to leave that decision to its maintainers. +1 for the elegant fix.
Feb 1 2020
Please see https://bugs.kde.org/show_bug.cgi?id=416989, this change appears to cause problems with Konqueror's similar (but not identical) action.
Jan 22 2020
Jan 13 2020
Ping - anyone able to review?
Nov 7 2019
Actually everything appears to still work if isPaused is handled entirely declaratively.
Yes, that seems to work (and simplifies the code a bit).