marten (Jonathan Marten)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 20 2016, 1:07 PM (239 w, 3 d)
Availability
Available

Recent Activity

Sep 15 2020

marten added a comment to T13545: Resurrect the Web Archiver.

Submitted as https://invent.kde.org/network/konqueror/-/merge_requests/36

Sep 15 2020, 3:33 PM · Konqueror

Aug 28 2020

marten created T13545: Resurrect the Web Archiver.
Aug 28 2020, 11:53 AM · Konqueror

Jul 30 2020

marten closed T11559: Port Konqueror away from KDELibs4Support as Resolved.

This is now done. Konqueror compiles without KDElibs4Support and with no deprecation warnings.

Jul 30 2020, 9:28 AM · KF6
marten closed T11559: Port Konqueror away from KDELibs4Support, a subtask of T11552: Remove kdelibs4support, as Resolved.
Jul 30 2020, 9:28 AM · KF6

Jul 13 2020

marten added a comment to T11559: Port Konqueror away from KDELibs4Support.

Just to say that I've done some more porting and cleanup work on Konqueror. It's at the stage where it is possible to build without KDElibs4support and with no deprecation warnings, and currently I'm working on getting the changes organised by functional area and creating merge requests. If anyone could look at Konqueror's merge requests and, if they are acceptable, merge them soon so that master does not diverge too much, then that will hopefully get it ready for KF6.

Jul 13 2020, 2:31 PM · KF6

May 30 2020

marten committed R345:4b0c2e60c70d: New file backends/qtpamainloop.h left out of commit e20ad13f (authored by sandsmark).
New file backends/qtpamainloop.h left out of commit e20ad13f
May 30 2020, 1:03 PM
marten committed R345:8bcf9255d00a: Mixer_PULSE: Eliminate "use of old-style cast" warnings (authored by marten).
Mixer_PULSE: Eliminate "use of old-style cast" warnings
May 30 2020, 1:03 PM
marten closed D28982: Use Qt instead of a full glib event loop just for pulseaudio.
May 30 2020, 11:54 AM
marten committed R345:e20ad13fa703: Use QtPaMainLoop instead of a full GLib event loop just for PulseAudio (authored by sandsmark).
Use QtPaMainLoop instead of a full GLib event loop just for PulseAudio
May 30 2020, 11:54 AM

May 25 2020

marten committed R345:1651d9b8cf20: Add ability to configure volume step percentage in the GUI (authored by kurmikon).
Add ability to configure volume step percentage in the GUI
May 25 2020, 8:39 PM
marten closed D29663: Add ability to configure volume step percentage in KMix UI.
May 25 2020, 8:39 PM

May 20 2020

marten added a comment to D28982: Use Qt instead of a full glib event loop just for pulseaudio.

@sandsmark: do you have commit access?

May 20 2020, 9:40 AM
marten added a comment to D29663: Add ability to configure volume step percentage in KMix UI.

@kurmikon: do you have commit access?

May 20 2020, 9:38 AM

May 14 2020

marten committed R241:6452a34cf01d: Fix service file specifying 'Run in terminal' giving an error code 100 (authored by marten).
Fix service file specifying 'Run in terminal' giving an error code 100
May 14 2020, 6:26 PM
marten closed D29738: Fix service file specifying 'Run in terminal' giving an error code 100.
May 14 2020, 6:26 PM · Frameworks
marten requested review of D29738: Fix service file specifying 'Run in terminal' giving an error code 100.
May 14 2020, 9:40 AM · Frameworks
marten accepted D29663: Add ability to configure volume step percentage in KMix UI.
May 14 2020, 9:09 AM

May 13 2020

marten requested changes to D29663: Add ability to configure volume step percentage in KMix UI.

Happy for there to be a GUI for the volume step. It doesn't work everywhere (e.g. it should also apply to clicks on the the system tray volume slider), and it would be nice if a restart of KMix was not required, but those can be fixed later. Please see inline comments.

May 13 2020, 1:53 PM
marten added a reviewer for D29663: Add ability to configure volume step percentage in KMix UI: marten.
May 13 2020, 1:42 PM

May 11 2020

marten accepted D28982: Use Qt instead of a full glib event loop just for pulseaudio.

Appreciate that using a pointer doesn't change anything at runtime, it was just for the purpose of eliminating an include in the mixer_pulse.h header file.

May 11 2020, 8:30 AM

May 9 2020

marten committed R94:262aaa45d729: Attachment open dialogue: Change the button order (authored by marten).
Attachment open dialogue: Change the button order
May 9 2020, 2:46 PM
marten closed D28431: Attachment open dialogue: Make the button order more useful.
May 9 2020, 2:46 PM · KDE PIM

May 1 2020

marten committed R226:e0939bde342c: Port and enable build of the User Agent Changer plugin (authored by marten).
Port and enable build of the User Agent Changer plugin
May 1 2020, 8:28 PM
marten closed D29321: Port and enable the User Agent Changer plugin.
May 1 2020, 8:28 PM
marten added inline comments to D29321: Port and enable the User Agent Changer plugin.
May 1 2020, 2:15 PM
marten updated the diff for D29321: Port and enable the User Agent Changer plugin.

Updated in accordance with review comments.

May 1 2020, 2:13 PM
marten requested review of D29321: Port and enable the User Agent Changer plugin.
May 1 2020, 10:05 AM

Apr 29 2020

marten added a comment to D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process.

I've thought about this a bit more and can't find any explanation as to why the DBus signal does not loop back to the sending process as well as all other listeners. It may be an unspecified detail of the DBus implementation that could possibly change at any time and start happening. So maybe it would be better to retain the boolean flag and fix the ordering - in other words, keep things simple and implement the change as in the original diff.

Apr 29 2020, 10:05 AM · Frameworks
marten added a comment to D28982: Use Qt instead of a full glib event loop just for pulseaudio.

Apologies for taking a long time to review this. Great work, good idea to try to reduce external dependencies as much as possible (especially any starting with 'g').

Apr 29 2020, 9:20 AM

Apr 26 2020

marten committed R981:a9acc6663517: Add inode/directory to supported MIME types (authored by marten).
Add inode/directory to supported MIME types
Apr 26 2020, 11:10 AM
marten committed R981:abea50e51adf: Right align "Help" in menu bar, for styles that do that (authored by marten).
Right align "Help" in menu bar, for styles that do that
Apr 26 2020, 11:10 AM

Apr 21 2020

marten committed R432:96167b943ede: QString::SplitBehavior enum is removed in Qt 5.15 (authored by marten).
QString::SplitBehavior enum is removed in Qt 5.15
Apr 21 2020, 2:58 PM

Apr 17 2020

marten committed R89:86a8cc0c668f: Fix KMail crash when adding too many recipients (authored by marten).
Fix KMail crash when adding too many recipients
Apr 17 2020, 8:01 PM
marten closed D28876: Fix KMail crash when adding too many recipients.
Apr 17 2020, 8:01 PM · KDE PIM

Apr 16 2020

marten requested review of D28876: Fix KMail crash when adding too many recipients.
Apr 16 2020, 11:01 AM · KDE PIM
marten added a comment to D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process.

I'm happy to work on the refactoring if you think it's the right thing to do.

Apr 16 2020, 10:27 AM · Frameworks

Apr 15 2020

marten committed R266:0a5dd2972b62: Allow building from a read-only source location (authored by marten).
Allow building from a read-only source location
Apr 15 2020, 4:34 PM
marten closed D28755: Breeze Icons cannot be built from read-only source location.
Apr 15 2020, 4:34 PM · Frameworks

Apr 11 2020

marten updated the diff for D28755: Breeze Icons cannot be built from read-only source location.

Yes, that would mean fewer changes to the validate_svg.sh script.

Apr 11 2020, 3:21 PM · Frameworks
marten requested review of D28755: Breeze Icons cannot be built from read-only source location.
Apr 11 2020, 2:14 PM · Frameworks

Apr 7 2020

marten requested review of D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process.
Apr 7 2020, 9:14 AM · Frameworks

Apr 5 2020

marten committed R226:651c4b983864: File Size View: Increase minimum ECM version (authored by marten).
File Size View: Increase minimum ECM version
Apr 5 2020, 3:46 PM
marten closed D28595: Increase minimum ECM version, required by File Size View.
Apr 5 2020, 3:46 PM
marten updated the diff for D28595: Increase minimum ECM version, required by File Size View.

Removed obsolete/misleading comment

Apr 5 2020, 3:27 PM
marten added a comment to D28486: File Size View: Port away from KDElibs4Support.

Bump to ECM version requested on D28595.

Apr 5 2020, 3:24 PM
marten requested review of D28595: Increase minimum ECM version, required by File Size View.
Apr 5 2020, 3:21 PM
marten added a comment to D28486: File Size View: Port away from KDElibs4Support.

@rrosch: The EXPORT and DESCRIPTION arguments to ecm_qt_declare_logging_category are supported since ECM 5.68.0.

Apr 5 2020, 12:19 PM

Apr 4 2020

marten committed R226:e5afa610a1ed: Make FSViewBrowserExtension slots public (authored by marten).
Make FSViewBrowserExtension slots public
Apr 4 2020, 3:28 PM
marten committed R226:93c65f746949: File Size View: Convert to new Qt5 connect syntax (authored by marten).
File Size View: Convert to new Qt5 connect syntax
Apr 4 2020, 3:28 PM
marten closed D28551: File Size View: Convert to new Qt5 connect syntax.
Apr 4 2020, 3:28 PM
marten committed R226:a7c65d17a08d: File Size View: Port away from KDElibs4Support (authored by marten).
File Size View: Port away from KDElibs4Support
Apr 4 2020, 3:28 PM
marten closed D28486: File Size View: Port away from KDElibs4Support.
Apr 4 2020, 3:28 PM
marten added a comment to D28486: File Size View: Port away from KDElibs4Support.

Agreed that debugging is a mess, especially with the if(1) and if(0) randomly scattered around. Will address this later.
Would you also be able to look at D28551 (porting signal connections)?

Apr 4 2020, 10:32 AM
marten requested review of D28551: File Size View: Convert to new Qt5 connect syntax.
Apr 4 2020, 7:57 AM

Apr 3 2020

marten added a comment to D28486: File Size View: Port away from KDElibs4Support.

Correction to list of changes above - update to new signal connection syntax will follow in a separate review.

Apr 3 2020, 8:28 AM

Apr 1 2020

marten requested review of D28486: File Size View: Port away from KDElibs4Support.
Apr 1 2020, 2:57 PM
marten committed R345:3d9cf0985677: Merge git://anongit.kde.org/kmix (authored by marten).
Merge git://anongit.kde.org/kmix
Apr 1 2020, 9:27 AM
marten committed R345:b482efe7872a: Port deprecated QList::toSet(), QDesktopWidget::screenGeometry() (authored by marten).
Port deprecated QList::toSet(), QDesktopWidget::screenGeometry()
Apr 1 2020, 9:27 AM

Mar 31 2020

marten committed R345:068aec9da4b0: Use KMixToolBox::noDevicesWarningWidget() in 3 applicable dialogues (authored by marten).
Use KMixToolBox::noDevicesWarningWidget() in 3 applicable dialogues
Mar 31 2020, 2:08 PM
marten committed R345:951f5efb0d14: Add KMixToolBox::noDevicesWarningWidget() to standardise that error indication (authored by marten).
Add KMixToolBox::noDevicesWarningWidget() to standardise that error indication
Mar 31 2020, 2:08 PM
marten committed R345:7b43ca0cd26b: KMixToolBox: Convert to a namespace, simplify 3 "set*" functions (authored by marten).
KMixToolBox: Convert to a namespace, simplify 3 "set*" functions
Mar 31 2020, 2:08 PM
marten committed R345:d0fecb9ecbb2: DialogAddView: Use Mixer::iconName() (authored by marten).
DialogAddView: Use Mixer::iconName()
Mar 31 2020, 2:08 PM
marten committed R345:ebca1f844a7e: Add Mixer::iconName() to find an icon for the master channel (authored by marten).
Add Mixer::iconName() to find an icon for the master channel
Mar 31 2020, 2:08 PM
marten committed R345:3773a4b2395f: DialogChooseBackends: Use Mixer::iconName() (authored by marten).
DialogChooseBackends: Use Mixer::iconName()
Mar 31 2020, 2:08 PM
marten committed R345:dbfc1788e6f8: Volume Control dialogue: Use a KMessageWidget if no devices are present (authored by marten).
Volume Control dialogue: Use a KMessageWidget if no devices are present
Mar 31 2020, 2:08 PM
marten updated the diff for D28431: Attachment open dialogue: Make the button order more useful.

Group setup for each button together

Mar 31 2020, 9:02 AM · KDE PIM

Mar 30 2020

marten updated the diff for D28431: Attachment open dialogue: Make the button order more useful.

Just noticed that originally the accelerator 'O' was set for both the "Open With" and "Open with <default application>" buttons. Set to 'W' for "Open With".

Mar 30 2020, 12:16 PM · KDE PIM
marten requested review of D28431: Attachment open dialogue: Make the button order more useful.
Mar 30 2020, 12:06 PM · KDE PIM

Mar 29 2020

marten committed R345:1ab89689dcec: Remove the 'kmixdocked*' pixmaps (authored by marten).
Remove the 'kmixdocked*' pixmaps
Mar 29 2020, 3:00 PM
marten committed R345:0a72319f9c00: System tray dock widget: Fix showing the icon for an error condition (authored by marten).
System tray dock widget: Fix showing the icon for an error condition
Mar 29 2020, 3:00 PM

Mar 28 2020

marten committed R660:afa98baccf2a: libfiletree: Use new signal connection syntax (authored by marten).
libfiletree: Use new signal connection syntax
Mar 28 2020, 10:56 AM

Mar 27 2020

marten committed R660:43e84c09110d: KScanSlider: Convert other uses of deprecated constructor (authored by marten).
KScanSlider: Convert other uses of deprecated constructor
Mar 27 2020, 11:17 AM
marten committed R660:88f34345bc99: KScanControl/KSCanOption: Use new signal connection syntax (authored by marten).
KScanControl/KSCanOption: Use new signal connection syntax
Mar 27 2020, 11:17 AM
marten committed R660:18b44956b5b9: KScanSlider: Set single step as specified by SANE (authored by marten).
KScanSlider: Set single step as specified by SANE
Mar 27 2020, 11:17 AM
marten committed R660:11452e3190f8: KScanOption: Eliminate private member functions only used once (authored by marten).
KScanOption: Eliminate private member functions only used once
Mar 27 2020, 11:17 AM

Mar 26 2020

marten committed R660:349b7841df7f: Merge git://anongit.kde.org/kooka (authored by marten).
Merge git://anongit.kde.org/kooka
Mar 26 2020, 4:09 PM
marten committed R660:2c3f4f2f3770: Fix some deprecated warnings with Qt 5.14 and Frameworks 5.69 (authored by marten).
Fix some deprecated warnings with Qt 5.14 and Frameworks 5.69
Mar 26 2020, 4:09 PM

Mar 15 2020

marten committed R227:b5f6e32667c7: Change action text "Open in Konqueror" -> "Open in Browser" (authored by marten).
Change action text "Open in Konqueror" -> "Open in Browser"
Mar 15 2020, 8:27 PM

Mar 13 2020

marten committed R226:4009b1763afe: Set MimeType so that Konqueror appears in Default Applications (authored by marten).
Set MimeType so that Konqueror appears in Default Applications
Mar 13 2020, 8:29 AM
marten closed D27948: Set MimeType in desktop file so that Konqueror appears in Default Applications.
Mar 13 2020, 8:29 AM

Mar 12 2020

marten updated the diff for D27948: Set MimeType in desktop file so that Konqueror appears in Default Applications.

Apply the fix to kfmclient_html.desktop as advised.

Mar 12 2020, 12:34 PM

Mar 9 2020

marten updated the diff for D27948: Set MimeType in desktop file so that Konqueror appears in Default Applications.

Needs %U in Exec= line to handle URLs directly and to not download temporary files.

Mar 9 2020, 9:01 PM
marten requested review of D27948: Set MimeType in desktop file so that Konqueror appears in Default Applications.
Mar 9 2020, 3:40 PM

Feb 8 2020

marten committed R363:3ce3d1f435ee: Update the GUI enabled/paused state if it changes externally (authored by marten).
Update the GUI enabled/paused state if it changes externally
Feb 8 2020, 2:36 PM
marten closed D25186: Update internal printer enabled/paused state if it changes externally.
Feb 8 2020, 2:36 PM

Feb 6 2020

marten committed R660:f5c0a9845ef3: OCR dialogue: Ensure that the progress bar animates (authored by marten).
OCR dialogue: Ensure that the progress bar animates
Feb 6 2020, 1:21 PM
marten committed R660:6e4d84ea5d0e: KScanDevice: clean up, eliminate member variables and internal signals (authored by marten).
KScanDevice: clean up, eliminate member variables and internal signals
Feb 6 2020, 1:21 PM
marten committed R660:19d748990cb6: Centralise dots/inch <-> dots/metre conversion in KScanDevice (authored by marten).
Centralise dots/inch <-> dots/metre conversion in KScanDevice
Feb 6 2020, 1:21 PM

Feb 5 2020

marten added a comment to D27148: update d->m_file in ReadOnlyPart::setUrl().

@ahmadsamir: Yes, the problem could be fixed in Dolphin, but that leaves a potential trap for any other KPart that reimplements openUrl().

Feb 5 2020, 4:57 PM · Frameworks

Feb 4 2020

marten added a comment to D27148: update d->m_file in ReadOnlyPart::setUrl().

Yes, I'd concluded that the real place to fix the problem was at the KParts level, but not being a KParts expert wanted to leave that decision to its maintainers. +1 for the elegant fix.

Feb 4 2020, 8:54 AM · Frameworks

Feb 1 2020

marten added a comment to D26140: Use KParts::ReadOnlyPart::localFilePath() in DolphinPart::slotOpenTerminal().

Please see https://bugs.kde.org/show_bug.cgi?id=416989, this change appears to cause problems with Konqueror's similar (but not identical) action.

Feb 1 2020, 4:26 PM · Dolphin

Jan 22 2020

marten committed R660:ee9235f3b5ae: Merge branch 'tesseract-ocr' (authored by marten).
Merge branch 'tesseract-ocr'
Jan 22 2020, 3:45 PM
marten committed R660:fafaef046d31: Add support for the Tesseract OCR engine (authored by marten).
Add support for the Tesseract OCR engine
Jan 22 2020, 3:45 PM
marten committed R660:369ecdf171af: Move OCR application icons into their respective plugin source directories (authored by marten).
Move OCR application icons into their respective plugin source directories
Jan 22 2020, 3:45 PM

Jan 13 2020

marten added a comment to D25186: Update internal printer enabled/paused state if it changes externally.

Ping - anyone able to review?

Jan 13 2020, 10:38 AM

Nov 7 2019

marten updated the diff for D25186: Update internal printer enabled/paused state if it changes externally.

Actually everything appears to still work if isPaused is handled entirely declaratively.

Nov 7 2019, 1:48 PM
marten updated the diff for D25186: Update internal printer enabled/paused state if it changes externally.

Yes, that seems to work (and simplifies the code a bit).

Nov 7 2019, 1:38 PM
marten requested review of D25186: Update internal printer enabled/paused state if it changes externally.
Nov 7 2019, 8:46 AM

Nov 5 2019

marten committed R883:1555258: Kooka en_GB: New translations for OCR and TIFF.
Kooka en_GB: New translations for OCR and TIFF
Nov 5 2019, 9:34 AM

Nov 4 2019

marten committed R660:c2ba68ee5329: Pass KookaImage to OCR by reference, to avoid generating a copy (authored by marten).
Pass KookaImage to OCR by reference, to avoid generating a copy
Nov 4 2019, 11:41 AM