Feed Advanced Search

Thu, May 23

volkov added reviewers for D21363: Fix build with poppler < 0.51: Okular, sander.
Thu, May 23, 10:31 AM · Okular
volkov added a comment to D21320: Fix build with poppler < 0.51.

Sorry. I didn't add #include <config-okular-poppler.h> to formfields.h.
Correct fix: D21363.

Thu, May 23, 10:31 AM · Okular
volkov requested review of D21363: Fix build with poppler < 0.51.
Thu, May 23, 10:28 AM · Okular

Wed, May 22

volkov committed R223:f29f6727a2a8: Merge remote-tracking branch 'origin/Applications/19.04' (authored by volkov).
Merge remote-tracking branch 'origin/Applications/19.04'
Wed, May 22, 12:40 PM
volkov committed R223:32786e6b3d8d: Fix build with poppler < 0.51 (authored by volkov).
Fix build with poppler < 0.51
Wed, May 22, 12:33 PM
volkov closed D21320: Fix build with poppler < 0.51.
Wed, May 22, 12:33 PM · Okular

Tue, May 21

volkov added a reviewer for D21320: Fix build with poppler < 0.51: Okular.
Tue, May 21, 3:49 PM · Okular
volkov requested review of D21320: Fix build with poppler < 0.51.
Tue, May 21, 3:49 PM · Okular
volkov added inline comments to D14655: Reimplement signature form field and related utility classes in poppler generator.
Tue, May 21, 3:26 PM · Okular

Thu, May 16

volkov committed R420:358221c1e4b9: Replace Q_DECL_OVERRIDE by override (authored by volkov).
Replace Q_DECL_OVERRIDE by override
Thu, May 16, 2:28 PM
volkov closed D21240: Replace Q_DECL_OVERRIDE by override.
Thu, May 16, 2:28 PM
volkov added a reviewer for D21240: Replace Q_DECL_OVERRIDE by override: mlaurent.
Thu, May 16, 1:54 PM
volkov requested review of D21240: Replace Q_DECL_OVERRIDE by override.
Thu, May 16, 1:53 PM
volkov committed R420:dcdbc8a70317: Add .arcconfig (authored by volkov).
Add .arcconfig
Thu, May 16, 1:24 PM

Wed, May 15

volkov added a comment to D21231: Add initial HiDPI support.

Complete HiDPI support requires D21230.

Wed, May 15, 5:01 PM
volkov requested review of D21231: Add initial HiDPI support.
Wed, May 15, 5:00 PM
volkov requested review of D21230: Add support for creating high-dpi pixmaps by KGameRenderer{Client}.
Wed, May 15, 4:52 PM

Thu, May 9

volkov updated the summary of D20790: Add highdpi support for RDP and VNC.
Thu, May 9, 7:23 PM
volkov updated the summary of D21096: vnc: Optimize and simplify repainting.
Thu, May 9, 4:06 PM
volkov updated the diff for D20790: Add highdpi support for RDP and VNC.

rebased

Thu, May 9, 3:17 PM
volkov added a comment to D20790: Add highdpi support for RDP and VNC.

I'm going to rebase it on D21096. Please, review that change first.

Thu, May 9, 12:21 PM
volkov added a reviewer for D21096: vnc: Optimize and simplify repainting: KDE Applications.
Thu, May 9, 12:16 PM
volkov requested review of D21096: vnc: Optimize and simplify repainting.
Thu, May 9, 12:14 PM

Mon, Apr 29

volkov committed R483:cb382f87d63b: Add HiDPI support (authored by volkov).
Add HiDPI support
Mon, Apr 29, 1:21 PM
volkov closed D20821: Add HiDPI support.
Mon, Apr 29, 1:21 PM
volkov committed R382:23c3a433d339: Add HiDPI support (authored by volkov).
Add HiDPI support
Mon, Apr 29, 1:13 PM
volkov closed D20806: Add HiDPI support.
Mon, Apr 29, 1:13 PM
volkov committed R382:9690fd2162dd: Extract HideRectItem class (authored by volkov).
Extract HideRectItem class
Mon, Apr 29, 1:09 PM
volkov closed D20841: Extract HideRectItem class.
Mon, Apr 29, 1:09 PM
volkov updated the diff for D20841: Extract HideRectItem class.

ok, leave only my own copyright

Mon, Apr 29, 12:26 PM
volkov updated the diff for D20806: Add HiDPI support.

emulate missing QGraphicsView::mapToScene(const QPointF &) by using QPainterPath wrapper

Mon, Apr 29, 12:23 PM
volkov added a comment to D20841: Extract HideRectItem class.

But the code is yours, isn't it?

Mon, Apr 29, 12:12 PM
volkov added a reviewer for D20790: Add highdpi support for RDP and VNC: davidedmundson.
Mon, Apr 29, 12:08 PM
volkov updated the diff for D20806: Add HiDPI support.

use precise coordinates for selections + use cosmetic pens

Mon, Apr 29, 12:06 PM
volkov added inline comments to D20806: Add HiDPI support.
Mon, Apr 29, 10:31 AM
volkov added a comment to D20821: Add HiDPI support.

AA_UseHighDpiPixmaps is not related to previews, it's for icons on buttons.
devicePixelRatioF is needed to paint an image as is without highdpi scaling by Qt.

Mon, Apr 29, 10:26 AM
volkov updated the diff for D20841: Extract HideRectItem class.

fix copyrights

Mon, Apr 29, 10:20 AM

Fri, Apr 26

volkov added a reviewer for D20841: Extract HideRectItem class: sars.
Fri, Apr 26, 9:36 PM
volkov added a reviewer for D20790: Add highdpi support for RDP and VNC: KDE Applications.
Fri, Apr 26, 4:35 PM
volkov updated the diff for D20790: Add highdpi support for RDP and VNC.

polished

Fri, Apr 26, 4:33 PM
volkov added a dependency for D20806: Add HiDPI support: D20841: Extract HideRectItem class.
Fri, Apr 26, 1:01 PM
volkov added a dependent revision for D20841: Extract HideRectItem class: D20806: Add HiDPI support.
Fri, Apr 26, 1:01 PM
volkov updated the diff for D20806: Add HiDPI support.

leave a single commit

Fri, Apr 26, 1:00 PM
volkov updated the diff for D20806: Add HiDPI support.

rebase on D20841

Fri, Apr 26, 12:50 PM
volkov requested review of D20841: Extract HideRectItem class.
Fri, Apr 26, 12:47 PM
volkov updated the diff for D20806: Add HiDPI support.

revert

Fri, Apr 26, 12:45 PM
volkov updated the diff for D20806: Add HiDPI support.

rebase on extracted HideRectItem

Fri, Apr 26, 12:35 PM
volkov added a comment to D20821: Add HiDPI support.

To paint non-pixelated icons on buttons.
This attribute "makes QIcon::pixmap() generate high-dpi pixmaps that can be larger than the requested size. Such pixmaps will have devicePixelRatio() set to a value higher than 1."

Fri, Apr 26, 11:40 AM
volkov added a comment to D20806: Add HiDPI support.

Qt supports a high DPI mode where the main coordinate system is virtualized and made independent of the display pixel density.
...
Geometry is now specified in device independent pixels. This includes widget and item geometry, event geometry, desktop, window and screen
geometry, and animation velocities. Rendered output is in device pixels, which corresponds to the display resolution. The ratio between the
device independent and device pixel coordinate systems is the devicePixelRatio.

Fri, Apr 26, 11:28 AM

Thu, Apr 25

volkov added a comment to D13901: Touch support for Gwenview.

Ideally, QWidget::mouseDoubleClickEvent() could be used instead of double tap gesture...
https://codereview.qt-project.org/#/c/259787/

Thu, Apr 25, 5:05 PM · Gwenview
volkov added reviewers for D20821: Add HiDPI support: sars, davidedmundson, ngraham.
Thu, Apr 25, 3:13 PM
volkov requested review of D20821: Add HiDPI support.
Thu, Apr 25, 3:12 PM
volkov updated the diff for D20806: Add HiDPI support.

removed needless image scaling

Thu, Apr 25, 2:51 PM
volkov added inline comments to D20806: Add HiDPI support.
Thu, Apr 25, 2:50 PM
volkov added a reviewer for D20806: Add HiDPI support: sars.
Thu, Apr 25, 12:46 PM
volkov requested review of D20806: Add HiDPI support.
Thu, Apr 25, 12:44 PM

Apr 24 2019

volkov committed R410:e41c3cce214e: Avoid tiny cards on high screen resolutions (authored by volkov).
Avoid tiny cards on high screen resolutions
Apr 24 2019, 3:57 PM
volkov closed D20061: Avoid tiny cards on high screen resolutions.
Apr 24 2019, 3:57 PM
volkov requested review of D20790: Add highdpi support for RDP and VNC.
Apr 24 2019, 3:19 PM

Apr 16 2019

volkov added a comment to D20445: signalplotter: Add highdpi support.

Beams look ugly when their width is >= 4 pixels.
The idea is to draw them with the same width regardless of DPI.
Another option is to not set Qt::FlatCap for thick pens, but I prefer this one.

Apr 16 2019, 9:59 AM · Plasma

Apr 15 2019

volkov added inline comments to D20445: signalplotter: Add highdpi support.
Apr 15 2019, 3:43 PM · Plasma

Apr 12 2019

volkov updated the diff for D20445: signalplotter: Add highdpi support.

use QPen::setWidthF() instead of QPen::setWidth()

Apr 12 2019, 9:44 PM · Plasma
volkov updated the diff for D20445: signalplotter: Add highdpi support.

reduced beam width

Apr 12 2019, 4:38 PM · Plasma

Apr 11 2019

volkov added a comment to D20445: signalplotter: Add highdpi support.

Hi, thanks for the review.
I know about the issues, I've uploaded the patch to avoid losing it :)

Apr 11 2019, 9:51 AM · Plasma

Apr 10 2019

volkov requested review of D20445: signalplotter: Add highdpi support.
Apr 10 2019, 4:31 PM · Plasma

Apr 8 2019

volkov committed R260:b6e6ec6e92d0: Drop unnecessary PaintUtils::containingRect() (authored by volkov).
Drop unnecessary PaintUtils::containingRect()
Apr 8 2019, 5:13 PM
volkov closed D20251: Drop unnecessary PaintUtils::containingRect().
Apr 8 2019, 5:12 PM · Gwenview
volkov updated subscribers of D20251: Drop unnecessary PaintUtils::containingRect().

Well, actually, it was caught by @hetzenecker: https://phabricator.kde.org/D7581?id=22415#change-vIXPDUvyb3sZ

Apr 8 2019, 5:12 PM · Gwenview
volkov added a comment to D7581: HiDPI Support for Gwenview.

You are welcome!
I started to implement highdpi support from scratch, but then I found this change and it was a huge help!

Apr 8 2019, 12:54 PM · Gwenview
volkov added a comment to D19920: Add High DPI support.

ping

Apr 8 2019, 11:24 AM
volkov updated the diff for D20251: Drop unnecessary PaintUtils::containingRect().

re-target to master

Apr 8 2019, 11:22 AM · Gwenview

Apr 6 2019

volkov updated the diff for D20267: Add HiDPI support for thumbnails.

small fixes

Apr 6 2019, 9:34 AM · Gwenview

Apr 5 2019

volkov updated the diff for D20267: Add HiDPI support for thumbnails.

fixed

Apr 5 2019, 6:59 PM · Gwenview
volkov added a comment to D9078: HiDPI fixes for thumbnails in gwenview.

Another approach: D20267

Apr 5 2019, 1:47 PM
volkov added a reviewer for D20267: Add HiDPI support for thumbnails: Gwenview.
Apr 5 2019, 1:47 PM · Gwenview
volkov requested review of D20267: Add HiDPI support for thumbnails.
Apr 5 2019, 1:46 PM · Gwenview

Apr 4 2019

volkov added a reviewer for D20251: Drop unnecessary PaintUtils::containingRect(): Gwenview.
Apr 4 2019, 3:13 PM · Gwenview
volkov requested review of D20251: Drop unnecessary PaintUtils::containingRect().
Apr 4 2019, 3:12 PM · Gwenview
volkov committed R260:97e7de52276b: HiDPI Support for Gwenview (authored by volkov).
HiDPI Support for Gwenview
Apr 4 2019, 3:06 PM
volkov closed D7581: HiDPI Support for Gwenview.
Apr 4 2019, 2:41 PM · Gwenview
volkov updated the diff for D7581: HiDPI Support for Gwenview.

add a comment about turning off opacity effect

Apr 4 2019, 12:11 PM · Gwenview

Apr 3 2019

volkov added a comment to D7581: HiDPI Support for Gwenview.

D9078 should fix thumbnails.

Apr 3 2019, 4:11 PM · Gwenview
volkov updated the diff for D7581: HiDPI Support for Gwenview.

turn off opacity effect for highdpi with Qt < 5.12.4

Apr 3 2019, 3:26 PM · Gwenview
volkov added inline comments to D7581: HiDPI Support for Gwenview.
Apr 3 2019, 11:16 AM · Gwenview

Apr 2 2019

volkov added a comment to D7581: HiDPI Support for Gwenview.

Currently there is a bug in Qt which makes QGraphicsOpacityEffect not working: https://codereview.qt-project.org/#/c/257946/

Apr 2 2019, 5:06 PM · Gwenview
volkov updated the diff for D7581: HiDPI Support for Gwenview.

rebase + refactoring

Apr 2 2019, 5:02 PM · Gwenview
volkov commandeered D7581: HiDPI Support for Gwenview.
Apr 2 2019, 4:57 PM · Gwenview

Apr 1 2019

volkov added a comment to D7581: HiDPI Support for Gwenview.

He also mentioned that those are minor issues that coulbe be fixed later.
This change is rather big and complicated, so it would be better to leave it with fixing one main issue on HiDPI displays.
@hetzenecker wrote: "Extracted QRect scaling to helper methods (there seems to be rounding errors now, those still have to be fixed)",
so I guess this is the only thing that needs to be checked for this patch.

Apr 1 2019, 7:45 PM · Gwenview
volkov added a comment to D7581: HiDPI Support for Gwenview.

Yes, I can do it. But what issues exactly?

Apr 1 2019, 4:27 PM · Gwenview
volkov added a comment to D7581: HiDPI Support for Gwenview.

I rebased and tested the patch on higdpi screen, it works.

Apr 1 2019, 2:38 PM · Gwenview
volkov added inline comments to D7581: HiDPI Support for Gwenview.
Apr 1 2019, 1:34 PM · Gwenview

Mar 26 2019

volkov added a comment to D19920: Add High DPI support.

Fix for tiny cards: D20061

Mar 26 2019, 12:11 PM
volkov requested review of D20061: Avoid tiny cards on high screen resolutions.
Mar 26 2019, 12:09 PM

Mar 21 2019

volkov updated the diff for D19920: Add High DPI support.

done

Mar 21 2019, 10:32 AM

Mar 20 2019

volkov added a comment to D19920: Add High DPI support.

This is strange. I can't reproduce it.
Could you provide more information?

  • Wayland or X11
  • version of Qt
  • env | grep QT
Mar 20 2019, 11:00 PM
volkov requested review of D19920: Add High DPI support.
Mar 20 2019, 4:38 PM

Mar 4 2019

volkov committed R119:14d6402abc34: [kcm/componentchooser] Remove unused ktimerdialog.{h,cpp} (authored by volkov).
[kcm/componentchooser] Remove unused ktimerdialog.{h,cpp}
Mar 4 2019, 7:23 PM
volkov closed D19496: [kcm/componentchooser] Remove unused ktimerdialog.{h,cpp}.
Mar 4 2019, 7:23 PM · Plasma

Mar 3 2019

volkov added a comment to D13901: Touch support for Gwenview.

+1 to adding gesture recognizers to KWidgetsAddons

Mar 3 2019, 8:56 PM · Gwenview
volkov added a reviewer for D19496: [kcm/componentchooser] Remove unused ktimerdialog.{h,cpp}: Plasma.
Mar 3 2019, 7:38 PM · Plasma