Get rid of workaround that prevents file dialog from being blocked
AbandonedPublic
Actions

Authored by volkov on Apr 8 2020, 5:11 PM.

Details

Reviewers

None

Group Reviewers

Summary

Invisible proxy QDialog blocks input when the native dialog is shown,
and the workaround is to show the native file dialog with a delay.
But it's not needed since Qt 5.13 after the
QPlatformDialogHelper::DialogIsQtWindow hint was introduced.

Diff Detail

Repository

R135 Integration for Qt applications in Plasma

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24953
Build 24971: arc lint + arc unit

volkov created this revision.Apr 8 2020, 5:11 PM

Restricted Application added a project: Plasma. · View Herald TranscriptApr 8 2020, 5:11 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

volkov requested review of this revision.Apr 8 2020, 5:11 PM

Harbormaster completed remote builds in B24953: Diff 79658.Apr 8 2020, 5:11 PM

volkov added a reviewer: Plasma.Apr 8 2020, 5:12 PM

DialogIsQtWindow was introduced in https://codereview.qt-project.org/c/qt/qtbase/+/144710

Moved to https://invent.kde.org/plasma/plasma-integration/-/merge_requests/1

Revision Contents
Changeset List

			Path	Packages
M			autotests/kfiledialog_unittest.cpp (14 lines)
M			autotests/kfiledialogqml_unittest.cpp (4 lines)
M			src/platformtheme/kdeplatformfiledialogbase.cpp (14 lines)
M			src/platformtheme/kdeplatformfiledialogbase_p.h (5 lines)
M			src/platformtheme/kdeplatformfiledialoghelper.h (2 lines)
M			src/platformtheme/kdeplatformfiledialoghelper.cpp (20 lines)

Commit	Tree	Parents	Author	Summary	Date
b9aa1b9ad7f4	e4596d07f8e5	9c9dcc864e3a	Alexander Volkov	Get rid of workaround that prevents file dialog from being blocked (Show More…)	Apr 8 2020, 4:18 PM