yuyichao (Yichao Yu)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 15 2017, 5:03 PM (113 w, 2 d)
Availability
Available

Recent Activity

Sep 11 2018

yuyichao committed R626:38117fb9e4f2: Bump version for 1.9 release (authored by yuyichao).
Bump version for 1.9 release
Sep 11 2018, 11:49 AM

Jun 26 2018

yuyichao accepted D13741: Switch from ENABLE_TEST to the ECM/CMake standard BUILD_TESTING.
Jun 26 2018, 4:21 PM

Feb 21 2018

yuyichao accepted D10725: QtCurve/KF5 : migrate away from KGlobalSettings::*Font() methods.
Feb 21 2018, 7:50 PM

Dec 11 2017

yuyichao committed R626:14eec32771fc: Introduce QTC_FALLTHROUGH (from LLVM) (authored by yuyichao).
Introduce QTC_FALLTHROUGH (from LLVM)
Dec 11 2017, 2:18 PM

Dec 8 2017

yuyichao added a comment to D9260: QtCurve: work around new QFont::setStyleName() side-effects (WIP/testing required).

Thanks, did you test?

Dec 8 2017, 6:35 PM
yuyichao accepted D9260: QtCurve: work around new QFont::setStyleName() side-effects (WIP/testing required).

It feels like the API could have hidden this completely and do all the dirty work when setting the style name... Anyway, the change looks right given the description of the problem and if this is what we have to deal with so be it........

Dec 8 2017, 4:59 PM

Dec 7 2017

yuyichao accepted D9229: QtCurve: avoid crashing/hanging on exit.
Dec 7 2017, 10:55 PM
yuyichao added a comment to D9229: QtCurve: avoid crashing/hanging on exit.

This is a qt bug that I can't reproduce and the change looks safe so LGTM....

Dec 7 2017, 10:55 PM
yuyichao added a comment to D9229: QtCurve: avoid crashing/hanging on exit.

In this case it's really an implementation detail, meant to unburden the main class which is becoming unwieldy, and make more isolated changes that don't require rebuilding the majority of the plugin each time you make a small change.

Dec 7 2017, 9:44 PM
yuyichao added a comment to D9229: QtCurve: avoid crashing/hanging on exit.

Implementation detail: the patch introduces a d pointer to a private subclass,

Dec 7 2017, 7:48 PM

Sep 2 2017

yuyichao added a comment to D7640: QtCurve: reduce progressbar timer overhead.

But I don't see how could do either for startTimer()?

Sep 2 2017, 10:27 AM · Plasma
yuyichao added a comment to D7640: QtCurve: reduce progressbar timer overhead.

Style::drawControl() is const, so one also has to move m_timer, m_progressBarAnimateTimer and m_progressBarAnimateFps to a private class, which in addition would have to have a q pointer and a startParentTimer() "proxy" so we can call Style::startTimer() from a const member function.

Sep 2 2017, 1:42 AM · Plasma
yuyichao accepted D7640: QtCurve: reduce progressbar timer overhead.
Sep 2 2017, 1:42 AM · Plasma

Jul 10 2017

yuyichao committed R626:b4d175d57a36: Translation fixes (authored by Abella).
Translation fixes
Jul 10 2017, 11:31 PM

Jun 26 2017

yuyichao accepted D6395: Search for kdelibs optionally.
Jun 26 2017, 10:15 PM

Jun 22 2017

yuyichao accepted D6341: Don't cache ENABLE_ variables.

LGTM.

Jun 22 2017, 12:51 PM
yuyichao added a comment to D6337: Consistently check for Qt dependencies.

Errors like: Error at qt5/CMakeLists.txt:34 (find_package):

Jun 22 2017, 12:33 PM
yuyichao added a comment to D6337: Consistently check for Qt dependencies.

Hmmm, option variable usually *are* stored in the cache (so that their setting persists between CMake invocations), but they indeed do have to be set to a default variable. It's possible my change didn't do that properly.

Jun 22 2017, 12:30 PM
yuyichao added a comment to D6337: Consistently check for Qt dependencies.

Also, what's the error mentioned in edebb86de2e2818f831cd2ac1967f12b83645b33 ? Does the find_package call errors even with QUIET specified? Conditionally running it should't cause much issue (qt4 is not the only one that's looking at kde4 settings but it probably doesn't matter too much at this point) the default value of enable_kde4/kf5 shouldn't need to depend on qt4/qt5 settings. That should remove cmake_dependent_option.

Jun 22 2017, 11:00 AM
yuyichao added a comment to D6337: Consistently check for Qt dependencies.

Hmm, why am I only hearing that now

Jun 22 2017, 10:45 AM
yuyichao added a comment to D6337: Consistently check for Qt dependencies.

automatic detection can still work.

Jun 22 2017, 10:31 AM
yuyichao requested changes to D6337: Consistently check for Qt dependencies.

It seems that there was an attempt to only do this if ENABLE_QT5 is not explicitly defined, but that test is flawed. There is no way to tell the difference between loading from a previous cache and the command line as -D is literally just setting a cache variable before it starts processing.

Jun 22 2017, 10:29 AM

Jun 4 2017

yuyichao committed R626:a1ec5f813fef: Bump version number to 1.9.0-rc1 (authored by yuyichao).
Bump version number to 1.9.0-rc1
Jun 4 2017, 7:21 PM

Jun 3 2017

yuyichao committed R626:63e4fac32877: A few additions to changelog (authored by yuyichao).
A few additions to changelog
Jun 3 2017, 7:17 PM
yuyichao committed R626:392e1db03470: Add missing <QtDebug> include when KDE integration is disabled. (authored by yuyichao).
Add missing <QtDebug> include when KDE integration is disabled.
Jun 3 2017, 7:09 PM

Jun 1 2017

yuyichao accepted D5909: Make X11 drop shadow size configurable (was: Revert huge shadow change).
Jun 1 2017, 1:07 PM

May 25 2017

yuyichao added inline comments to D5909: Make X11 drop shadow size configurable (was: Revert huge shadow change).
May 25 2017, 7:07 AM

May 18 2017

yuyichao requested changes to D5909: Make X11 drop shadow size configurable (was: Revert huge shadow change).

changed the shadow size from 6px to 30px

May 18 2017, 2:34 PM

May 6 2017

yuyichao added inline comments to D5702: avoid crash-on-exit issues during global destruction in stock Qt.
May 6 2017, 2:35 PM
yuyichao added inline comments to D5702: avoid crash-on-exit issues during global destruction in stock Qt.
May 6 2017, 1:50 PM
yuyichao accepted D5702: avoid crash-on-exit issues during global destruction in stock Qt.

Only very minor comments.

May 6 2017, 1:14 PM

Apr 27 2017

yuyichao accepted D5537: Add config option for SloppyMenuClose delay.

GTK config storing

Apr 27 2017, 5:20 PM

Apr 25 2017

yuyichao added a comment to D5537: Add config option for SloppyMenuClose delay.

The change LGTM. There's another copy in gtk2/common which should ideally be kept in sync (to not make it even harder to merge later) but that shouldn't cause any immediate problems since I don't think that version ever save config file.

Apr 25 2017, 2:28 PM

Apr 22 2017

yuyichao added a comment to D5537: Add config option for SloppyMenuClose delay.

I'm not familiar with what's the oldest Qt version that is still shipped by supported distributions but if

Apr 22 2017, 11:56 AM

Apr 21 2017

yuyichao accepted D5286: QtCurve alternative style for named menu section headers.

Assuming the coordinate calculations are correct (which I can never get right without seeing the result) this LGTM.

Apr 21 2017, 3:53 PM
yuyichao added a comment to D5537: Add config option for SloppyMenuClose delay.

I would, but this is new in Qt5.5

Apr 21 2017, 3:41 PM
yuyichao accepted D5539: Guard against calling.

Looks correct.

Apr 21 2017, 2:54 PM

Apr 15 2017

yuyichao accepted D5470: Make build against Qt 5.9.0.
Apr 15 2017, 10:49 PM

Mar 30 2017

yuyichao accepted D5178: QtCurve/Qt5 : further KF5 adaptation.

Is this the new review platform?

Mar 30 2017, 2:54 PM

Feb 15 2017

yuyichao added a comment to D3602: Cycle between windows of the same desktop on switch.

While this proposed behavior might indeed not be expected by everyone, this is not really a problem: Those who would not expect the wrap-around behavior would not expect anything to happen at all, and therefore not even press the shortcut if they are at the left-/rightmost window. If they do press it anyway (maybe by accident), they might be surprised at first, but it will be easy to them to get back to where they were before, and then they can still decide whether or not they want to use the shortcut in such situations in the future.

Feb 15 2017, 5:14 PM · KWin