- User Since
- Feb 15 2017, 5:03 PM (147 w, 5 h)
Jul 24 2019
Not necessarily, QStringList::at(0) could return an empty QString instance if the list is empty.
Didn't know this can happen and lgtm.
Jun 5 2019
Sep 11 2018
Jun 26 2018
Feb 21 2018
Dec 11 2017
Dec 8 2017
Thanks, did you test?
It feels like the API could have hidden this completely and do all the dirty work when setting the style name... Anyway, the change looks right given the description of the problem and if this is what we have to deal with so be it........
Dec 7 2017
This is a qt bug that I can't reproduce and the change looks safe so LGTM....
In this case it's really an implementation detail, meant to unburden the main class which is becoming unwieldy, and make more isolated changes that don't require rebuilding the majority of the plugin each time you make a small change.
Implementation detail: the patch introduces a d pointer to a private subclass,
Sep 2 2017
But I don't see how could do either for startTimer()?
Style::drawControl() is const, so one also has to move m_timer, m_progressBarAnimateTimer and m_progressBarAnimateFps to a private class, which in addition would have to have a q pointer and a startParentTimer() "proxy" so we can call Style::startTimer() from a const member function.
Jul 10 2017
Jun 26 2017
Jun 22 2017
Errors like: Error at qt5/CMakeLists.txt:34 (find_package):
Hmmm, option variable usually *are* stored in the cache (so that their setting persists between CMake invocations), but they indeed do have to be set to a default variable. It's possible my change didn't do that properly.
Also, what's the error mentioned in edebb86de2e2818f831cd2ac1967f12b83645b33 ? Does the find_package call errors even with QUIET specified? Conditionally running it should't cause much issue (qt4 is not the only one that's looking at kde4 settings but it probably doesn't matter too much at this point) the default value of enable_kde4/kf5 shouldn't need to depend on qt4/qt5 settings. That should remove cmake_dependent_option.
Hmm, why am I only hearing that now
automatic detection can still work.
It seems that there was an attempt to only do this if ENABLE_QT5 is not explicitly defined, but that test is flawed. There is no way to tell the difference between loading from a previous cache and the command line as -D is literally just setting a cache variable before it starts processing.
Jun 4 2017
Jun 3 2017
Jun 1 2017
May 25 2017
May 18 2017
changed the shadow size from 6px to 30px
May 6 2017
Only very minor comments.
Apr 27 2017
GTK config storing
Apr 25 2017
The change LGTM. There's another copy in gtk2/common which should ideally be kept in sync (to not make it even harder to merge later) but that shouldn't cause any immediate problems since I don't think that version ever save config file.
Apr 22 2017
I'm not familiar with what's the oldest Qt version that is still shipped by supported distributions but if
Apr 21 2017
Assuming the coordinate calculations are correct (which I can never get right without seeing the result) this LGTM.
I would, but this is new in Qt5.5
Apr 15 2017
Mar 30 2017
Is this the new review platform?