Connect slots explicitly instead of using auto-connections
AbandonedPublic
Actions

Authored by volkov on Nov 2 2018, 4:06 PM.

Details

Reviewers

None

Group Reviewers

Frameworks

Summary

Auto-connections is bad practice cause object renames break code
and it can't be detected at compile time.

Repository

R241 KIO

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 4477
Build 4495: arc lint + arc unit

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

volkov requested review of this revision.Nov 2 2018, 4:06 PM

			Path	Packages
M			src/kcms/kio/cache.h (2 lines)
M			src/kcms/kio/cache.cpp (4 lines)
M			src/kcms/kio/kcookiesmanagement.h (12 lines)
M			src/kcms/kio/kcookiesmanagement.cpp (23 lines)
M			src/kcms/kio/kproxydlg.h (13 lines)
M			src/kcms/kio/kproxydlg.cpp (32 lines)
M			src/kcms/kio/useragentdlg.h (16 lines)
M			src/kcms/kio/useragentdlg.cpp (58 lines)