Add draw-arrow icons
ClosedPublic

Authored by trickyricky26 on Oct 11 2019, 10:21 AM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Commits
R266:b55f299b1733: Add draw-arrow icons
Summary

This patch adds draw-highlight icons requested by Okular for D15580.

The design is based on draw-line with an arrowhead. I am not quite sure about the naming as there are already draw-arrow-{up,down,forward,back} icons that symlink to the standard arrow icons. I could not find an application where these are used.

CCBUG: 408283

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trickyricky26 created this revision.Oct 11 2019, 10:21 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 11 2019, 10:21 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
trickyricky26 requested review of this revision.Oct 11 2019, 10:21 AM
trickyricky26 edited the summary of this revision. (Show Details)Oct 11 2019, 10:24 AM
trickyricky26 edited the test plan for this revision. (Show Details)
trickyricky26 added a reviewer: VDG.
ndavis accepted this revision.Oct 11 2019, 6:16 PM
ndavis added a subscriber: ndavis.

The design is based on draw-line with an arrowhead.

I think this is a good design. I noticed that LibreOffice already uses a different icon for drawing arrows, but I think this one looks nicer.

I am not quite sure about the naming as there are already draw-arrow-{up,down,forward,back} icons that symlink to the standard arrow icons. I could not find an application where these are used.

I think you chose the right name. It could be that those icons are wrong in the first place.

This revision is now accepted and ready to land.Oct 11 2019, 6:16 PM
Closed by commit R266:b55f299b1733: Add draw-arrow icons (authored by Rafael Brandmaier <rafael.brandmaier@kdemail.net>). · Explain WhyOct 13 2019, 7:16 PM
This revision was automatically updated to reflect the committed changes.