| ngraham | |
| rooty |
| VDG |
This patch updates the 16px player-volume-muted to be a symlink to the corresponding status icon. It also changes the 24px audio-volume-muted action icons to the new muted symbol introduced in D17220: Improve symbolism for off and muted status icon.
It also adjust the opacity of the inactive sound waves in the 24px audio-volume-low and audio-volume-medium icons to 0.25 to match the Breeze Plasma theme.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Can you verify the permissions of these files? when I apply this patch, build it, and run the tests, I get permissions errors:
Running tests...
Test project /home/dev/kde/build/breeze-icons
CMake Error: Cannot open file for write: /home/dev/kde/build/breeze-icons/Testing/Temporary/LastTest.log.tmp
CMake Error: : System Error: Permission denied
Problem opening file: /home/dev/kde/build/breeze-icons/Testing/Temporary/LastTest.log
Cannot create log file: LastTest.log
Start 1: appstreamtest
1/5 Test #1: appstreamtest .................... Passed 0.49 sec
Start 2: symlink
2/5 Test #2: symlink .......................... Passed 0.13 sec
Start 3: newline
3/5 Test #3: newline .......................... Passed 0.06 sec
Start 4: dupe
4/5 Test #4: dupe .............................***Failed 1.32 sec
Start 5: scalable
5/5 Test #5: scalable ......................... Passed 0.05 sec
80% tests passed, 1 tests failed out of 5
Total Test time (real) = 2.05 sec
The following tests FAILED:
CMake Error: Cannot open file for write: /home/dev/kde/build/breeze-icons/Testing/Temporary/LastTestsFailed.log.tmp
CMake Error: : System Error: Permission denied
Problem opening file: /home/dev/kde/build/breeze-icons/Testing/Temporary/LastTestsFailed.log
Cannot create log file: LastTestsFailed.log
4 - dupe (Failed)
Errors while running CTest
Makefile:118: recipe for target 'test' failed
make: *** [test] Error 8
dev@dev-pc:~/kde/src/breezeEverything works fine if I build-and-test with git master, so I'm lead to believe that something with this patch is wonky.