Update elisa icon
ClosedPublic

Authored by astippich on Oct 12 2019, 6:29 PM.

Details

Summary

Since D12992 seems stuck, update the current icon
a little bit and add a blueish gradient to the
icon. Also remove the ugly text for the 48px icon,
since it was not readable anyway at small sizes.

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Oct 12 2019, 6:29 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 12 2019, 6:29 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Oct 12 2019, 6:29 PM

old icons
22px


48px

updated icons
22px


48px

GB_2 added a subscriber: GB_2.Oct 12 2019, 6:34 PM

I don't think it makes sense to change the icon here if D12992 already does it. If you want it to progress then take over the revision and work on the completely new style there or make a ping comment and have some patience.

I have no intention on taking over D12992 as I would like rather like to code for Elisa. I am no designer.
I was unsatisfied with the icon and @mgallien agreed on some slight adjustments to the current one.
D12992 has been around for ages. I hope that this incremental update can be agreed upon faster and land for next frameworks release. Especially I find the "Elisa" text ugly and worth removing it quickly.

Can you make the gradient extend all the way to the top of the white center area?

I have no intention on taking over D12992 as I would like rather like to code for Elisa. I am no designer.
I was unsatisfied with the icon and @mgallien agreed on some slight adjustments to the current one.
D12992 has been around for ages. I hope that this incremental update can be agreed upon faster and land for next frameworks release. Especially I find the "Elisa" text ugly and worth removing it quickly.

I am in support of the work that is done here. Thanks @astippich

ngraham accepted this revision.Oct 13 2019, 1:39 PM

Lovely!

This revision is now accepted and ready to land.Oct 13 2019, 1:39 PM
trickyricky26 requested changes to this revision.Oct 13 2019, 7:28 PM
trickyricky26 added a subscriber: trickyricky26.

Please optimize the SVG files using one of these methods: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

About the design itself, I think the area where the "Elisa" branding was previously looks a bit empty now. I would suggest you either find some nice pattern to put there or simply center the tape window in the colored area.
Overall I think this is a good improvement, the letters in that icon were what kept me from putting Elisa permanently in my dock :P

This revision now requires changes to proceed.Oct 13 2019, 7:28 PM

This is with the tape window moved up 1px


When I look at images of real cassettes, they are not centered, hence why I only did this slight adjustment.
If everyone is okay with this, I will update the revision with the optimized svgs.
I don't think that filling this space is useful.

This is with the tape window moved up 1px


When I look at images of real cassettes, they are not centered, hence why I only did this slight adjustment.
If everyone is okay with this, I will update the revision with the optimized svgs.
I don't think that filling this space is useful.

That's just fine IMO!

mgallien accepted this revision.Oct 16 2019, 8:47 PM

Thanks

ngraham accepted this revision.Oct 16 2019, 8:55 PM

Let's get this in!

astippich updated this revision to Diff 68192.Oct 17 2019, 7:01 PM
  • update and save as optimized svg
ngraham accepted this revision.Oct 17 2019, 7:07 PM
trickyricky26 accepted this revision.Oct 17 2019, 7:28 PM
This revision is now accepted and ready to land.Oct 17 2019, 7:28 PM
This revision was automatically updated to reflect the committed changes.