Adds an app icon for @hein's upcoming Kirogi app.
Details
- Reviewers
hein ngraham - Group Reviewers
VDG - Commits
- R266:faff4ff246af: Add app icon for the Kirogi Drone control app
The Kirogi icon:
At 100% size:
Diff Detail
- Repository
- R266 Breeze Icons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
@trickyricky26 It's great! What do you think about adding the detailed SVG as 256 version?
I'd say it's up to the Breeze maintainers. From my end I'm very interested in the app having a Breeze-compatible icon, because I'd like it to integrate well with KDE's workspaces and other apps. Review by the Breeze community is very appreciated to help with that. Application code needs to ship the icon anyway though for systems that don't have the theme and can't be reasonably expected to provide every app icon, so it's not vital to be included with the theme.
the icon theme can be considered to be VDG-maintained these days, andI think this passes the visual design test, but also the most important thing is that you as the app author like it!
However if this is the actual icon you want to ship with the app, do we even need it to be in the breeze-icons framework? If it's the exact same icon, and you're going to ship it in your app's packaging/bundle anyway, I'm wondering what the value is.
Should I land this or abandon it?
It doesn't really make a difference if the icon is in Breeze in addition to being shipped with the app, but IMO it would also be strange to not have this Breeze-style icon for a KDE app in Breeze.
kde.org/applications use the icons from breeze-icons. So I think it's worth adding to breeze-icons or improving how the icon are fetched in kde.org/applications.