Add format-text-underline-squiggle actions icons
ClosedPublic

Authored by trickyricky26 on Sep 24 2019, 11:07 AM.

Details

Summary

Add format-text-underline-squiggle (better name suggestions welcome!) icons as requested in https://bugs.kde.org/show_bug.cgi?id=408283 (not specifying the BUG keyword, since this doesn't add all requested icons).

The curve of the underline is not great, but the best I could come up with after many tries, and I made the "U" in the 16px version 2px less tall compared to the format-text-underline icon, not sure if that should be changed there, too.

CCBUG: 408283

Test Plan

The new format-text-underline-squiggle icons:

For reference, the format-text-underline icons:

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trickyricky26 created this revision.Sep 24 2019, 11:07 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 24 2019, 11:07 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
trickyricky26 requested review of this revision.Sep 24 2019, 11:07 AM
trickyricky26 edited the summary of this revision. (Show Details)Sep 24 2019, 11:15 AM
trickyricky26 edited the test plan for this revision. (Show Details)
trickyricky26 added a reviewer: VDG.
ngraham edited the summary of this revision. (Show Details)Sep 24 2019, 2:03 PM

Lol "squiggle." I can't think of anything better either.

Maybe the stroke would look better with butt-style ends? Like this:

  • Use butt line ending for slightly nicer asthetics
ngraham accepted this revision.Sep 24 2019, 6:20 PM
ngraham added a subscriber: ndavis.
This revision is now accepted and ready to land.Sep 24 2019, 6:20 PM
ndavis added a comment.EditedSep 25 2019, 1:11 AM

I have some improvements to the squiggle, but unfortunately, I have no internet in my house except on my phone until the 27th.

basically, I

  • made a rectangle
  • gave it a stroke
  • shrunk the height to fit in the 12x3 area under the U
  • used the function plotter to generate a sine wave
    • adjusted the width and function x/y parameters of the function plotter until I got exactly the right length from the low point (left) to the high point (right)
  • converted the stroke to a path
  • cut it at the low point (left)/high point (right)
  • simplified the path

this probably could have been simpler

This comment was removed by ndavis.
This comment was removed by ndavis.

16px

I have some improvements to the squiggle, but unfortunately, I have no internet in my house except on my phone until the 27th.

basically, I

  • made a rectangle
  • gave it a stroke
  • shrunk the height to fit in the 12x3 area under the U
  • used the function plotter to generate a sine wave
    • adjusted the width and function x/y parameters of the function plotter until I got exactly the right length from the low point (left) to the high point (right)
  • converted the stroke to a path
  • cut it at the low point (left)/high point (right)
  • simplified the path

    this probably could have been simpler

I tried to do this with a Sine wave, but I couldn't get it to generate a fitting wave, so I guess I abandoned that approach prematurely. I'll try again with some of your parameters.

trickyricky26 planned changes to this revision.Sep 25 2019, 11:02 AM
  • Use sine wave as suggested by ndavis
This revision is now accepted and ready to land.Sep 25 2019, 2:15 PM
trickyricky26 edited the test plan for this revision. (Show Details)Sep 25 2019, 2:16 PM
ngraham added a comment.EditedSep 25 2019, 10:38 PM

Now the butt ends are gone again. :)

Now the butt ends are gone again. :)

Yes, I think it makes more sense for this underline to be a visual crop of a longer one as they would appear in eg. LibreOffice Writer. It should also make for a tiny bit more contrast at the ends at 100%

ngraham accepted this revision.Sep 26 2019, 1:39 PM

All right, ship it!

Closed by commit R266:477729808ef6: Add format-text-underline-squiggle actions icons (authored by Rafael Brandmaier <rafael.brandmaier@kdemail.net>). · Explain WhySep 26 2019, 2:47 PM
This revision was automatically updated to reflect the committed changes.