Differential D28407

Fix configure when xmllint is not present
ClosedPublic
Actions

Authored by tcberner on Mar 29 2020, 2:58 PM.

Details

Reviewers
kossebau
Commits
R266:23b32c25f0be: Fix configure when xmllint is not present
Summary

The breeze-validate-svg target is only generated when xmllint is found.
breeze-generate-24px-versions cannot be added as a dependency, unless
the target exists.

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcberner created this revision.Mar 29 2020, 2:58 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 29 2020, 2:58 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
tcberner requested review of this revision.Mar 29 2020, 2:58 PM
kossebau accepted this revision.Mar 29 2020, 3:56 PM
kossebau added a subscriber: ngraham.

Indeed was missing from the hotfix, thanks for catching.

@ngraham How far have you come with learning cmake to clean up all this? :)

This revision is now accepted and ready to land.Mar 29 2020, 3:56 PM
Closed by commit R266:23b32c25f0be: Fix configure when xmllint is not present (authored by tcberner). · Explain WhyMar 29 2020, 4:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Micons-dark/CMakeLists.txt (4 lines)
Micons/CMakeLists.txt (4 lines)

Diff 78801

View Options

icons-dark/CMakeLists.txt

Loading...
View Options

icons/CMakeLists.txt

Loading...