Define QT.phonon4qt5.module = phonon4qt5 for Qt5-5.12.1
ClosedPublic

Authored by tcberner on Mon, Feb 11, 6:20 AM.

Diff Detail

Repository
R487 Phonon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcberner created this revision.Mon, Feb 11, 6:20 AM
Owners added a reviewer: Restricted Owners Package.Mon, Feb 11, 6:20 AM
tcberner requested review of this revision.Mon, Feb 11, 6:20 AM

Probably should set module like in https://phabricator.kde.org/D18243

Probably should set module like in https://phabricator.kde.org/D18243

Do you mean using that ecm macro?

sitter accepted this revision.Tue, Feb 12, 10:34 AM

No, what I meant was do it like the other diff. Though now I realize that I might be going mad as they are doing the same thing... perhaps I was reviewing while still asleep.

The diff looks perfect.

This revision is now accepted and ready to land.Tue, Feb 12, 10:34 AM
This revision was automatically updated to reflect the committed changes.