Ensure defintion of XDG_DATA_DIRS
Needs RevisionPublic

Authored by tcberner on Sun, Oct 20, 5:28 PM.

Details

Reviewers
dfaure
apol
Group Reviewers
FreeBSD
Summary

Similar to XDG_DATA_DIRS defaulting to KDE_INSTALL_FULL_DATAROOTDIR, and
some sensible constants, also make XDG_CONFIG_DIRS default to KDE_INSTALL_FULL_CONFDIR
and some sensible constants.

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18154
Build 18172: arc lint + arc unit
tcberner created this revision.Sun, Oct 20, 5:28 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Oct 20, 5:28 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
tcberner requested review of this revision.Sun, Oct 20, 5:28 PM
dfaure requested changes to this revision.Sun, Oct 20, 5:56 PM

Bug in the commit log: s/ also make XDG_DATA_DIRS/ also make XDG_CONFIG_DIRS/

startkde/startplasma.cpp
195

I see nothing FreeBSD specific about this, I suggest simplifying the comment.

This revision now requires changes to proceed.Sun, Oct 20, 5:56 PM
tcberner updated this revision to Diff 68731.Fri, Oct 25, 6:01 AM

Fix comment and commit message.

tcberner updated this revision to Diff 68732.Fri, Oct 25, 6:02 AM
tcberner edited the summary of this revision. (Show Details)

Update commit message in diff.

dfaure requested changes to this revision.Fri, Oct 25, 7:55 AM

Please make sure the first line of the commit log says CONFIG and not DATA, too (the phab title still says DATA).

startkde/startplasma.cpp
197

Wait, where does /usr/local/etc/xdg come from? https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html says the default is only /etc/xdg.

This revision now requires changes to proceed.Fri, Oct 25, 7:55 AM
adridg added a subscriber: adridg.Fri, Oct 25, 11:25 AM
adridg added inline comments.
startkde/startplasma.cpp
197

On FreeBSD (other BSD's, too), /etc is for the base system only, and all user-add-ons go in *$LOCALBASE*, usually /usr/local .. so XDG stuff, which is a user-add-on, goes into /usr/local/etc. Even our /etc/os-release is in /usr/local/etc/os-release (and Frameworks are suitably patched for that).

Some BSD derivatives are less dogmatic about /etc, but not us.