Yes, thanks to Kai Knoblich we were able to update to a more recent webengine quite some time ago -- so should be all good :)

Update commit message

Looks good to me. FreeBSD CI already has telepathy-qt5-0.9.8 installed.

See [1]

05:46:54  -- Found libgmock: /usr/local/include/gmock, /usr/local/lib/libgmock.so;/usr/local/lib/libgtest.so;/usr/lib/libpthread.so
[...]
05:47:24  In file included from /usr/home/jenkins/workspace/Extragear/amarok/kf5-qt5 FreeBSDQt5.13/tests/core/logger/TestLogger.cpp:21:
05:47:24  /usr/home/jenkins/workspace/Extragear/amarok/kf5-qt5 FreeBSDQt5.13/tests/mocks/MockLogger.h:20:10: fatal error: 'gmock/gmock.h' file not found
05:47:24  #include <gmock/gmock.h>
05:47:24           ^~~~~~~~~~~~~~~
05:47:24  1 error generated.

• Add .arcconfig

I think it would be preferable if the cmake were fixed to properly respect the values read via the find package call. It's an easy fix after all.

Yes, all the patch-* in the files direcotry in the above link get applied before building.

We have it fixed like so in the tree:
https://github.com/freebsd/freebsd-ports-kde/blob/master/graphics/digikam/files/patch-core_CMakeLists.txt

@cgilles https://build.kde.org/job/Extragear/job/digikam/job/kf5-qt5%20FreeBSDQt5.13/8/console opencv has been installed -- failures are now the missing link directories (basically -L/usr/local/lib)

Sure, I'll do that later today.

Update commit message in diff.

Fix comment and commit message.

@adridg I've addressed your comments [finally].

• procstat: add FindProcstat.cmake
• procstat: add procstat backend
• procstat: add procstat option
• procstat: add linkage for procstat backend

See build 160

00:26:54  ==654==ERROR: AddressSanitizer: heap-use-after-free on address 0x60700075d3c8 at pc 0x00080264d0fb bp 0x7fffdddec670 sp 0x7fffdddec668
00:26:54  READ of size 4 at 0x60700075d3c8 thread T18
00:26:54      #0 0x80264d0fa in std::__1::__atomic_base<int, false>::load(std::__1::memory_order) const /usr/include/c++/v1/atomic:926:17
00:26:54      #1 0x80264d0fa in int QAtomicOps<int>::loadAcquire<int>(std::__1::atomic<QAtomicOps<int>::loadAcquire<int>> const&) /usr/local/include/qt5/QtCore/qatomic_cxx11.h:239
00:26:54      #2 0x80264c504 in QBasicAtomicInteger<int>::loadAcquire(void) const /usr/local/include/qt5/QtCore/qbasicatomic.h:106:51
00:26:54      #3 0x8026f3b44 in QBasicAtomicInteger<int>::operator(cast)(int, void) const /usr/local/include/qt5/QtCore/qbasicatomic.h:108:48
00:26:54      #4 0x8026f24dc in KDevelop::FileManagerListJob::startNextJob(void)::$_0::operator()(KDevelop::Path const&) const /usr/home/jenkins/workspace/KDevelop/kdevelop/kf5-qt5 FreeBSDQt5.12/kdevplatform/project/filemanagerlistjob.cpp:122:17
00:26:54      #5 0x8026f1daa in QtConcurrent::StoredFunctorCall1<void, KDevelop::FileManagerListJob::startNextJob(void)::$_0, KDevelop::Path>::runFunctor(void) /usr/local/include/qt5/QtConcurrent/qtconcurrentstoredfunctioncall.h:432:34
00:26:54      #6 0x80269c364 in QtConcurrent::RunFunctionTask<void>::run(void) /usr/local/include/qt5/QtConcurrent/qtconcurrentrunbase.h:136:19
00:26:54      #7 0x80269c528 in virtual function non-virtual override offset : -16 QtConcurrent::RunFunctionTask<void>::run(void) /usr/local/include/qt5/QtConcurrent/qtconcurrentrunbase.h
00:26:54      #8 0x807716d6f in QThreadPoolThread::run(void) /wrkdirs/usr/ports/devel/qt5-core/work/qtbase-everywhere-src-5.12.2/src/corelib/thread/qthreadpool.cpp:99:24
00:26:54      #9 0x80770d8d4 in QThreadPrivate::start(void*) /wrkdirs/usr/ports/devel/qt5-core/work/qtbase-everywhere-src-5.12.2/src/corelib/thread/qthread_unix.cpp:361:14
00:26:54      #10 0x807379775  (/lib/libthr.so.3+0xd775)

I think the issue was that there was no llvm-symbolizer binary found on the system, as in FreeBSD 12.0 it seems none is provided by the base system, so we only had the versioned ones llvm-symbolizer50 and llvm-symbolizer60 available in $PATH.

Gargh, the code kdelibs code formatter changed a lot more in kprocesslist_unix_proc.cpp than wanted :/

• Switch to 2-Clause
• Move procstat backend into its own file
• Remove now unnecessary config-kprocesslist.cmake

Remove commented line.

The FreeBSD builders now have the package pulseaudio-qt installed (also libfakekey).

I'll add it later.

Simply set NAMES EGL/egl.h and fixup the header version check.

In D19075#413462, @hausmann wrote:

I think that it should be NAMES EGL/egl.h

Store the path gathered via pkgconfig in COMPLETE_EGL_INCLUDE_DIR and
use its parent directory for EGL_INCLUDE_DIR.

Possibly the returend EGL_INCLUDE_DIR should possibly be stripped of the suffix too, as most will proably include 'EGL/egl.h', and not 'egl.h', I guess?

In D18960#411562, @kossebau wrote:

Seems this is sadly breaking something for FreeBSD though, see
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console

In D18919#409765, @sitter wrote:

Probably should set module like in https://phabricator.kde.org/D18243

quazip-0.7.3 is now installed.

FreeBSD already has 5.12 on CI

• add include directory
• fix HAVE_epoll -> epoll_FOUND

Thanks :)

In D17863#384145, @cgiboudeaux wrote:

Why not fixing kstars instead?

See: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230603

In D17606#377854, @dvratil wrote:

I've recently run into the same problem on Akonadi on Windows, ended up allowing C++17 on Windows only and shipping a C++14-compatible implementation of C++17 optional in 3rdparty for everyone else.

Maybe we could just get rid of the `optional` in this agent until we can switch to C++17 proper. I hate not having it, but it's just one or two occurrences here and probably not worth the magic to satisfy all compilers.

In D16608#352679, @cgilles wrote:

No problem to patch git/master

Gilles Caulier

Cool, this should also benefit FreeBSD, where we have
Qt 5.11.2/QtWebengine 5.9.4