- User Since
- Feb 6 2017, 6:40 PM (147 w, 2 d)
Jan 13 2018
Dec 10 2017
Nov 29 2017
Nov 21 2017
Nov 19 2017
Nov 17 2017
Nov 16 2017
Nov 15 2017
Nov 14 2017
Nov 13 2017
I'm afraid your's truly might take a bit of the blame. The basis of the logic was likely my original Python code, which did just enough to make Ubuntu work.
Nov 12 2017
Nov 11 2017
Nov 9 2017
Nov 8 2017
Nov 7 2017
Nov 5 2017
Oct 13 2017
Sep 8 2017
My suggestion would be to focus any review efforts in this order:
My comments here are phrased as if this SIP-based approach was the solution eventually adopted (cppyy might be different). With that said...
Apr 8 2017
I did some negative testing, and from what I can see, 3.8 might well be OK
for the ECM fork. My version depends on 3.9 (for example, there are some
new constants defined by clang which I use), but I've no idea if this will
ever be merged.
Apr 3 2017
Fwiw, I think that a specific version check may not be needed. The original
code I wrote, which I assume Steve may have simply carried forward in the
cmake ecm logic, DID have a version check but only because the python
bindings were newish circa libclang 3.8.
Feb 12 2017
I think the scope of the changes in this commit are perfectly reasonable. I don't think it is unreasonable to group them either.
The PEP-8 changes are some blank line changes.