Split okular-backends from okular
ClosedPublic
Actions

Authored by jbbgameich on Feb 19 2020, 3:00 PM.

Details

Reviewers

sitter
• jriddell

Summary

This is required to install the backends as a dependency of okular-mobile, otherwise it would be left without backends or depend on the desktop ui.

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

jbbgameich requested review of this revision.Feb 19 2020, 3:00 PM

jbbgameich created this revision.

Harbormaster completed remote builds in B22684: Diff 76003.Feb 19 2020, 3:00 PM

jbbgameich added reviewers: sitter, • jriddell.Feb 19 2020, 3:01 PM

LGTM, but doesn't okular-mobile Recommend okular for that very reason?

In D27506#614251, @sitter wrote:

LGTM, but doesn't okular-mobile Recommend okular for that very reason?

Installing the desktop ui on the phone is not the best idea. Seemingly we also use --no-install-recommends there. Should I remove the recommends line from okular-mobile then?

rebase on Neon/stable

Remove okular recommendation from okular-mobile

mind the comment about version, otherwise shipit

debian/control
122	If you use `${source:Version}~ciBuild` instead of the hardcoded version, the CI will figure out what version to actually use and fixate it at the next release. Same for the Replaces line.

This revision is now accepted and ready to land.Feb 20 2020, 2:26 PM

Use ci version

jbbgameich marked an inline comment as done.Feb 20 2020, 6:27 PM

Which branch should I land this onto?

Neon/unstable I guess

was landed already. closing

Revision Contents
Changeset List

		Path
M		debian/control (41 lines)
A	M	debian/okular-backends.install (63 lines)
V		debian/{okular-backends.mime ← okular.mime}
M		debian/okular.install (63 lines)
V		debian/{okular.mime → okular-backends.mime}

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	76003	0fe32fd		Feb 19 2020, 3:00 PM	★	★
Diff 2	76005			Feb 19 2020, 3:11 PM	★	★
Diff 3	76006			Feb 19 2020, 3:14 PM	★	★
Diff 4	76064			Feb 20 2020, 6:26 PM	★	★