Eeeeh, I actually wanna get away from injecting env vars into firefox with firefox 78. Surely the right approach would be for firefox to check what WM it runs under and then conditionally enable this magic?

The right approach would be for the GTK developers to accept Vlad's patch to fix it for everyone, but of course nothing's easy with those people. :(

Given that Neon is a KDE-focused environment, I don't think there's a huge risk of people not using KWin.

It's not about the risk, it's the fact that injecting env vars into firefox is a fragile hack. I mean, it's always a hack, it just happens to be particularly fragile the way it is currently done because we only force portals on firefox. Perhaps we could set it globally, but are we sure this doesn't mess with thunderbird?

Actually, about setting it globally, does it not cause adverse side effects when used with wayland? See, it's a right worry :(

In T13335#234059, @sitter wrote:

It's not about the risk, it's the fact that injecting env vars into firefox is a fragile hack. I mean, it's always a hack, it just happens to be particularly fragile the way it is currently done because we only force portals on firefox. Perhaps we could set it globally, but are we sure this doesn't mess with thunderbird?

Yes, setting it globally was my idea, and that's what I run with on my system. I can confirm that it plays nice with Thunderbird and does not cause any regressions on Wayland. In fact I'm pretty sure it's a no-op on Wayland since xinput2 is used by default there for Firefox anyway.

Given that Neon is a KDE-focused environment, I don't think there's a huge risk of people not using KWin.

Your assumption is good, but I still think that this is dangerous var should be applied only under KWin, since people may still install Gnome or other DEs/WMs on Neon. Me, for example is actually doing this.

Out of curiosity, why would you do that? What's the advantage of Neon over a different distro if you're not going to use a different DE or window manager?

Users are free to do that because Neon has Ubuntu archives enable, which has a lot of desktops available, so there's non-zero probability of breaking Firefox for those people that like evaluating different DEs and switch between them some times. Advantage of Neon in this case will be to have latest KDE. One may also enable Mint archives and get the latest Cinnamon and MATE as well. Enable some ppa or some repo and you get the latest packages for different DE.

Sure, anything's possible. :) My point was that Neon is explicitly a KDE-centric distro. Breakage in non-KDE software is expected and normal; it's not supported at all. If there's a viable way to enable this only when using KWin, that would be idea. If not, I personally still think it's worth doing anyway to improve the experience for neon's target audience of KDE Plasma users.

I feel like we've had env exporting somewhere in startplasma