Fix and normalize license in .desktop files
ClosedPublic

Authored by sebas on Jul 11 2017, 12:26 PM.

Details

Summary

The license is often specificed as (L)GPL, which means v2, while the
actual code is usually v2 or v2+. This patch reflects that.

Test Plan

checked source files, compared with kaboutdata.cpp keys

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sebas created this revision.Jul 11 2017, 12:26 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 11 2017, 12:26 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a subscriber: mart.Jul 13 2017, 8:18 AM

+1 for all the ones from me

mart accepted this revision.Jul 13 2017, 8:44 AM
This revision is now accepted and ready to land.Jul 13 2017, 8:44 AM
broulik accepted this revision.Jul 13 2017, 8:47 AM
sitter accepted this revision.Jul 13 2017, 12:39 PM

Thanks for doing the leg work.

mak added a subscriber: mak.Jul 13 2017, 1:02 PM

Is there any reason not to use the SPDX license IDs here? => https://spdx.org/licenses/ (e.g. GPL-2.0+ in this case).
In any case, this patch makes things way better, so +1 from me :-)

Is there any reason not to use the SPDX license IDs here?

The values are the ones in KAboutLicense from what I can tell.

Yeah, legacy reasons. I am looking into ways to change this moving forward though. Not sure if the cost-benefit will be reasonable, but it's on my radar and at a glance should be doable in some form or fashion.

This revision was automatically updated to reflect the committed changes.