kpat is way too verbose and can blow up one's xsession-errors. to mitigate
move all the verbosity into the log category (that is not enabled for debug
level by default)
BUG: 407854
FIXED-IN: 20.04
Details
Details
this change was scripted and could well blow up, though terribly unlikely. I've confirmed it still builds and starts and generally works though
Diff Detail
Diff Detail
- Repository
- R410 KPatience
- Branch
- release/20.04
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 24981 Build 24999: arc lint + arc unit
Comment Actions
Hi!
Changing fprintf(stdout to KPAT_LOG in main.cpp is likely wrong because it interferes with the output of the commandline range solver. The other changes seem fine.
Comment Actions
Only the ones inside the if ( !testdir.isEmpty() ) { branch though, right? The others I'm not sure are for parsing.
Comment Actions
@sitter : you also need to revert the changes inside the main.cpp's if (ok) conditional. Also note that the GolfSolver autotest fails with your patch if one configures kpat to build using this lib of mine: https://www.shlomifish.org/open-source/projects/black-hole-solitaire-solver/ .