Feed Advanced Search

Fri, Apr 12

sitter added a comment to T3633: catch apt upgrade to point to dist-upgrade.

Apt overlay tech landing in neon/unstable momentarily. Going to move to user editions if unstable testing reveals no major snags.

Fri, Apr 12, 1:52 PM · Neon
sitter added a comment to D20429: add apt overlays to prevent running 'upgrade' on neon systems.

Approved on telegram by Jon. Turns out the problems were something gone wrong with patching. Overlay landing in unstable for preliminary testing

Fri, Apr 12, 1:51 PM
sitter committed R1005:5134720d620c: fix page order for ubiquity (authored by sitter).
fix page order for ubiquity
Fri, Apr 12, 12:11 PM
sitter accepted R488:73128a60dae2: Avoid using subtitles of a previously played media.
Fri, Apr 12, 11:41 AM

Thu, Apr 11

sitter committed R1005:d85841addaef: fully port away from xenial (authored by sitter).
fully port away from xenial
Thu, Apr 11, 11:17 AM
sitter committed R1005:f29d16e60abb: typo-- (authored by sitter).
typo--
Thu, Apr 11, 11:17 AM
sitter committed R1005:686b00610795: looks to me the evdev check was somehow removed accidentally (authored by sitter).
looks to me the evdev check was somehow removed accidentally
Thu, Apr 11, 11:17 AM
sitter triaged T10786: remove ircbot from job templates as Low priority.
Thu, Apr 11, 11:13 AM · Neon
sitter updated the task description for T10782: repos to gitlab.
Thu, Apr 11, 10:39 AM · Neon
sitter updated the diff for D20429: add apt overlays to prevent running 'upgrade' on neon systems.

drop argv duping. it's not necessary

Thu, Apr 11, 9:16 AM

Wed, Apr 10

sitter added a comment to T9791: What to do with projects with KDE4 translations?.

Ah yes. The problem with kde4 is actually that even if releasme downloaded the assets correctly, they'd not get used. In kde4 times the release tools were supposed to inject the relevant cmake logic to build and install po/ and docs/. We've moved away from this because it's horrible to maintain and it divides the git-source from the tarball-source in an unnecessary fashion. But its horribleness was the reason modern releaseme intentionally does not support kde4 l10n because it'd entail a substantial maintenance cost for next to zero gain. i.e. supporting kde4 l10n does require also supporting correctly constructing cmakelists for kde4 and all that, and supporting that is absolutely terrible.

Wed, Apr 10, 12:36 PM · Neon
sitter triaged T10782: repos to gitlab as Low priority.
Wed, Apr 10, 12:22 PM · Neon
sitter committed R871:abc37a6aef2d: always support all command line options (authored by sitter).
always support all command line options
Wed, Apr 10, 11:08 AM
sitter closed D19940: always support all command line options.
Wed, Apr 10, 11:08 AM · Plasma
sitter moved T3633: catch apt upgrade to point to dist-upgrade from Discussing to Doing on the Neon board.
Wed, Apr 10, 10:35 AM · Neon
sitter added a task to D20429: add apt overlays to prevent running 'upgrade' on neon systems: T3633: catch apt upgrade to point to dist-upgrade.
Wed, Apr 10, 10:34 AM
sitter added a revision to T3633: catch apt upgrade to point to dist-upgrade: D20429: add apt overlays to prevent running 'upgrade' on neon systems.
Wed, Apr 10, 10:34 AM · Neon
sitter added reviewers for D20429: add apt overlays to prevent running 'upgrade' on neon systems: bshah, jriddell.
Wed, Apr 10, 10:34 AM
sitter requested review of D20429: add apt overlays to prevent running 'upgrade' on neon systems.
Wed, Apr 10, 10:34 AM

Tue, Apr 9

sitter committed R113:a3c095352bb1: do no install .so symlinks for private libraries (authored by sitter).
do no install .so symlinks for private libraries
Tue, Apr 9, 2:44 PM
sitter closed D20377: do no install .so symlinks for private libraries.
Tue, Apr 9, 2:44 PM · Plasma
sitter added reviewers for D20408: Partially revert "Require CMake 3.4 and use the OpenSSL imported libs": dfaure, arojas, vonreth.
Tue, Apr 9, 1:58 PM
sitter added a reverting change for R486:63fd27fbce78: Actually abort after the message that tells people to set CMAKE_INSTALL_PREFIX: D20408: Partially revert "Require CMake 3.4 and use the OpenSSL imported libs".
Tue, Apr 9, 1:57 PM
sitter requested review of D20408: Partially revert "Require CMake 3.4 and use the OpenSSL imported libs".
Tue, Apr 9, 1:57 PM
sitter added a reverting change for R486:32419c899c77: unbreak build by moving away from deprecated exec_program: D20408: Partially revert "Require CMake 3.4 and use the OpenSSL imported libs".
Tue, Apr 9, 1:57 PM
sitter closed T10604: backport poppler as Resolved.
Tue, Apr 9, 12:37 PM · Neon
sitter moved T10604: backport poppler from Ready To Do to Doing on the Neon board.
Tue, Apr 9, 12:10 PM · Neon
sitter moved T10040: add keepassxc to neon image from Ready To Do to Discussing on the Neon board.
Tue, Apr 9, 10:32 AM · Neon
sitter added a reviewer for D20379: Avoid using subtitles of a previously played media: dvratil.
Tue, Apr 9, 9:26 AM

Mon, Apr 8

sitter requested review of D20377: do no install .so symlinks for private libraries.
Mon, Apr 8, 12:20 PM · Plasma
sitter updated the title for P364 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Mon, Apr 8, 11:15 AM
sitter committed R486:32419c899c77: unbreak build by moving away from deprecated exec_program (authored by sitter).
unbreak build by moving away from deprecated exec_program
Mon, Apr 8, 9:32 AM
sitter closed D20228: unbreak build by moving away from deprecated exec_program.
Mon, Apr 8, 9:32 AM

Wed, Apr 3

sitter updated the diff for D20228: unbreak build by moving away from deprecated exec_program.

fix style for consistency with rest of file

Wed, Apr 3, 1:52 PM
sitter added reviewers for D20228: unbreak build by moving away from deprecated exec_program: asturmlechner, dfaure, vonreth.
Wed, Apr 3, 1:52 PM
sitter requested review of D20228: unbreak build by moving away from deprecated exec_program.
Wed, Apr 3, 1:51 PM
sitter committed R252:bf27abdb08eb: use more appropriate plasma-specific icon for plasma category (authored by sitter).
use more appropriate plasma-specific icon for plasma category
Wed, Apr 3, 12:35 PM
sitter closed D20225: use more appropriate plasma-specific icon for plasma category.
Wed, Apr 3, 12:35 PM · Frameworks
sitter updated the diff for D20092: New class KOSRelease - a parser for os-release files.
  • defaultFilePath is now static in the cpp only, the public ctor defaults to QString() for the filePath, which gets checked in the private ctor and diverted to defaultFilePath if necessary
  • Private ctor now copies filePath as we may need to change it to defaultFilePath
  • = and \# parsing revisitede
    • new helper splitEntry mids the line at first = character only preventing = characters in pretty strings from tripping up the parsing
    • \# characters that are not the first character in the line are now not explicitly causing a line skip as far as entry parsing is concerned. I think this is actually a more truthful implementation of the format specification. since the spec doesn't even mention trailing \# we can do whatever with them and not skipping entire lines outright seems like the nicer solution here
  • api docs updated accordingly. now clearly states that trailing comments result in undefined behavior
  • test and fixture updated to make sure = and \# work in pretty string and that completely invalid lines are skipped
  • parsing skips now produce categorized warnings
Wed, Apr 3, 12:02 PM · Frameworks
sitter committed R266:9ff7e4658ded: make start-here-kde also available start-here-kde-plasma (authored by sitter).
make start-here-kde also available start-here-kde-plasma
Wed, Apr 3, 11:22 AM
sitter closed D20176: make start-here-kde also available start-here-kde-plasma.
Wed, Apr 3, 11:22 AM · Frameworks
sitter requested review of D20225: use more appropriate plasma-specific icon for plasma category.
Wed, Apr 3, 11:17 AM · Frameworks
sitter updated subscribers of D20092: New class KOSRelease - a parser for os-release files.

The only relevant change in the history not from me is from @davidedmundson it seems. Dave, are you ok with changing the license from GPL to LGPL?

Wed, Apr 3, 10:18 AM · Frameworks

Tue, Apr 2

sitter triaged T10753: move tooling away from shutdown mode as High priority.
Tue, Apr 2, 11:46 AM · Neon
sitter added a comment to T9793: project.rb needs updated to have correct deps for forks.

Nevermind found it. jenkins-jobs/nci/project.rb has special handling which mangles dependees for various criteria. Among them if it is a fork. I am not sure what this task is on about though @jriddell. It only needs the fork removed from the array?

Tue, Apr 2, 9:12 AM · Neon
sitter closed T5556: tooling contain.rb refinement as Resolved.

Implemented since February in c57ff198713957b3635ae7047af3977fae284259

Tue, Apr 2, 9:02 AM · Neon

Mon, Apr 1

sitter committed R252:8ce99b1637ef: use plasma icon as icon for plasma notification category (authored by sitter).
use plasma icon as icon for plasma notification category
Mon, Apr 1, 5:14 PM
sitter closed D20172: use plasma icon as icon for plasma notification category.
Mon, Apr 1, 5:14 PM · Frameworks
sitter requested review of D20176: make start-here-kde also available start-here-kde-plasma.
Mon, Apr 1, 4:27 PM · Frameworks
sitter added a comment to D20172: use plasma icon as icon for plasma notification category.

Oh, on a related note, I actually do wonder if we should symlink start-here-kde in breeze to start-here-kde-plasma and use that instead to differentiate? As per the spec on !breeze icon themes start-here-kde-plasma would fall back to start-here-kde if the plasma icon doesn't exist IIRC. So it's just as portable but less ambiguous perhaps.

Mon, Apr 1, 3:49 PM · Frameworks
sitter retitled D20172: use plasma icon as icon for plasma notification category from use the plasma icon as plasma icon to use plasma icon as icon for plasma notification category.
Mon, Apr 1, 3:36 PM · Frameworks
sitter added a comment to D20172: use plasma icon as icon for plasma notification category.

before

Mon, Apr 1, 3:36 PM · Frameworks
sitter requested review of D20172: use plasma icon as icon for plasma notification category.
Mon, Apr 1, 3:36 PM · Frameworks
sitter closed T5052: ISO pool/ repo should not come from live-build as Resolved.
Mon, Apr 1, 11:41 AM · Neon
sitter added a comment to T5052: ISO pool/ repo should not come from live-build.

New unstable ISO built using the changed livecd-rootfs and has the preinstalled pool correctly set up and packages correctly available. I'm considering this fixed.

Mon, Apr 1, 11:41 AM · Neon
sitter closed D20111: do not contain apt repo.
Mon, Apr 1, 10:11 AM
sitter updated the summary of D20111: do not contain apt repo.
Mon, Apr 1, 10:11 AM

Fri, Mar 29

sitter accepted D20114: Remove Q_FOREACH from inlined header functions.

Do we want this released pronto?

Fri, Mar 29, 12:49 PM
sitter closed T10079: Add missing dependencies to the docker-neon package as Resolved.

landed and seems to work fine on pristine user edition installation

Fri, Mar 29, 11:28 AM · Neon
sitter added a comment to T5720: watcher for repo-metadata stable branch moves.

By updates stable builds you mean trigger a build?

Fri, Mar 29, 11:13 AM · Neon
sitter closed T9182: watchers to not run on apps/plasma/kf5 as Resolved.

This looks to have been fixed.

Fri, Mar 29, 11:10 AM · Neon
sitter lowered the priority of T4969: fix qml module lookup from High to Normal.
Fri, Mar 29, 11:00 AM · Neon
sitter added a comment to T9793: project.rb needs updated to have correct deps for forks.

I don't understand this.

Fri, Mar 29, 10:12 AM · Neon
sitter requested review of D20111: do not contain apt repo.
Fri, Mar 29, 10:10 AM
sitter added a comment to T5052: ISO pool/ repo should not come from live-build.

I have the change ready. waiting for next week so I don't have to rush this through on a friday and then end up with broken isos

Fri, Mar 29, 10:10 AM · Neon
sitter moved T5052: ISO pool/ repo should not come from live-build from Ready To Do to Doing on the Neon board.
Fri, Mar 29, 10:10 AM · Neon

Thu, Mar 28

sitter updated the diff for D20092: New class KOSRelease - a parser for os-release files.
  • doc wording
  • disable cctor. no real use case for copy at this point
Thu, Mar 28, 4:29 PM · Frameworks
sitter committed R577:aaac69282728: implement on-demand dependency resolution & replace mkmf with custom code (authored by sitter).
implement on-demand dependency resolution & replace mkmf with custom code
Thu, Mar 28, 3:33 PM
sitter committed R577:05de6bb725d1: implement on-demand dependency resolution & replace mkmf with custom code (authored by sitter).
implement on-demand dependency resolution & replace mkmf with custom code
Thu, Mar 28, 2:55 PM
sitter added a reviewer for D20092: New class KOSRelease - a parser for os-release files: apol.
Thu, Mar 28, 1:59 PM · Frameworks
sitter requested review of D20092: New class KOSRelease - a parser for os-release files.
Thu, Mar 28, 1:59 PM · Frameworks

Wed, Mar 27

sitter added a comment to D19850: Make AppStream generation opt-in.

LGTM technically. Also looks crazy scary invasive though from a packaging POV :O

Wed, Mar 27, 1:17 PM · Frameworks
sitter updated subscribers of D20078: RFC fix race on kcrash auto-restarts.

Still fairly messy and very verbose but working.

Wed, Mar 27, 12:58 PM · Frameworks
sitter requested review of D20078: RFC fix race on kcrash auto-restarts.
Wed, Mar 27, 12:52 PM · Frameworks
sitter accepted D19439: kio_smb: Change incorrect use of QUrl::adjusted().

Ha, this is also much nicer looking. I love it! :)

Wed, Mar 27, 9:55 AM · Frameworks, Dolphin

Tue, Mar 26

sitter committed R237:998982a47cbc: point readme to the wiki page (authored by sitter).
point readme to the wiki page
Tue, Mar 26, 11:57 AM
sitter closed D19779: point readme to the wiki page.
Tue, Mar 26, 11:57 AM · Frameworks
sitter added a comment to D19779: point readme to the wiki page.

I am taking silence as indifference.

Tue, Mar 26, 11:57 AM · Frameworks

Mon, Mar 25

sitter accepted D20030: Fix compilation error due to QByteArray/QString mixup.
Mon, Mar 25, 1:59 PM
sitter committed R102:e65bcdc90719: [about-distro] OSRelease to collect "extra" keys (authored by sitter).
[about-distro] OSRelease to collect "extra" keys
Mon, Mar 25, 1:56 PM
sitter closed D19976: [about-distro] OSRelease to collect "extra" keys.
Mon, Mar 25, 1:56 PM · Plasma
sitter committed R102:620be5cd4dea: [about-distro] pimpl OSRelease privates (authored by sitter).
[about-distro] pimpl OSRelease privates
Mon, Mar 25, 1:55 PM
sitter closed D19975: [about-distro] pimpl OSRelease privates.
Mon, Mar 25, 1:55 PM · Plasma

Mar 22 2019

sitter added a dependency for D19976: [about-distro] OSRelease to collect "extra" keys: D19975: [about-distro] pimpl OSRelease privates.
Mar 22 2019, 2:00 PM · Plasma
sitter added a dependent revision for D19975: [about-distro] pimpl OSRelease privates: D19976: [about-distro] OSRelease to collect "extra" keys.
Mar 22 2019, 2:00 PM · Plasma
sitter requested review of D19976: [about-distro] OSRelease to collect "extra" keys.
Mar 22 2019, 2:00 PM · Plasma
sitter requested review of D19975: [about-distro] pimpl OSRelease privates.
Mar 22 2019, 2:00 PM · Plasma
sitter accepted D19970: Fix missings override warnings.

Software that hasn't been ported by now IMO deserves no further fixes anyway. At this point it's more a matter of anyone finding the time and energy to actually rip Qt4 out and moving to ECM :/

Mar 22 2019, 1:45 PM
sitter requested changes to D19970: Fix missings override warnings.

Q_FALLTHROUGH is too new. This thing is still qt 4 compatible

Mar 22 2019, 12:15 PM
sitter committed R241:c6b5750b9527: Fix WebDAV directory renaming if KeepAlive is off (authored by hoffmannrobert).
Fix WebDAV directory renaming if KeepAlive is off
Mar 22 2019, 10:20 AM
sitter closed D19786: Fix WebDAV directory renaming if KeepAlive is off.
Mar 22 2019, 10:20 AM · Frameworks
sitter accepted D19786: Fix WebDAV directory renaming if KeepAlive is off.

Fair enough. LGTM :)

Mar 22 2019, 9:47 AM · Frameworks

Mar 21 2019

sitter updated subscribers of T10513: HWE again!.

Something is broken with the archives which prevents ISOs building on account of not finding neon-live. I am not clear why, @jriddell did change some stuff though and at a glance that seems at fault since the thing that didn't change (user edition) did build fine the other day. So that blocks ISO rebuilds for stable (and also breaks unstable now).

Mar 21 2019, 1:36 PM · Neon
sitter added a comment to D19940: always support all command line options.

I should add for the record that I'd actually find stricter versioning better, but arg handling in kcrash is already a bit tricky because of signal-safety restrictions and adding versioning complexity on top would probably do nothing for how easy the code base is to approach. On top of that, even with minimal options (correctly) set, drkonqi will and should be able to help the user file a bug report. In theory we need as little as the pid to do something of use.

Mar 21 2019, 12:29 PM · Plasma
sitter added a reviewer for D19940: always support all command line options: Plasma.
Mar 21 2019, 12:24 PM · Plasma
sitter requested review of D19940: always support all command line options.
Mar 21 2019, 12:24 PM · Plasma
sitter committed R487:2c8b6362ff91: Revert "Port some code to for(...:...)" (authored by sitter).
Revert "Port some code to for(...:...)"
Mar 21 2019, 12:18 PM
sitter added a reverting change for R487:3dc3141474fb: Port some code to for(...:...): R487:2c8b6362ff91: Revert "Port some code to for(...:...)".
Mar 21 2019, 12:18 PM
sitter committed R871:d0974fdc18b4: don't connect to lambdas and call slots when you can just call the slots (authored by sitter).
don't connect to lambdas and call slots when you can just call the slots
Mar 21 2019, 11:09 AM
sitter closed D19937: don't connect to lambdas and call slots when you can just call the slots.
Mar 21 2019, 11:09 AM · Plasma