Feed Advanced Search

Wed, Dec 11

sitter updated the task description for T9376: calamares by default.
Wed, Dec 11, 8:28 PM · Neon

Mon, Dec 9

sitter updated the diff for D25682: [WIP] add initial wsdiscovery support.

various fixes suggested by dfaure

Mon, Dec 9, 3:35 PM · Frameworks, Dolphin
sitter added a comment to D25682: [WIP] add initial wsdiscovery support.

Yep, still looking for primarily design input.

Mon, Dec 9, 3:34 PM · Frameworks, Dolphin

Sat, Dec 7

sitter accepted D25802: Don't use obsolete qVariantFromValue.
Sat, Dec 7, 10:25 PM

Tue, Dec 3

sitter added a comment to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.

I haven't read everything in great detail... but...

Tue, Dec 3, 12:21 PM · Frameworks
sitter committed R365:b8f39bd08f84: make phonon use the basename without dir (authored by sitter).
make phonon use the basename without dir
Tue, Dec 3, 11:44 AM
sitter committed R499:608410c3ebf8: update phonon paths (authored by sitter).
update phonon paths
Tue, Dec 3, 11:27 AM
sitter committed R247:add1a39c297c: flatten phonon directory (authored by sitter).
flatten phonon directory
Tue, Dec 3, 11:08 AM
sitter updated subscribers of T12257: Webpage advertising Linux distributions with KDE Software.

Jonathan said our writer isn't ready for this sort of spotlight IIRC. @jriddell input?

Tue, Dec 3, 10:36 AM · Neon, Kubuntu, KDE Promo

Mon, Dec 2

sitter updated subscribers of D25682: [WIP] add initial wsdiscovery support.

Why do we need to mirror this dsoap-ws-discovery-client lib that seems to be copied from somewhere?

Mon, Dec 2, 2:42 PM · Frameworks, Dolphin
sitter requested review of D25682: [WIP] add initial wsdiscovery support.
Mon, Dec 2, 1:50 PM · Frameworks, Dolphin
sitter committed R860:fadd8803e08a: add a (temporary) workaround to ensure phonon i18n is inferred correctly (authored by sitter).
add a (temporary) workaround to ensure phonon i18n is inferred correctly
Mon, Dec 2, 10:24 AM
sitter committed R860:7e00c762eb3f: typo-- (authored by sitter).
typo--
Mon, Dec 2, 10:24 AM

Fri, Nov 29

sitter committed R119:c7a1f606ca96: replace bespoke xkb geometry parser with xkb (authored by sitter).
replace bespoke xkb geometry parser with xkb
Fri, Nov 29, 7:53 AM
sitter closed D25191: replace bespoke xkb geometry parser with xkb.
Fri, Nov 29, 7:53 AM · Plasma
sitter awarded T12257: Webpage advertising Linux distributions with KDE Software a Love token.
Fri, Nov 29, 7:32 AM · Neon, Kubuntu, KDE Promo

Tue, Nov 26

sitter committed R860:f3739372febe: document 404 potential of find endpoint (authored by sitter).
document 404 potential of find endpoint
Tue, Nov 26, 1:25 PM
sitter committed R860:c6ee26b72392: refactor find arg handling and add ability to find only active/inactive (authored by sitter).
refactor find arg handling and add ability to find only active/inactive
Tue, Nov 26, 1:25 PM
sitter committed R860:0a45c83cacbe: refine makefile a bit (authored by sitter).
refine makefile a bit
Tue, Nov 26, 1:25 PM
sitter committed R860:030ff5437e6e: switch on release mode for good measure (authored by sitter).
switch on release mode for good measure
Tue, Nov 26, 1:25 PM
sitter committed R860:741f406bb784: implement proper zero-downtime restarts (authored by sitter).
implement proper zero-downtime restarts
Tue, Nov 26, 1:25 PM

Mon, Nov 25

sitter added a comment to D23579: port ftp slave to new error reporting system.

I'll see about adding some debug output for the daemon state. Hard to say why it's flakey with the info at hand.

Mon, Nov 25, 11:13 AM · Frameworks

Tue, Nov 19

sitter closed D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH.
Tue, Nov 19, 2:14 PM · Frameworks
sitter committed R241:eab483fa2eab: when kioslave5 couldn't be found in libexec-ish locations try $PATH (authored by sitter).
when kioslave5 couldn't be found in libexec-ish locations try $PATH
Tue, Nov 19, 2:14 PM
sitter closed T5621: ccache as Wontfix.

The arm setup actually disappeared since (possibly wasn't carried into new server) so there are no up to date metrics. It does not really matter though since we do not have a way to pull this off for amd64. We'd require a persistent storage for the cache as nodes are largely ephemeral so result need "offsite" storage. This would be tricky to do since we currently have no space for this and the actual transfer overhead would like destroy any gains made by the cache. Plus there is of course the risk of false positives anyway. All in all no longer viable to implement.

Tue, Nov 19, 2:04 PM · Neon
sitter triaged T12072: move snaps to binary factory as Normal priority.
Tue, Nov 19, 9:49 AM · Neon

Mon, Nov 18

sitter committed R116:cb8b854c80e9: Merge branch 'Plasma/5.17' (authored by sitter).
Merge branch 'Plasma/5.17'
Mon, Nov 18, 4:54 PM
sitter committed R116:c8775cb198f3: connect groupbox toggles to change signal (authored by sitter).
connect groupbox toggles to change signal
Mon, Nov 18, 4:54 PM
sitter closed D25368: connect groupbox toggles to change signal.
Mon, Nov 18, 4:54 PM · Plasma
sitter added a comment to D25368: connect groupbox toggles to change signal.

@broulik the children are handled by the other connections already (linedit, push button etc.)

Mon, Nov 18, 4:13 PM · Plasma
sitter requested review of D25368: connect groupbox toggles to change signal.
Mon, Nov 18, 2:31 PM · Plasma
sitter added inline comments to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.
Mon, Nov 18, 10:35 AM · Frameworks

Fri, Nov 15

sitter added inline comments to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.
Fri, Nov 15, 1:18 PM · Frameworks
sitter added a comment to D24641: Collect more information from version control systems.

This is starting to look really good. All functions will need documenting in the header of that file so they show up on api.kde.org, see other modules for examples.

Fri, Nov 15, 12:26 PM · Build System, Frameworks
sitter added a comment to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.

some style complaints. Looks great other than that 👍

Fri, Nov 15, 11:50 AM · Frameworks
sitter updated the diff for D25191: replace bespoke xkb geometry parser with xkb.
  • remove all color mapping tech, it's pointless since the code now uses the system palette
  • remove garbage foobar class
  • remove unnecessary main.moc include
  • create two global SystemPalettes instead of in individual items
Fri, Nov 15, 11:36 AM · Plasma

Thu, Nov 14

sitter requested review of D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH.
Thu, Nov 14, 5:37 PM · Frameworks
sitter updated the diff for D25191: replace bespoke xkb geometry parser with xkb.
  • bump preview size a bit
  • update documentation
  • resolve outstanding todos
Thu, Nov 14, 3:41 PM · Plasma
sitter updated the diff for D25191: replace bespoke xkb geometry parser with xkb.
  • document why section overlays aren't modelled
  • doodad qml item creation is now type based rather than duck typed
  • logo doodads are now supported as a compositie of shape doodads and labels
  • outline doodads now behave correctly in that they only render an outline without fill (at least I think that's how they are meant to work)
  • todo--
Thu, Nov 14, 2:09 PM · Plasma
sitter committed R320:903eb5d5031d: Merge branch 'release/19.12' (authored by sitter).
Merge branch 'release/19.12'
Thu, Nov 14, 11:51 AM
sitter committed R320:24506c2af8d1: make the libssh finder ensure the new ssh target is set (authored by sitter).
make the libssh finder ensure the new ssh target is set
Thu, Nov 14, 11:51 AM
sitter closed D25170: make the libssh finder ensure the new ssh target is set.
Thu, Nov 14, 11:51 AM · Frameworks, Dolphin

Wed, Nov 13

sitter committed R871:c6cfdb243c3e: Merge branch 'Plasma/5.17' (authored by sitter).
Merge branch 'Plasma/5.17'
Wed, Nov 13, 5:09 PM
sitter committed R871:4f161fa0b57f: disable systeminfo test on systems without uname (authored by sitter).
disable systeminfo test on systems without uname
Wed, Nov 13, 5:09 PM
sitter committed R871:fb50d436d178: fix msvc compatibility (authored by sitter).
fix msvc compatibility
Wed, Nov 13, 5:09 PM
sitter added a comment to T11933: Debrand KDE Applications as Release Service.

^ Plays into https://github.com/ximion/appstream/issues/240

Wed, Nov 13, 1:01 PM · KDE Promo, KDE Applications, Goal: All About the Apps

Nov 11 2019

sitter committed R871:883769ab88c1: Merge branch 'Plasma/5.17' (authored by sitter).
Merge branch 'Plasma/5.17'
Nov 11 2019, 1:21 PM
sitter committed R871:8a03e199c204: move plus character in query test to connection (authored by sitter).
move plus character in query test to connection
Nov 11 2019, 1:21 PM
sitter committed R871:8eedb5a0eaae: Merge branch 'Plasma/5.17' (authored by sitter).
Merge branch 'Plasma/5.17'
Nov 11 2019, 1:12 PM
sitter committed R871:885a58205ba0: force encoding on all queries (authored by sitter).
force encoding on all queries
Nov 11 2019, 1:12 PM
sitter added a comment to T11979: KDE neon's Welcome Screen.

OEM configuration is driven by installers already e.g. calamares https://people.ubuntu.com/~apachelogger/screencasts/vokoscreen-2019-05-03_11-43-36.mkv or ubiquity https://userbase.kde.org/Neon/Installation/OEM#First_Boot
Both aforementioned use cases are addressed by the same software using the same code. The "steps" can be different though (e.g. OEM config mostly needs no partitioning so this step is not part of it).

Nov 11 2019, 10:46 AM · VDG

Nov 9 2019

GB_2 awarded D25191: replace bespoke xkb geometry parser with xkb a Like token.
Nov 9 2019, 12:30 PM · Plasma

Nov 8 2019

sitter updated the diff for D25191: replace bespoke xkb geometry parser with xkb.

fix tooltip scaling to show keys at 2.5 times their original size

Nov 8 2019, 1:30 PM · Plasma
sitter updated the diff for D25191: replace bespoke xkb geometry parser with xkb.

install bin, drop ki18n as link target (not used at this time)

Nov 8 2019, 1:05 PM · Plasma
sitter committed R871:ec4a4cb89df7: Merge branch 'Plasma/5.17' (authored by sitter).
Merge branch 'Plasma/5.17'
Nov 8 2019, 12:18 PM
sitter committed R871:4e29b8a75635: force-encode passwords on login (authored by sitter).
force-encode passwords on login
Nov 8 2019, 12:18 PM
sitter added a comment to T11979: KDE neon's Welcome Screen.

We have distro-independent ways to refer to software (appstream ids) so software stores understand what we mean. So, there is no technical problem here. Heck, even without it there wouldn't be. Calamares manages to be a distro-independent installer that can be used by all distros and made their own. There is no reason we couldn't have the same for a first start experience.

Nov 8 2019, 11:05 AM · VDG
sitter added a comment to D25148: Add binary-version dependency of hwcomposer on glutils.

Oh oh oh, I forgot to actually read this.

Nov 8 2019, 10:21 AM

Nov 7 2019

sitter committed R871:0f343ffbeb0f: unbreak crash reports involving QML (authored by sitter).
unbreak crash reports involving QML
Nov 7 2019, 3:40 PM
sitter requested review of D25191: replace bespoke xkb geometry parser with xkb.
Nov 7 2019, 1:17 PM · Plasma
sitter added a comment to T11933: Debrand KDE Applications as Release Service.

I figure we want maximum exposure for this. So, much like we do with Plasma already I would suggest that we post the announcement on kde.org AND copy it to the dot.

Nov 7 2019, 12:52 PM · KDE Promo, KDE Applications, Goal: All About the Apps

Nov 6 2019

sitter added inline comments to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.
Nov 6 2019, 2:04 PM · Frameworks
sitter added a comment to D25159: Fix linking to libssh 0.9.1.

D25170 for when that lands

Nov 6 2019, 1:00 PM · Frameworks, Dolphin
sitter added a comment to D25170: make the libssh finder ensure the new ssh target is set.

NB: depends on https://gitlab.com/libssh/libssh-mirror/merge_requests/71 getting landed.

Nov 6 2019, 12:59 PM · Frameworks, Dolphin
sitter requested review of D25170: make the libssh finder ensure the new ssh target is set.
Nov 6 2019, 12:59 PM · Frameworks, Dolphin

Nov 5 2019

sitter added a comment to D25159: Fix linking to libssh 0.9.1.
In D25159#559016, @asn wrote:

We moved from a manually generated libssh-config.cmake to install(EXPORTS libssh-config) and it does things completely different.

I'm currently trying to fix it. However better don't apply this as ssh_shared will vanish as a target.

I wonder how I can define LIBSSH_LIBRARIES again with EXPORTS.

Nov 5 2019, 4:49 PM · Frameworks, Dolphin
sitter accepted D25159: Fix linking to libssh 0.9.1.

I think there's a smarter way of dealing with this somewhere in our finder, not blocking though. I'll take a look when I find a minute.

Nov 5 2019, 4:26 PM · Frameworks, Dolphin
sitter committed R871:210c9d88fb81: disable bug report when there are signs of an update (authored by sitter).
disable bug report when there are signs of an update
Nov 5 2019, 1:01 PM
sitter closed D25002: disable bug report when there are signs of an update.
Nov 5 2019, 1:01 PM · Plasma
sitter committed R285:cc0d3c8b7977: actually set a dependency between kcrashtest and test_crasher (authored by sitter).
actually set a dependency between kcrashtest and test_crasher
Nov 5 2019, 11:39 AM
sitter closed D25154: actually set a dependency between kcrashtest and test_crasher.
Nov 5 2019, 11:39 AM · Frameworks
sitter closed D25153: disable kcrashtest and its helper executable test_crasher on windows.
Nov 5 2019, 11:39 AM · Frameworks
sitter committed R285:d3b83d931176: disable kcrashtest and its helper executable test_crasher on windows (authored by sitter).
disable kcrashtest and its helper executable test_crasher on windows
Nov 5 2019, 11:39 AM
sitter added a reverting change for R285:a105c4520880: Disable execution of test_crasher, which enters an infinite loop on Windows…: R285:cc5f139a614a: Revert "Disable execution of test_crasher, which enters an infinite loop on….
Nov 5 2019, 11:39 AM
sitter committed R285:cc5f139a614a: Revert "Disable execution of test_crasher, which enters an infinite loop on… (authored by sitter).
Revert "Disable execution of test_crasher, which enters an infinite loop on…
Nov 5 2019, 11:39 AM
sitter added a comment to D25152: Reenable the tests and only disable krcrashtest on windows.

D25153 for reference.

Nov 5 2019, 10:54 AM · Frameworks
sitter requested review of D25154: actually set a dependency between kcrashtest and test_crasher.
Nov 5 2019, 10:25 AM · Frameworks
sitter requested review of D25153: disable kcrashtest and its helper executable test_crasher on windows.
Nov 5 2019, 10:23 AM · Frameworks

Oct 30 2019

sitter added a comment to D25079: [CopyJob] Increase the amount of data sendfile can copy at once.

TBH, I would move away from the hardcoding in general.... try to sendfile size_of_file and if n < size use n as new count for the next cycle. The second cycle will use the maximum regardless of what the specific kernel version has as maximum.
The maximum is an implementation detail of the kernel that may change every release, so hardcoding anything seems wrong here.

Oct 30 2019, 4:13 PM · Frameworks

Oct 29 2019

sitter updated the diff for D25002: disable bug report when there are signs of an update.

typo--

Oct 29 2019, 11:21 AM · Plasma
sitter updated the diff for D25002: disable bug report when there are signs of an update.

switch from list to bool since we don't actually use the list anyway

Oct 29 2019, 11:19 AM · Plasma

Oct 28 2019

sitter added inline comments to D25002: disable bug report when there are signs of an update.
Oct 28 2019, 3:57 PM · Plasma
sitter planned changes to D25002: disable bug report when there are signs of an update.
Oct 28 2019, 3:57 PM · Plasma
sitter requested review of D25002: disable bug report when there are signs of an update.
Oct 28 2019, 12:26 PM · Plasma

Oct 25 2019

sitter committed R241:de3ca85f058e: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds (authored by sitter).
auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds
Oct 25 2019, 11:14 AM
sitter closed D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds.
Oct 25 2019, 11:14 AM · Frameworks
sitter committed R263:e9387f561fa2: fix default shortcut detection (authored by sitter).
fix default shortcut detection
Oct 25 2019, 10:44 AM
sitter closed D24908: fix default shortcut detection.
Oct 25 2019, 10:44 AM · Frameworks
sitter added a comment to D24887: WIP slave command behavior assertion system.

About the list of unexpected signals in forCommand():

Oct 25 2019, 9:48 AM · Frameworks

Oct 24 2019

sitter added inline comments to D24908: fix default shortcut detection.
Oct 24 2019, 10:21 PM · Frameworks
sitter added a comment to D24908: fix default shortcut detection.

Supposedly, I was being lazy though since there is no pre existing test and I don't exactly know if there's anything to watch out for when testing widgets (as in: I've never written a widget test before).

Oct 24 2019, 8:35 PM · Frameworks
sitter added a comment to D24641: Collect more information from version control systems.

Hm, how about separate functions though? With a single stat any given build still needs N process forks even when they only want 1 value.

Oct 24 2019, 10:22 AM · Build System, Frameworks
sitter added a reviewer for D24908: fix default shortcut detection: dfaure.
Oct 24 2019, 9:40 AM · Frameworks
sitter updated the test plan for D24908: fix default shortcut detection.
Oct 24 2019, 9:40 AM · Frameworks
sitter requested review of D24908: fix default shortcut detection.
Oct 24 2019, 9:39 AM · Frameworks

Oct 23 2019

sitter committed R871:fff04078f84f: Merge branch 'Plasma/5.17' (authored by sitter).
Merge branch 'Plasma/5.17'
Oct 23 2019, 2:59 PM
sitter committed R871:45ea4d554c54: typo-- (authored by sitter).
typo--
Oct 23 2019, 2:59 PM
sitter accepted D24890: Report windowing system.

Oh it's gorgeous!

Oct 23 2019, 2:44 PM · Plasma
sitter requested changes to D24890: Report windowing system.
Oct 23 2019, 2:17 PM · Plasma
sitter added a comment to T10217: Package Kolorfill.

Not sure if that sort of application really needs to have regular commits ;)

Oct 23 2019, 12:49 PM · Neon