Feed Advanced Search

Today

sitter abandoned D21883: give kpasswordlineedit strong focus.

Actually this is a bit daft. I'll have a look at changing KPasswordLineEdit instead.

Tue, Jun 18, 4:57 PM · Plasma
sitter requested review of D21883: give kpasswordlineedit strong focus.
Tue, Jun 18, 4:00 PM · Plasma
sitter accepted D21881: [Notifications] Read BAMF_DESKTOP_FILE_HINT from environment.

Not a fan of treating the pid like a bool in conditionals, looks lovely other than that.

Tue, Jun 18, 3:20 PM · Plasma
sitter updated the title for P406 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Tue, Jun 18, 3:00 PM
sitter updated the title for P405 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Tue, Jun 18, 2:58 PM

Yesterday

sitter committed R498:b9146f1a1733: plasma-thunderbolt is part of plasma now send notifications to channel (authored by sitter).
plasma-thunderbolt is part of plasma now send notifications to channel
Mon, Jun 17, 5:17 PM
sitter committed R1044:17663b299270: typo-- (authored by sitter).
typo--
Mon, Jun 17, 3:55 PM
sitter committed R352:8d84d62bbb2e: Merge branch 'Applications/19.04' (authored by sitter).
Merge branch 'Applications/19.04'
Mon, Jun 17, 1:53 PM
sitter committed R352:711079999cb1: update documentation (authored by sitter).
update documentation
Mon, Jun 17, 1:53 PM
sitter committed R352:9d86338aac82: add a note about why append does not forward the size to parents (authored by sitter).
add a note about why append does not forward the size to parents
Mon, Jun 17, 1:53 PM
sitter committed R352:c040d5c50af2: properly update children when removing Files (authored by bruleherman).
properly update children when removing Files
Mon, Jun 17, 1:53 PM
sitter closed D21781: Fix for Tree.
Mon, Jun 17, 1:53 PM
sitter added a comment to D21781: Fix for Tree.

Thanks, that does make sense now.

Mon, Jun 17, 1:45 PM
sitter committed R1044:501110b1c9ea: search lib paths for boltd for debian systems (authored by sitter).
search lib paths for boltd for debian systems
Mon, Jun 17, 1:02 PM
sitter closed D21873: search lib paths for boltd for debian systems.
Mon, Jun 17, 1:02 PM · Plasma
sitter added a comment to D21797: do not set a hardcoded minimum size.

Oh, FWIW, I am not sure if defaulting to 16:9 on the report dialog is actually all that awesome, it seems to cause an exhaustive amount of empty space for the most part. Opinions welcome.

Mon, Jun 17, 1:01 PM · Plasma
sitter updated the diff for D21797: do not set a hardcoded minimum size.

expand diff based on additional pondering

Mon, Jun 17, 1:00 PM · Plasma
sitter triaged T11107: Encryption as Normal priority.
Mon, Jun 17, 11:30 AM · Neon
sitter added a comment to D21781: Fix for Tree.

Can you please explain what bug you intend to fix here and how to test it?

Mon, Jun 17, 11:20 AM
sitter requested review of D21873: search lib paths for boltd for debian systems.
Mon, Jun 17, 10:03 AM · Plasma
sitter added a comment to D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf.

I would actually note that the file should be 0_kde_settings.conf (assuming/hoping sddm orders the configs) otherwise a user can manually create best_config.conf and get overridden by what was set in the KCM what with k being loaded after b.

Mon, Jun 17, 9:34 AM · Plasma
sitter added a comment to D21797: do not set a hardcoded minimum size.

so its minimum size is its minimum with and its minimum height

Mon, Jun 17, 9:28 AM · Plasma

Fri, Jun 14

sitter committed R871:56ebcac89112: Merge branch 'Plasma/5.16' (authored by sitter).
Merge branch 'Plasma/5.16'
Fri, Jun 14, 2:44 PM
sitter committed R871:b428aa049ee6: move various properties away from qapp and to kaboutdata (authored by sitter).
move various properties away from qapp and to kaboutdata
Fri, Jun 14, 2:44 PM
sitter closed D21802: move various properties away from qapp and to kaboutdata.
Fri, Jun 14, 2:44 PM · Plasma
sitter updated the summary of D21802: move various properties away from qapp and to kaboutdata.
Fri, Jun 14, 2:42 PM · Plasma
sitter updated the diff for D21802: move various properties away from qapp and to kaboutdata.

ditch explicit values

Fri, Jun 14, 2:41 PM · Plasma
sitter added a comment to D21797: do not set a hardcoded minimum size.

Pre-computation is not going to work 100% because the backtracewidget is actually changing its content based on state (a whole other can of worms that :S).

Fri, Jun 14, 2:20 PM · Plasma
sitter added a comment to D21797: do not set a hardcoded minimum size.

Practically right now nothing, technically I think (?) Qt goes for the sizeHint() by default, so in theory the resize may have an effect. That said, I am not opposed to dropping that call as well if we can agree on that.

Fri, Jun 14, 1:38 PM · Plasma
sitter requested review of D21802: move various properties away from qapp and to kaboutdata.
Fri, Jun 14, 1:17 PM · Plasma
sitter committed R871:c09d87a42346: Merge branch 'Plasma/5.16' (authored by sitter).
Merge branch 'Plasma/5.16'
Fri, Jun 14, 1:06 PM
sitter closed D21799: actually set kaboutdata as application aboutdata.
Fri, Jun 14, 1:06 PM · Plasma
sitter committed R871:bd205d4d2b75: actually set kaboutdata as application aboutdata (authored by sitter).
actually set kaboutdata as application aboutdata
Fri, Jun 14, 1:06 PM
sitter requested review of D21801: force the backtracewidget into loading state when the generator is loading.
Fri, Jun 14, 1:00 PM · Plasma
sitter requested review of D21799: actually set kaboutdata as application aboutdata.
Fri, Jun 14, 11:08 AM · Plasma
sitter requested review of D21797: do not set a hardcoded minimum size.
Fri, Jun 14, 10:32 AM · Plasma
sitter committed R1005:128cdbdcc218: add a hacky sleep before switching VT after oem-config was found (authored by sitter).
add a hacky sleep before switching VT after oem-config was found
Fri, Jun 14, 9:15 AM

Thu, Jun 13

sitter committed R1005:e21f5c226e7a: drop useless systray area (authored by sitter).
drop useless systray area
Thu, Jun 13, 1:21 PM
sitter accepted D21780: Add X-Flatpak-RenamedFrom as recognized key.

I do not actually know why we need the type definition to begin with though, it occurs to me sycoca could/should just contain all keys it found in the desktop file since they get parsed on the KService side later anyway. So, limiting the sycoca to defined properties seems a bit cumbersome.

Thu, Jun 13, 1:16 PM · Frameworks
sitter accepted D21779: Resolve X-Flatpak-RenamedFrom.
Thu, Jun 13, 12:12 PM · Plasma
sitter committed R1005:d6d7488299bf: split oem desktop for wallpaper diff in 5.16 (authored by sitter).
split oem desktop for wallpaper diff in 5.16
Thu, Jun 13, 11:48 AM
sitter added a comment to D21779: Resolve X-Flatpak-RenamedFrom.
if (!service) {
    const QString desktopId = desktopEntry + QLatin1String(".desktop");
    const auto services = KServiceTypeTrader::self()->query(QStringLiteral("Application"),
                                                            QStringLiteral("exist Exec and exist [X-Flatpak-RenamedFrom]"));
    for (auto it = services.constBegin(); it != services.constEnd() && !service; ++it) {
        const QVariant renamedFrom = (*it)->property(QStringLiteral("X-Flatpak-RenamedFrom"), QVariant::String);
        const auto names = renamedFrom.toString().split(QChar(';'));
        for (const QString &name : names) {
            if (name == desktopId) {
                service = *it;
                break;
            }
        }
    }
}
Thu, Jun 13, 11:30 AM · Plasma
sitter updated the title for P403 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Thu, Jun 13, 10:57 AM

Wed, Jun 12

sitter updated the diff for D21761: move SolidUiServer::showActionsDialog to hotplug dataengine.

handle error conditions

Wed, Jun 12, 1:30 PM · Plasma
sitter committed R120:3b21b593f656: drop kdelibs4support from filebrowser dataengine (authored by sitter).
drop kdelibs4support from filebrowser dataengine
Wed, Jun 12, 12:55 PM
sitter closed D21765: drop kdelibs4support from filebrowser dataengine.
Wed, Jun 12, 12:55 PM · Plasma
sitter committed R120:24874e13cbeb: do not use legacy app_icon helper on klipper (authored by sitter).
do not use legacy app_icon helper on klipper
Wed, Jun 12, 12:55 PM
sitter closed D21766: do not use legacy app_icon helper on klipper.
Wed, Jun 12, 12:55 PM · Plasma
sitter added a comment to D21761: move SolidUiServer::showActionsDialog to hotplug dataengine.

How do I correctly forward a visible error to the caller though? This ServiceJob tech is fairly beyond me. Showing a KNotification on error may be a solution, but surely there must be a better way.

Wed, Jun 12, 12:43 PM · Plasma
sitter requested review of D21766: do not use legacy app_icon helper on klipper.
Wed, Jun 12, 12:32 PM · Plasma
sitter requested review of D21765: drop kdelibs4support from filebrowser dataengine.
Wed, Jun 12, 12:07 PM · Plasma
sitter requested review of D21762: do not use long deprecated QString::toAscii.
Wed, Jun 12, 10:40 AM · Plasma
sitter added a comment to D21761: move SolidUiServer::showActionsDialog to hotplug dataengine.

I am unsure about the error handling in HotplugJob::start I suppose it should never happen that an action cannot be resolved, so maybe an assertion to that extent is sufficient?

Wed, Jun 12, 10:22 AM · Plasma
sitter requested review of D21761: move SolidUiServer::showActionsDialog to hotplug dataengine.
Wed, Jun 12, 10:21 AM · Plasma
sitter accepted D21754: Update laptop.png for Plasma 5.16 release.

Thanks, looks lovely.

Wed, Jun 12, 9:19 AM

Tue, Jun 11

sitter closed D21747: drop the solid runner.
Tue, Jun 11, 3:04 PM · Plasma
sitter committed R120:ec9709fdd2c0: drop the solid runner (authored by sitter).
drop the solid runner
Tue, Jun 11, 3:04 PM
sitter requested review of D21747: drop the solid runner.
Tue, Jun 11, 3:03 PM · Plasma
sitter requested changes to D21566: Improve label for Disk Monitor widget.

The panel now is really bad though because the text uses more space than the arrows and the size is probably not accounting for that:

Tue, Jun 11, 2:57 PM · Plasma
sitter updated the summary of D21566: Improve label for Disk Monitor widget.
Tue, Jun 11, 12:38 PM · Plasma
sitter added a comment to D21552: Update default Samba log path.

True true. I was thinking with the static path as fall back anyway, just the "extra" loveliness of trying to follow the configured path as a first choice.

Tue, Jun 11, 12:37 PM · Plasma
sitter accepted D21552: Update default Samba log path.

https://github.com/samba-team/samba/blame/f33749fc84dacb164d1ac43f6bfcae7afcca34b3/packaging/Example/skeleton.tar looks to me like it has been that way for 21 years. I am inclined to think that the old path may have been some distro specific stuff.

Tue, Jun 11, 12:32 PM · Plasma
sitter committed R1005:498ddab1dd94: update sddm again (authored by sitter).
update sddm again
Tue, Jun 11, 12:05 PM
sitter committed R1005:9652be93163b: split idle wallpaper (authored by sitter).
split idle wallpaper
Tue, Jun 11, 12:05 PM
sitter committed R1005:01b228623181: fix tag (authored by sitter).
fix tag
Tue, Jun 11, 12:05 PM
sitter committed R1005:5861317ee528: add 5.16 desktop needle for live (authored by sitter).
add 5.16 desktop needle for live
Tue, Jun 11, 12:05 PM
sitter committed R37:106eb7df527c: bump snap to 4.2.1 + update build deps (authored by sitter).
bump snap to 4.2.1 + update build deps
Tue, Jun 11, 10:52 AM
sitter added a comment to T10159: kde.org/applications rewrite.

@jriddell Would it be possible to have https://kde.org/applications/utilities/ark instead of https://kde.org/applications/utilities/org.kde.ark?

i.e. add some .htaccess magic that rewrites the URLs without the org.kde. prefix?
I feel like this prefix is just an appstream implementation detail that shouldn't be exposed in the app URL.

@sitter any comment on why this URL scheme was chosen?

Tue, Jun 11, 10:44 AM · KDE Applications, Website Developers, KDE Promo
sitter committed R871:d445f0af391e: Merge branch 'Plasma/5.16' (authored by sitter).
Merge branch 'Plasma/5.16'
Tue, Jun 11, 10:33 AM
sitter committed R871:bf5d10ab0946: use even more resizing (authored by sitter).
use even more resizing
Tue, Jun 11, 10:33 AM
sitter closed D21642: use even more resizing.
Tue, Jun 11, 10:33 AM · Plasma
sitter requested changes to D11234: [DrKonqi] Show debug button when KDevelop session is running.

addDebugger seems a bit much, no? Why don't you just have a m_debugButtonInBox member to track whether it is currently added or not? When it is already in the buttonBox running the for loop over the buttons is entirely unnecessary.

Tue, Jun 11, 10:30 AM · Plasma
sitter added a comment to D21745: show details examples in label itself instead of unexpected tooltip.

Doesn't look too hot. Suggestions welcome.

Tue, Jun 11, 9:42 AM · Plasma
sitter added reviewers for D21745: show details examples in label itself instead of unexpected tooltip: ngraham, VDG.
Tue, Jun 11, 9:42 AM · Plasma
sitter requested review of D21745: show details examples in label itself instead of unexpected tooltip.
Tue, Jun 11, 9:40 AM · Plasma

Fri, Jun 7

sitter committed R871:802d78009ec7: Merge branch 'Plasma/5.16' (authored by sitter).
Merge branch 'Plasma/5.16'
Fri, Jun 7, 1:29 PM
sitter committed R871:0d35055d867a: copy backtrace file with overwrite flag (authored by sitter).
copy backtrace file with overwrite flag
Fri, Jun 7, 1:29 PM
sitter closed D21645: copy backtrace file with overwrite flag.
Fri, Jun 7, 1:29 PM · Plasma
sitter committed R871:c8f8b9d962eb: use errorString instead of errorText (authored by sitter).
use errorString instead of errorText
Fri, Jun 7, 1:29 PM
sitter closed D21644: use errorString instead of errorText.
Fri, Jun 7, 1:29 PM · Plasma
sitter accepted D21646: re-read color palettes when application color changes.

LGTM. At a glance breezehelper caches values (loadConfig) and brezestyleconfigdata may as well, so this certainly seems sound. Specifically _viewFocusBrush = KStatefulBrush( KColorScheme::View, KColorScheme::FocusColor, _config ); seems to be used to influence the focus color of checkboxes and that _config is in fact a StyleConfigData. So, this definitely needs a reload.

Fri, Jun 7, 1:19 PM · Plasma
sitter updated the summary of D21642: use even more resizing.
Fri, Jun 7, 11:17 AM · Plasma
sitter added a dependency for D21645: copy backtrace file with overwrite flag: D21644: use errorString instead of errorText.
Fri, Jun 7, 11:13 AM · Plasma
sitter added a dependent revision for D21644: use errorString instead of errorText: D21645: copy backtrace file with overwrite flag.
Fri, Jun 7, 11:13 AM · Plasma
sitter requested review of D21645: copy backtrace file with overwrite flag.
Fri, Jun 7, 11:13 AM · Plasma
sitter requested review of D21644: use errorString instead of errorText.
Fri, Jun 7, 11:10 AM · Plasma
sitter abandoned D21643: use errorString instead of errorText.
Fri, Jun 7, 11:08 AM · Plasma
sitter requested review of D21643: use errorString instead of errorText.
Fri, Jun 7, 11:08 AM · Plasma
sitter updated the diff for D21642: use even more resizing.

typo--

Fri, Jun 7, 10:48 AM · Plasma
sitter requested review of D21642: use even more resizing.
Fri, Jun 7, 10:47 AM · Plasma

Thu, Jun 6

sitter created T11034: snap binary factorization.
Thu, Jun 6, 9:16 AM

Wed, Jun 5

sitter closed D20814: find netcdf via its own cmake config.

Closing again. https://phabricator.kde.org/D20891

Wed, Jun 5, 11:54 AM · KDE Edu
sitter added a subtask for T9376: calamares by default: T6351: calamares: wayland.
Wed, Jun 5, 11:16 AM · Neon
sitter added a parent task for T6351: calamares: wayland: T9376: calamares by default.
Wed, Jun 5, 11:16 AM · Neon
sitter triaged T6351: calamares: wayland as Normal priority.
Wed, Jun 5, 11:16 AM · Neon
sitter closed T7542: check calamares installs locale packages as Resolved.

This is implemented in an addon shellprocess already. https://packaging.neon.kde.org/neon/calamares-settings.git/tree/desktop/calamares/desktop/modules/shellprocess_install_translations.conf?h=Neon/unstable&id=89847bf2ff81a1212ad392bf055aec790cbfb851

Wed, Jun 5, 11:14 AM · Neon
sitter closed T6601: calamares: driver-manager in installer as Invalid.

tracking via meta task https://phabricator.kde.org/T9376

Wed, Jun 5, 11:12 AM · Neon
sitter closed T6352: Calamares: OEM support as Resolved.

This is available as alpha prototype in unstable now. Remaining stuff tracked at https://phabricator.kde.org/T9376

Wed, Jun 5, 11:12 AM · Neon
sitter updated the task description for T9376: calamares by default.
Wed, Jun 5, 11:11 AM · Neon
sitter renamed T9376: calamares by default from calamares and ubiquity feature parity to calamares by default.
Wed, Jun 5, 11:03 AM · Neon