put minimumkeepsize actually in the netpref KCM
AbandonedPublic

Authored by sitter on Apr 15 2020, 2:45 PM.

Details

Reviewers
ngraham
dfaure
Summary

I didn't even know it was a thing! by the looks of it the setting only
applies to retention of .part files on aborting transfers (that is, files
must be at least this size so they get retained on aborting transfers).
so the setting is in a form inside a widget and that widget's enabled
state is contient on partial marking being enabled

CCBUG: 419987

Test Plan

look at the kcm and toggle the button

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25280
Build 25298: arc lint + arc unit
sitter created this revision.Apr 15 2020, 2:45 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 15 2020, 2:45 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Apr 15 2020, 2:45 PM
sitter updated this revision to Diff 80204.Apr 15 2020, 2:48 PM

improve label a tad

I'm very open for better labels, it's a horrible concept to explain in a few words.

And didn't we have a better spinny box for byte units somewhere? Where the user can put 1 byte or 1 kib or 1 gib and the box knows what to do?

ahmadsamir added inline comments.
src/kcms/kio/netpref.cpp
87

Why not "&QWidget::setEnabled" instead of the lambda?

89

This triggers this warning:

QLayout: Attempting to add QLayout "" to QGroupBox "", which already has a layout

I've just found out that QWidget::setLayout(QLayout *layout) will take ownership of "layout":
https://doc.qt.io/qt-5/qwidget.html#setLayout
so I guess there is no need to set a parent for partialLayout when instantiating it.

92

Coding style, no space after ( or before ), IIUC.

93

Same.

96

"If cancelled, automatically delete partially uploaded files smaller than"

And same coding style as before.

Coding style is actually wildly inconsistent in that file, so I've stuck to what similar other lines have.