Create Task
Maniphest T12244

Move enum KSyntaxHighlighting::TextStyles
Closed, ResolvedPublic
Actions

Description

  1. Move KSyntaxHighlighting::Theme::TextStyles into enum class KSyntaxHighlighting::TextStyles. There is a "TODO KF6" in syntax-highlighting/src/lib/theme.h.
  1. Remove KTextEditor::DefaultStyles (ktexteditor's attribute.h) and reuse KSyntaxHighlighting::TextStyles instead (note, that the order of the enum changes a bit, but due to the BIC changes, this should be OK anyways.
dhaumann created this task.Nov 24 2019, 5:56 PM
dhaumann renamed this task from KSyntaxHighlighting Text Styles to Move enum KSyntaxHighlighting::TextStyles.
vkrause moved this task from Backlog to Waiting on KF6 Branching on the KF6 board.Nov 25 2019, 9:35 PM
cullmann added a subscriber: cullmann.Jul 9 2023, 4:50 PM

We did remove the KTextEditor::DefaultStyles , I see no reason to move the enums beside creating porting work, there is no harm in having them in the theme.