Assign "Identifier" attribute to opening double quote instead of "Comment"
ClosedPublic

Authored by bewuethr on Thu, May 14, 4:07 AM.

Details

Summary

When the PostgreSQL syntax definition file was converted from using named attributes and contexts instead of numbers in this commit, the attribute for an opening double quote was incorrectly set to "Comment" instead of "Identifier". This patch fixes that.

BUG: 421445

Test Plan

Incorrect opening double quote before fix:

Correct opening double quote after fix:

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bewuethr created this revision.Thu, May 14, 4:07 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptThu, May 14, 4:07 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
bewuethr requested review of this revision.Thu, May 14, 4:07 AM
dhaumann accepted this revision.Thu, May 14, 6:31 AM
dhaumann added a subscriber: dhaumann.

Good catch :) please commit

This revision is now accepted and ready to land.Thu, May 14, 6:31 AM

@cullmann could you integrate this?

Sure, thanks for the improvement!

This revision was automatically updated to reflect the committed changes.