Get the pixel size directly from the always available output device
interface instead of saving an additional copy in the backends.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
KWin - Maniphest Tasks
- T11459: AbstractWaylandOutput and output device consolidation
- Commits
- R108:dbb2cede087a: Get output pixel size from output device
Nested Wayland, Drm, virtual backends tested.
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| abstract_wayland_output.cpp | ||
|---|---|---|
| 57 | This comment remains true, only even more so | |
Comment Actions
I think this diff might be the reason for hwc backend failing to build:
In file included from /home/pmos/build/src/kwin-5.16.90/plugins/platforms/hwcomposer/hwcomposer_backend.cpp:21:
/home/pmos/build/src/kwin-5.16.90/plugins/platforms/hwcomposer/hwcomposer_backend.h:58:11: error: 'QSize KWin::HwcomposerOutput::pixelSize() const' marked 'override', but does not override
58 | QSize pixelSize() const override;
| ^~~~~~~~~
/home/pmos/build/src/kwin-5.16.90/plugins/platforms/hwcomposer/hwcomposer_backend.h:135:10: warning: 'virtual void KWin::HwcomposerWindow::present(HWComposerNativeWindowBuffer*)' can be marked override [-Wsuggest-override]I've committed a fix 6ee6cc0293381098531ae5e117b1006f28d65346