AbstractWaylandOutput and output device consolidation
Closed, ResolvedPublic
Actions

Description

With AbstractOutput all backends have a common parent class and Wayland session ones the subclass AbstractWaylandOutput. The later one includes all the necessary functionality for creation of KWayland::Server::OutputDeviceInterface objects.

Goal 1: Let all backends use the AbstractWaylandOutput functions instead of the alternative code path in WaylandServer::syncOutputsToWayland.
D23473 D23477 D23478 D23479 D23485

Goal 2: Make sure an output device always exists for an output. Remove unnecessary checks.
D23486

Goal 3: Single source of truth for data in output device objects (remove data duplication in AbstractWaylandOutput).
D23489 D23493 D23495 D23496 D23546

Goal 4: Improve robustness of basic output functionality
D23591 D23600 D23602

Details

Differential Revisions: D23602: [platforms/drm] Early platform and outputs teardown
D23600: [platforms/drm] Rework enablement and dpms switching
D23496: Get output physical size from output device
D23495: Get output pixel size from output device
D23493: [server] Cache current mode
D23489: Get output position and scale from output device interface
D23486: Rely on output device existence
D23485: Remove outputs handling alternative
D23479: [platforms/x11/windowed] Create output devices
D23478: [platforms/fbdev] Create output device
D23477: [platforms/virtual] Create output devices
D23473: [platforms/wayland] Create output devices

Related Objects

Mentioned In: D24112: [platforms/drm] Disable transformations
R108:df3c1de8484e: [platforms/drm] Rework enablement and dpms switching
R108:732610bd8fba: [platforms/drm] Early platform and outputs teardown
R108:5cc626c10261: Remove outputs handling alternative
R108:331f5d7da7b9: Get output physical size from output device
R108:dbb2cede087a: Get output pixel size from output device
R127:ce5e25a4b63c: [server] Cache current mode
R108:819609a8a6b4: Get output position and scale from output device interface
R108:0bcfb4d609ea: Rely on output device existence
D19860: Software rotation: orient the screen regardless of whether drm accepted it
R108:edb200f6bcd5: [platforms/x11/windowed] Create output devices
R108:d960be4b3f39: [platforms/fbdev] Create output device
R108:cd6b69a4d2db: [platforms/virtual] Create output devices
R108:f013a4369c2e: [platforms/wayland] Create output devices
Mentioned Here: D23602: [platforms/drm] Early platform and outputs teardown
D23600: [platforms/drm] Rework enablement and dpms switching
D23546: Get name and refresh rate from output device
D23591: [platforms/drm] Disable orientation sensor for now
D23496: Get output physical size from output device
D23495: Get output pixel size from output device
D23493: [server] Cache current mode
D23489: Get output position and scale from output device interface
D23486: Rely on output device existence
D23485: Remove outputs handling alternative
D23477: [platforms/virtual] Create output devices
D23478: [platforms/fbdev] Create output device
D23479: [platforms/x11/windowed] Create output devices
D23473: [platforms/wayland] Create output devices

romangg created this task.Aug 26 2019, 10:40 PM

romangg added revisions: D23473: [platforms/wayland] Create output devices, D23477: [platforms/virtual] Create output devices, D23478: [platforms/fbdev] Create output device, D23479: [platforms/x11/windowed] Create output devices.

Does hwcomposer platform also need similar change?

In T11459#196722, @alexeymin wrote:

Does hwcomposer platform also need similar change?

It already calls handleOutputs() so I ignored it, ~~but thinking about it again it also doesn't create the output device yet, so yes.~~ Scratch this: it does indeed create the output device already in the HwcomposerOutput constructor. So no changes needed.

romangg mentioned this in R108:f013a4369c2e: [platforms/wayland] Create output devices.Aug 27 2019, 10:21 AM

romangg mentioned this in R108:cd6b69a4d2db: [platforms/virtual] Create output devices.Aug 27 2019, 10:24 AM

romangg mentioned this in R108:d960be4b3f39: [platforms/fbdev] Create output device.Aug 27 2019, 10:29 AM

romangg mentioned this in R108:edb200f6bcd5: [platforms/x11/windowed] Create output devices.Aug 27 2019, 10:33 AM

romangg added a revision: D23485: Remove outputs handling alternative.Aug 27 2019, 10:50 AM

romangg updated the task description. (Show Details)

romangg added a revision: D23486: Rely on output device existence.Aug 27 2019, 11:31 AM

romangg updated the task description. (Show Details)

romangg added a revision: D23489: Get output position and scale from output device interface.Aug 27 2019, 12:51 PM

romangg updated the task description. (Show Details)

romangg added a revision: D23493: [server] Cache current mode.Aug 27 2019, 1:33 PM

romangg updated the task description. (Show Details)