Differential D26199

Remove unneeded shortcut for page naviagtion
AbandonedPublic
Actions

Authored by nicolasfella on Dec 23 2019, 10:37 PM.

Details

Reviewers
ngraham
apol
Group Reviewers
Discover Software Store
Summary

Kirigami provides shortcuts for page navigation out of the box

Test Plan

Still can switch pages by Alt+Arrow

Diff Detail

Repository
R134 Discover Software Store
Branch
shortcut
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20229
Build 20247: arc lint + arc unit
nicolasfella created this revision.Dec 23 2019, 10:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 23 2019, 10:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Dec 23 2019, 10:37 PM
alexeymin added a subscriber: alexeymin.Dec 23 2019, 11:24 PM

Doesn't work for me, needs very fresh kirigami too?

ngraham accepted this revision.Dec 23 2019, 11:27 PM
ngraham added a subscriber: ngraham.

Works for me with Kirigami from git master.

This revision is now accepted and ready to land.Dec 23 2019, 11:27 PM
apol requested changes to this revision.Dec 24 2019, 11:47 AM
apol added a subscriber: apol.

This is not for changing pages, it's about scrolling vertically.

This revision now requires changes to proceed.Dec 24 2019, 11:47 AM
ngraham requested changes to this revision.Dec 24 2019, 3:02 PM

Oh gosh, so sorry!

nicolasfella abandoned this revision.Dec 25 2019, 3:57 PM

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/DiscoverPage.qml (17 lines)

Diff 72122

View Options

discover/qml/DiscoverPage.qml

Loading...