[Places panel] use more appropriate network icon

Authored by ngraham on Oct 3 2018, 11:07 PM.



The current Breeze icon used for the default Network(network-workgroup) is not ideal for several reasons:

  • It it not clear what it depicts (I was told it's a server rack, but there's not enough detail to make this apparent)
  • Even if the visuals were clear, its iconography (a server rack) is not familiar to people who are not sysadmins

This patch replaces it with folder-network, which yields the following improvements:

  • This icon includes the "sideways dotted V" imagery that is used in other contexts (shared folder emblem, Share menu, which teaches the user its meaning
  • Many other platforms use circular globe or world iconography for their network icons. Even though this new icon is not a globe or world, it is circular, which helps to re-use some of a user's prior experience on other platforms
  • Semantically, folder-network is just a more appropriate icon to use for this than network-workgroup. The item leads to the whole network, not a specific workgroup.
Test Plan

New icon shows up in all Places panels for new user accounts, or if you delete ~/.local/share/user-places.xbel in an existing user account

Dolphin Places panel:

Diff Detail

R241 KIO
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Oct 3 2018, 11:07 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 3 2018, 11:07 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 3 2018, 11:07 PM

+1 from me, makes sense. I say that as a guy who stares at server racks all day.

broulik added a subscriber: broulik.Oct 4 2018, 7:43 AM

Oxygen uses a globe for "network-workgroup" and a folder with a cable as "folder-network", someone might wanted to have a globe icon here for recognizability ;)

nicolasfella accepted this revision.Oct 4 2018, 7:16 PM
This revision is now accepted and ready to land.Oct 4 2018, 7:16 PM
andreaska accepted this revision.Oct 4 2018, 7:17 PM
This revision was automatically updated to reflect the committed changes.