Extend Open Document thumbnailer to Open Packaging Conventions format
ClosedPublic

Authored by broulik on Tue, Feb 5, 7:38 PM.

Details

Summary

This extracts thumbnails from formats such as Office Open XML (docx, xlsx, pptx, as well as their templates) and other formats following that spec that make sense for "office documents" such as xps.

Test Plan

The thumbnailer library name is kept to avoid changes when user updates and both do have "open" in the name :) I just dropped the Open Document Files suffix

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Tue, Feb 5, 7:38 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptTue, Feb 5, 7:38 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Tue, Feb 5, 7:38 PM
acrouthamel added a subscriber: acrouthamel.

Thanks for expanding the thumbnailer lately, awesome work with this and the eBook one. :)

davidedmundson requested changes to this revision.Fri, Feb 8, 11:47 AM
davidedmundson added a subscriber: davidedmundson.

It seems we can get the correct path via the _rels file as per
https://en.wikipedia.org/wiki/Open_Packaging_Conventions

which avoids guessing, and allows us to support more file formats in one go

This revision now requires changes to proceed.Fri, Feb 8, 11:47 AM
broulik updated this revision to Diff 51173.Fri, Feb 8, 12:01 PM
  • Read thumbnail location from rels
  • Add .xps file format (used in Windows for printing, I believe) which also follows the spec and qualifies as "office document"
broulik retitled this revision from Extend Open Document thumbnailer to Office Open XML to Extend Open Document thumbnailer to Open Packaging Conventions format.Fri, Feb 8, 12:06 PM
broulik edited the summary of this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Fri, Feb 8, 12:20 PM
This revision is now accepted and ready to land.Fri, Feb 8, 12:20 PM
This revision was automatically updated to reflect the committed changes.