slenz (Silas Lenz)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 17 2018, 7:15 PM (35 w, 14 h)
Availability
Available

Recent Activity

Thu, Oct 18

slenz added a comment to D16259: Open document before using it's checksum to load metainfos.

@slenz Thanks for this nice patch, please keep it coming :-)

Thu, Oct 18, 7:35 AM · Kate

Wed, Oct 17

slenz added a comment to D16259: Open document before using it's checksum to load metainfos.

Thank you for the quick review! Could you also land this patch for me? I don't have commit rights yet.

Wed, Oct 17, 12:22 PM · Kate
slenz updated the diff for D16259: Open document before using it's checksum to load metainfos.

Pass SkipUrl to readSessionConfig to avoid double loading

Wed, Oct 17, 12:16 PM · Kate

Tue, Oct 16

slenz added a reviewer for D16259: Open document before using it's checksum to load metainfos: Kate.
Tue, Oct 16, 8:26 PM · Kate
slenz added a comment to D16259: Open document before using it's checksum to load metainfos.

I'm assuming (based on the previous docstring) that loadMetaInfos at some point also opened the url and the old doc->openUrl(u); was a fallback in case it it did not not (feature disabled, first time to open url, etc). That seems to have been removed at some point, so now it tried to load metainfo based on an empty document (and empty checksum), which of course always failed. I can't find any drawbacks to always loading the file in one place, but please tell me if there was a reason for the two different methods!

Tue, Oct 16, 8:20 PM · Kate
slenz requested review of D16259: Open document before using it's checksum to load metainfos.
Tue, Oct 16, 8:12 PM · Kate

Tue, Sep 25

slenz updated the diff for D15749: Add tooltips to krunner configure and close buttons.

Remove "KRunner" from configure tooltip

Tue, Sep 25, 7:12 PM · Plasma
slenz added inline comments to D15749: Add tooltips to krunner configure and close buttons.
Tue, Sep 25, 6:56 PM · Plasma
slenz updated the diff for D15749: Add tooltips to krunner configure and close buttons.

Add ellipses and KRunner to configure tooltip.

Tue, Sep 25, 6:55 PM · Plasma
slenz updated the summary of D15749: Add tooltips to krunner configure and close buttons.
Tue, Sep 25, 5:41 PM · Plasma
slenz requested review of D15749: Add tooltips to krunner configure and close buttons.
Tue, Sep 25, 5:40 PM · Plasma

Apr 5 2018

slenz updated the diff for D11105: Update window title when changing selection in comparison mode.
  • Avoid one more unneeded updateCaption call
Apr 5 2018, 11:43 AM · Gwenview

Apr 4 2018

slenz added a comment to D11105: Update window title when changing selection in comparison mode.

You have a point (as usual) :D

Apr 4 2018, 8:08 PM · Gwenview
slenz updated the diff for D11105: Update window title when changing selection in comparison mode.
  • Revert to original emitFocused
Apr 4 2018, 7:48 PM · Gwenview
slenz updated the diff for D11105: Update window title when changing selection in comparison mode.
  • Style change
Apr 4 2018, 8:15 AM · Gwenview

Apr 3 2018

slenz added a comment to D11105: Update window title when changing selection in comparison mode.

Sorry to say - there is still a problem. When adding the 6th image, the caption jumps from 'a.jpg' to 'f.jpg' and after deselecting it again the caption still shows 'f.jpg'.

Apr 3 2018, 2:41 PM · Gwenview
slenz updated the diff for D11105: Update window title when changing selection in comparison mode.
  • Move around caption update to catch more cases
Apr 3 2018, 2:37 PM · Gwenview
slenz updated the test plan for D11105: Update window title when changing selection in comparison mode.
Apr 3 2018, 1:40 PM · Gwenview
slenz added a comment to D11105: Update window title when changing selection in comparison mode.

Got stuck on a whole bunch of assignments and then a vacation, sorry about the delay :)

Apr 3 2018, 1:34 PM · Gwenview
slenz updated the diff for D11105: Update window title when changing selection in comparison mode.
  • Only update caption when the selected image completed loading and not when others have
Apr 3 2018, 1:15 PM · Gwenview
slenz updated the diff for D11105: Update window title when changing selection in comparison mode.
  • Merge branch 'master' of git://anongit.kde.org/gwenview into fullscreencaptionupdate
  • Only update caption when the selected image is resized and not when others are
Apr 3 2018, 1:02 PM · Gwenview

Mar 12 2018

slenz added a comment to D11105: Update window title when changing selection in comparison mode.

The title updates correctly when selecting the image by mouse click.
But when adding or removing images to the multi view or while resizing the window (zoom factor change) the title does not always stick to the selected image.

Mar 12 2018, 12:03 PM · Gwenview

Mar 10 2018

slenz added a comment to D10700: KCalc display padding improvement.

Thanks for the review!

Mar 10 2018, 6:00 PM
slenz updated the diff for D10700: KCalc display padding improvement.

Rebase to master

Mar 10 2018, 4:57 PM

Mar 6 2018

slenz updated the diff for D11105: Update window title when changing selection in comparison mode.
  • Remove unwanted blank line
Mar 6 2018, 10:53 PM · Gwenview
slenz added a project to D11105: Update window title when changing selection in comparison mode: Gwenview.
Mar 6 2018, 10:48 PM · Gwenview
slenz requested review of D11105: Update window title when changing selection in comparison mode.
Mar 6 2018, 10:45 PM · Gwenview

Feb 28 2018

slenz added a comment to D10844: Replace "Fit Width" feature with "Fill".

Thanks, looks really good now. Any more changes planned? Otherwise I'll land it.

I'm done!

Feb 28 2018, 9:19 AM · Gwenview
slenz updated the summary of D10844: Replace "Fit Width" feature with "Fill".
Feb 28 2018, 9:14 AM · Gwenview
slenz updated the summary of D10844: Replace "Fit Width" feature with "Fill".
Feb 28 2018, 9:13 AM · Gwenview
slenz updated the diff for D10844: Replace "Fit Width" feature with "Fill".
  • Screen>Window
Feb 28 2018, 9:08 AM · Gwenview
slenz updated the diff for D10844: Replace "Fit Width" feature with "Fill".
  • Update documentation to avoid crop confusion
  • More elaborate tooltip
  • Use proper capitalization for tooltips
Feb 28 2018, 9:02 AM · Gwenview
slenz added inline comments to D10844: Replace "Fit Width" feature with "Fill".
Feb 28 2018, 8:41 AM · Gwenview

Feb 27 2018

slenz added inline comments to D10844: Replace "Fit Width" feature with "Fill".
Feb 27 2018, 11:56 PM · Gwenview
slenz updated the diff for D10844: Replace "Fit Width" feature with "Fill".
  • Update docbook with new button
  • Improve description for icon text
  • Switch to c++11 max function
Feb 27 2018, 11:48 PM · Gwenview
slenz added inline comments to D10844: Replace "Fit Width" feature with "Fill".
Feb 27 2018, 11:25 PM · Gwenview
slenz updated the diff for D10844: Replace "Fit Width" feature with "Fill".
  • Rename fill ratio variable
Feb 27 2018, 7:05 PM · Gwenview
slenz added inline comments to D10844: Replace "Fit Width" feature with "Fill".
Feb 27 2018, 10:29 AM · Gwenview
slenz updated the summary of D10844: Replace "Fit Width" feature with "Fill".
Feb 27 2018, 9:59 AM · Gwenview

Feb 26 2018

slenz added a project to D10844: Replace "Fit Width" feature with "Fill": Gwenview.
Feb 26 2018, 12:12 AM · Gwenview

Feb 25 2018

slenz updated subscribers of D10844: Replace "Fit Width" feature with "Fill".
Feb 25 2018, 11:47 PM · Gwenview
slenz requested review of D10844: Replace "Fit Width" feature with "Fill".
Feb 25 2018, 11:38 PM · Gwenview
slenz updated the diff for D10745: Update filename in fullscreen view on rename.

Remove missed debug line.

Feb 25 2018, 12:19 PM · Gwenview
slenz updated the diff for D10745: Update filename in fullscreen view on rename.

Add missing scrollToSelectedIndex() for full screen thumbnailBar.

Feb 25 2018, 12:16 PM · Gwenview
slenz added a comment to D10745: Update filename in fullscreen view on rename.

Only one thing found for a later patch: In normal mode, renaming causes the Thumbnail Bar to scroll to the new entry, while it does not yet in fullscreen mode.

I have a fix for that. Should i update the current patch or upload a new one?

Feb 25 2018, 11:52 AM · Gwenview

Feb 24 2018

slenz updated the summary of D10745: Update filename in fullscreen view on rename.
Feb 24 2018, 11:23 PM · Gwenview
slenz added a revision to T8071: Editing after renaming a file does not update preview and saves as previous filename: D10745: Update filename in fullscreen view on rename.
Feb 24 2018, 11:23 PM · Gwenview
slenz updated the diff for D10745: Update filename in fullscreen view on rename.

Switch from signal currentUrlChanged to function setCurrentUrl, which solves the same issue, but also sets the new url, solving T8071.

Feb 24 2018, 8:36 PM · Gwenview
slenz created T8071: Editing after renaming a file does not update preview and saves as previous filename.
Feb 24 2018, 8:26 PM · Gwenview

Feb 23 2018

slenz added a comment to D10745: Update filename in fullscreen view on rename.

... in Fullscreen View with the sidebar shown via F4, the filename in the Information panel was being updated, as well as the window title if you peeked at it via Alt+.

That's a good hint. ;)
ContextManager already 'knows' something has changed and emits both selectionChanged and selectionDataChanged signals. The sidebar information widget InfoContextManagerItem connects exactly these two to update its content. I think it would be a more general way to use this here too than just look at the rename case.

Feb 23 2018, 11:07 AM · Gwenview

Feb 22 2018

slenz added a comment to D10745: Update filename in fullscreen view on rename.

Thanks for working on that bug. :)
Although this approach works at first sight, it looks at least somewhat unusual to me calling a signal function from outside the class.
I'll take a closer look at it.

Feb 22 2018, 7:13 PM · Gwenview
slenz requested review of D10745: Update filename in fullscreen view on rename.
Feb 22 2018, 1:55 PM · Gwenview

Feb 20 2018

slenz updated the summary of D10700: KCalc display padding improvement.
Feb 20 2018, 9:42 PM
slenz requested review of D10700: KCalc display padding improvement.
Feb 20 2018, 9:36 PM