Ensures the overlay is painted in the same icon state, especially the selected one so dark overlays turn white.
Details
Details
- Reviewers
elvisangelaccio ngraham - Group Reviewers
Dolphin VDG - Commits
- R318:502a5c86feb0: [KStandardItemListWidget] Pass icon state to overlay painter
Before
After
No change for icon view as there (currently) is no highlight behind it
No change for when file has a preview as there you could end up with a white emblem on a white image
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
No change for when file has a preview as there you could end up with a white emblem on a white image
Not sure this is semantically correct. The fact that some emblems are white with no border is an implementation detail that Dolphin shouldn't have to care about. And we're fixing it soon anyway: https://bugs.kde.org/show_bug.cgi?id=399357
Comment Actions
Not sure this is semantically correct. The fact that some emblems are white with no border is an implementation detail that Dolphin shouldn't have to care about.
I agree, it's a separate issue, though, as I would have expected this codepath to also affect files with thumbnails but it does not, the overlays for thumbnails are painted in KFileItemModelRolesUpdater::slotGotPreview instead which doesn't have any notion of selected/hovered.