In D29886#676950, @ngraham wrote:Thanks! However we are using GitLab now. Any chance you could close this and re-submit it as a merge request at https://invent.kde.org/graphics/gwenview/-/merge_requests/?
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Jan 3 2022
Jan 3 2022
martonmiklos awarded T11070: Better (online) localization a Like token.
martonmiklos awarded T13514: Migrate KDE translations to Git a Like token.
Dec 23 2020
Dec 23 2020
Dec 21 2020
Dec 21 2020
Feb 18 2020
Feb 18 2020
martonmiklos requested review of D27486: Add FreeCAD FCMacro extension to the python highlighting definition.
Dec 30 2019
Dec 30 2019
In D26264#584826, @ngraham wrote:FWIW we're planning to remove KHotKeys in favor of KGlobalAccel: T2050: sunsetting KHotKeys. I'm not sure how much sense it makes to add features to it.
Dec 29 2019
Dec 29 2019
LGTM
Dec 28 2019
Dec 28 2019
martonmiklos updated the test plan for D26264: Add record keystrokes feature to the hotkeys KCM module.
Feb 24 2019
Feb 24 2019
In D18967#418001, @cfeck wrote:Does it work when Caps Lock is on?
Fix grammar mistake
Feb 12 2019
Feb 12 2019
martonmiklos added a comment to D10555: Accept dot as decimal separator even if the decimal separator is comma and the group separator is not dot neither comma .
May I ask for an another round of review (and if looks good merge?)
Thanks in advance for your time!
martonmiklos updated the summary of D18967: Allow entering hex letters when the shift key is pressed.
Aug 16 2018
Aug 16 2018
martonmiklos updated the diff for D10555: Accept dot as decimal separator even if the decimal separator is comma and the group separator is not dot neither comma .
Thanks for the review, I have changed the raw char literals to QChar-s.
martonmiklos updated the diff for D8271: Make the KCalc remember to the Bitfield editor visiblity state when changing numeral modes .
Fix review comment.
Jul 23 2018
Jul 23 2018
martonmiklos updated the diff for D14275: Add Autodesk EAGLE sch and brd file format to the XML category.
Updated revision to 8 from 7 as suggested in the review.
Jul 22 2018
Jul 22 2018
martonmiklos added a comment to D8271: Make the KCalc remember to the Bitfield editor visiblity state when changing numeral modes .
Any news on the reviewing of this one guys?
martonmiklos requested review of D14275: Add Autodesk EAGLE sch and brd file format to the XML category.
Feb 16 2018
Feb 16 2018
Feb 15 2018
Feb 15 2018
martonmiklos added a comment to D10555: Accept dot as decimal separator even if the decimal separator is comma and the group separator is not dot neither comma .
In D10555#207396, @cfeck wrote:Thanks Marton, I will review in the coming days. There are some issues in the patch.
martonmiklos retitled D10555: Accept dot as decimal separator even if the decimal separator is comma and the group separator is not dot neither comma from Accept both decimal separators (dot and comma) if the group separator is not dot neither comma to Accept dot as decimal separator even if the decimal separator is comma and the group separator is not dot neither comma .
Oct 12 2017
Oct 12 2017
martonmiklos added inline comments to D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.
martonmiklos updated the diff for D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.
Oct 2 2017
Oct 2 2017
martonmiklos added a comment to D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.
In D7847#151101, @ltoscano wrote:I can't judge the patch, but if this is accepted remember to:
- use the authorship information of Arjun AK
- and possibly add a Co-Authored-By: line with the information of martonmiklos
martonmiklos added a comment to D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.
Many thanks for the reviews, I have fixed them.
martonmiklos updated the diff for D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.
Oct 1 2017
Oct 1 2017
martonmiklos retitled D7847: Don't block unmounting when terminal panel's cwd is the mountpoint from Change the terminal panel opened directory to the home directory if a to be unmounted path is open to prevent the blocking of the unmounting process to Don't block unmounting when terminal panel's cwd is the mountpoint.
martonmiklos added a comment to D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.
In D7847#151233, @ngraham wrote:Thanks for those stylistic changes, @martonmiklos. However the title is still a bit long. How about something more like this:
"Don't block unmounting when terminal panel's cwd is the mountpoint"
martonmiklos updated the diff for D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.
martonmiklos added a comment to D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.
@elvisangelaccio
After several trials I consider the "set unmounted directory to home" out of scope of this patch because I have not found any method which could reliably set the tabs with unmounted paths to home in time.
At the moment I can only think about some QTimer based hack, but I would not like to include it to this patch.
martonmiklos retitled D7847: Don't block unmounting when terminal panel's cwd is the mountpoint from Fix bug 158264 - Terminal panel (konsole part) blocks the umount of removable media to Change the terminal panel opened directory to the home directory if a to be unmounted path is open to prevent the blocking of the unmounting process.
Sep 29 2017
Sep 29 2017
martonmiklos planned changes to D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.
@elvisangelaccio
I have implemented the "storage teardown requested -> set the opened tabs to home if mounting path is open" method, but this approach cannot close the terminal in time when the teardown request came externally. (Umount requested from the indicator applet for e.g.). The tabs are set to the home directory properly both the terminal, but the unmount manager says that the mountpath is opened in an application.
I would rather merge the two approaches: asking the terminal to cd to home first and then loop over the tabs and set them to home if mountpath is opened.
Sep 17 2017
Sep 17 2017
martonmiklos added a comment to D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.
In D7847#146547, @elvisangelaccio wrote:I'm not sure I agree with this patch.
A standard behavior in other filemanagers when umounting a device is to redirect to the view from the device URL to the home URL.
So imho this patch is using the wrong approach: instead of the mainwindow telling the terminal panel to go to the home, it should be the mainwindow the one that changes its URL to the home.This way:
- We get an usable DolphinView after unmounting the device (matching the behavior of e.g. Nautilus)
- We don't need the goHome() method in TerminalPanel, it would be automatic.
Sep 16 2017
Sep 16 2017
martonmiklos added inline comments to D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.
Sep 10 2017
Sep 10 2017
martonmiklos added a comment to D7367: Added Intel HEX file support for the Syntax highlighting database.
In D7367#143391, @cullmann wrote:Should be fixed now:
commit fd79b6842c6f33a1aca4f500354ca2a69c52689e
Author: Christoph Cullmann <cullmann@kde.org>
Date: Wed Sep 6 08:08:49 2017 +0200add missing reference files for tests, looks ok, I think Differential Revision: https://phabricator.kde.org/D7367
Sep 5 2017
Sep 5 2017
martonmiklos added a comment to D7367: Added Intel HEX file support for the Syntax highlighting database.
In D7367#143314, @cullmann wrote:syntax-highlighting.git, on first glance not landed atm.
Can you commit on your own or should I push it for you Miklos?
Aug 21 2017
Aug 21 2017
martonmiklos added a comment to D7367: Added Intel HEX file support for the Syntax highlighting database.
In D7367#138232, @cullmann wrote:Hmm, the diff still looks like it has the old names, perhaps the update went wrong somehow?
martonmiklos updated the diff for D7367: Added Intel HEX file support for the Syntax highlighting database.
martonmiklos added a comment to D7367: Added Intel HEX file support for the Syntax highlighting database.
In D7367#138030, @cullmann wrote:I am happy beside one thing I missed: I think the file should be called intelhex.xml, given its for the intel hex format only (the name is already fine, did miss that the filename is only hex).
Otherwise: very nice, thanks again for the contribution.
Aug 17 2017
Aug 17 2017
martonmiklos updated the diff for D7367: Added Intel HEX file support for the Syntax highlighting database.
Okay so:
- License updated to MIT
- Added detection for invalid RecordType (05<)
- Changed formatting to use builtin formats
- Added autotest case with a sample file with two malformed lines and a HTML output
- I think folding tests are not acceptible for this file type.
martonmiklos added a comment to D7367: Added Intel HEX file support for the Syntax highlighting database.
In D7367#136687, @cullmann wrote:Could you add a minimal example as unit test?
Sure, I have just seen that these xmls could be autotested.