Differential D18967

Allow entering hex letters when the shift key is pressed
ClosedPublic
Actions

Authored by martonmiklos on Feb 12 2019, 7:43 PM.

Details

Reviewers
cfeck
xyquadrat
teran
Commits
R353:5763ce932d66: Accept hex letters with the Shift key pressed
Summary

When the kcalc is switched to hexadecimal mode the A-B-C-D-E-F characters cannot be entered when the shift is pressed. This patch enables this.

Fixes #283521

Test Plan

Open kcalc
Switch to hex mode
Press your shift key
Type abcdef
Shift to decimal mode
kcalc shall display 11259375

Diff Detail

Repository
R353 KCalc
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
martonmiklos created this revision.Feb 12 2019, 7:43 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptFeb 12 2019, 7:43 PM
martonmiklos requested review of this revision.Feb 12 2019, 7:43 PM
martonmiklos edited the summary of this revision. (Show Details)
cfeck added a comment.Feb 23 2019, 2:34 PM

Does it work when Caps Lock is on?

kcalc.cpp
818

does not works properly

martonmiklos updated this revision to Diff 52427.Feb 24 2019, 8:53 AM

Fix grammar mistake

martonmiklos marked an inline comment as done.Feb 24 2019, 8:55 AM
In D18967#418001, @cfeck wrote:

Does it work when Caps Lock is on?

Yes it does.

cfeck accepted this revision.Jul 10 2019, 6:36 PM
This revision is now accepted and ready to land.Jul 10 2019, 6:36 PM
Closed by commit R353:5763ce932d66: Accept hex letters with the Shift key pressed (authored by martonmiklos, committed by cfeck). · Explain WhyJul 10 2019, 7:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcalc.cpp (28 lines)

Diff 61536

View Options

kcalc.cpp

Loading...