Add record keystrokes feature to the hotkeys KCM module
Needs ReviewPublic

Authored by martonmiklos on Dec 28 2019, 11:58 PM.

Details

Summary

To add a keystroke sending shortcut to KDE the user had to understand the ways KCM interprets the keystroke commands.
This patch adds option to record the key presses by typing:
https://imgur.com/delete/Kz5duowvpGVuhZl

Test Plan
  1. Create a new global shortcut with KCM
  2. Go to Action page
  3. Hit Record key strokes button
  4. Type something
  5. Click again on the button
  6. Save with Apply
  7. Open up Kate for e.g.
  8. Trigger the global shortcut

https://imgur.com/delete/Kz5duowvpGVuhZl

Diff Detail

Repository
R101 KHotKeys
Lint
Lint Skipped
Unit
Unit Tests Skipped
martonmiklos created this revision.Dec 28 2019, 11:58 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 28 2019, 11:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
martonmiklos requested review of this revision.Dec 28 2019, 11:58 PM
martonmiklos edited the test plan for this revision. (Show Details)

FWIW we're planning to remove KHotKeys in favor of KGlobalAccel: T2050: sunsetting KHotKeys. I'm not sure how much sense it makes to add features to it.

FWIW we're planning to remove KHotKeys in favor of KGlobalAccel: T2050: sunsetting KHotKeys. I'm not sure how much sense it makes to add features to it.

Yeah I seen that recently (after the submitting the implementation). It might be useful to add some README.md to the git repo I think with this information.

I would say let's get it reviewed, since this is a kind of standalone feature which could be ported to KGlobalAccel as well I think.
Don't you know accidentally if there is an existing KCM code for the KGlobalAccel? And if it do exists which repo can I find that?

The kglobalaccel KCM is unhelpfully named keys and lives in plasma-desktop: https://cgit.kde.org/plasma-desktop.git/tree/kcms/keys