Differential D29886

Do not restore the JPG quality on save operation
AbandonedPublic
Actions

Authored by ngraham on Dec 21 2020, 3:07 PM.

Details

Reviewers
martonmiklos
Summary

The "Save as" dialog allowed to save images with different JPG quality.
After performing the save as operation the JPEG quality was restored to the original configuration (making the save as dialog settings one time only).

However if the user only saved the modified image this same restoration process was performed too.
But in this case the variable (configFileJPEGQualityValue) had the value which have been set at startup not on the start of the save process.

I have moved the restoration process to be ran only on the save as procedure.

BUG: 423414

Test Plan

Repeat the steps visible in this video:
https://bugs.kde.org/attachment.cgi?id=129695

As the last check step the quality set at the beginning should be visible in the settings.

Diff Detail

Repository
R260 Gwenview
Lint
Lint Skipped
Unit
Unit Tests Skipped
martonmiklos requested review of this revision.Dec 21 2020, 3:07 PM
martonmiklos created this revision.
ngraham added a comment.Dec 23 2020, 3:26 PM

Thanks! However we are using GitLab now. Any chance you could close this and re-submit it as a merge request at https://invent.kde.org/graphics/gwenview/-/merge_requests/?

martonmiklos added a comment.Dec 23 2020, 4:39 PM
In D29886#676950, @ngraham wrote:

Thanks! However we are using GitLab now. Any chance you could close this and re-submit it as a merge request at https://invent.kde.org/graphics/gwenview/-/merge_requests/?

I have submitted an MR on gitlab. See you there!
https://invent.kde.org/graphics/gwenview/-/merge_requests/26

ngraham commandeered this revision.Dec 28 2020, 9:21 PM
ngraham edited reviewers, added: martonmiklos; removed: ngraham.

And it's merged. :)

ngraham abandoned this revision.Dec 28 2020, 9:21 PM

Revision Contents
Changeset List

PathPackages
Mapp/gvcore.cpp (10 lines)

Diff 83387

View Options

app/gvcore.cpp

Loading...