Differential D8271

Make the KCalc remember to the Bitfield editor visiblity state when changing numeral modes
ClosedPublic
Actions

Authored by martonmiklos on Oct 12 2017, 9:55 PM.

Details

Reviewers
teran
cfeck
Commits
R353:4ecb1a0f377b: Remember the Bitfield editor visiblity state
Summary

The bitfield editor could be only displayed in binary numeral mode.

If the user selects a different numeral mode from binary and then switches back to binary the it would be feasible to display the bitfield editor if last time it was opened.

BUG: 324429

Test Plan

Test Case A:

  • Open KCalc.
  • Select Binary numeral mode
  • Display the bitfield editor
  • Select a non-Binary numeral mode
  • Select Binary numeral mode
  • The bitfield editor should be visible

Test Case B:

  • Open KCalc.
  • Select Binary numeral mode
  • Hide the bitfield editor
  • Select a non-Binary numeral mode
  • Select Binary numeral mode
  • The bitfield editor should not be visible

Diff Detail

Repository
R353 KCalc
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
martonmiklos created this revision.Oct 12 2017, 9:55 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptOct 12 2017, 9:55 PM
martonmiklos added a comment.Jul 22 2018, 5:00 PM

Any news on the reviewing of this one guys?

cfeck added inline comments.Aug 15 2018, 2:38 PM
kcalc.cpp
2014
if (...) {
    ...
}

even for single statements

martonmiklos updated this revision to Diff 39874.Aug 16 2018, 5:44 PM

Fix review comment.

martonmiklos marked an inline comment as done.Aug 16 2018, 5:44 PM
cfeck accepted this revision.Aug 16 2018, 7:09 PM
This revision is now accepted and ready to land.Aug 16 2018, 7:09 PM
Closed by commit R353:4ecb1a0f377b: Remember the Bitfield editor visiblity state (authored by martonmiklos, committed by cfeck). · Explain WhyAug 16 2018, 7:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcalc.cpp (16 lines)

Diff 39876

View Options

kcalc.cpp

Loading...